|
 |
3e75f9 |
From bb3859b9e76b31a71c74c88791abc5ccb1776a01 Mon Sep 17 00:00:00 2001
|
|
|
3e75f9 |
From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= <fidencio@redhat.com>
|
|
|
3e75f9 |
Date: Thu, 15 Aug 2019 17:03:37 +0200
|
|
|
3e75f9 |
Subject: [PATCH virt-viewer] ovirt-foreign-menu: Fix warnings on Rawhide
|
|
|
3e75f9 |
MIME-Version: 1.0
|
|
|
3e75f9 |
Content-Type: text/plain; charset=UTF-8
|
|
|
3e75f9 |
Content-Transfer-Encoding: 8bit
|
|
|
3e75f9 |
|
|
|
3e75f9 |
gmaovirt-foreign-menu.c: In function 'storage_domains_fetched_cb':
|
|
|
3e75f9 |
ovirt-foreign-menu.c:721:9: error: format not a string literal and no format arguments [-Werror=format-security]
|
|
|
3e75f9 |
721 | g_debug(msg);
|
|
|
3e75f9 |
| ^~~~~~~
|
|
|
3e75f9 |
ovirt-foreign-menu.c:722:9: error: format not a string literal and no format arguments [-Werror=format-security]
|
|
|
3e75f9 |
722 | g_task_return_new_error(task, OVIRT_ERROR, OVIRT_ERROR_FAILED, msg);
|
|
|
3e75f9 |
| ^~~~~~~~~~~~~~~~~~~~~~~
|
|
|
3e75f9 |
cc1: some warnings being treated as errors
|
|
|
3e75f9 |
gmake[3]: *** [Makefile:963: libvirt_viewer_la-ovirt-foreign-menu.lo] Error 1
|
|
|
3e75f9 |
gmake[2]: *** [Makefile:647: all] Error 2
|
|
|
3e75f9 |
gmake[1]: *** [Makefile:482: all-recursive] Error 1
|
|
|
3e75f9 |
make: *** [Makefile:410: all] Error 2
|
|
|
3e75f9 |
error: Bad exit status from /var/tmp/rpm-tmp.f14Lmj (%build)
|
|
|
3e75f9 |
|
|
|
3e75f9 |
Errors have been caught by https://ci.centos.org/job/virt-viewer-rpm/systems=libvirt-fedora-rawhide/589/
|
|
|
3e75f9 |
|
|
|
3e75f9 |
Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
|
|
|
3e75f9 |
Acked-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
|
|
|
3e75f9 |
---
|
|
|
3e75f9 |
src/ovirt-foreign-menu.c | 4 ++--
|
|
|
3e75f9 |
1 file changed, 2 insertions(+), 2 deletions(-)
|
|
|
3e75f9 |
|
|
|
3e75f9 |
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
|
|
|
3e75f9 |
index cbb0e88..cdf9879 100644
|
|
|
3e75f9 |
--- a/src/ovirt-foreign-menu.c
|
|
|
3e75f9 |
+++ b/src/ovirt-foreign-menu.c
|
|
|
3e75f9 |
@@ -715,8 +715,8 @@ static void storage_domains_fetched_cb(GObject *source_object,
|
|
|
3e75f9 |
const char *msg = domain_valid ? "Could not find ISO file collection"
|
|
|
3e75f9 |
: "Could not find valid ISO storage domain";
|
|
|
3e75f9 |
|
|
|
3e75f9 |
- g_debug(msg);
|
|
|
3e75f9 |
- g_task_return_new_error(task, OVIRT_ERROR, OVIRT_ERROR_FAILED, msg);
|
|
|
3e75f9 |
+ g_debug("%s", msg);
|
|
|
3e75f9 |
+ g_task_return_new_error(task, OVIRT_ERROR, OVIRT_ERROR_FAILED, "%s", msg);
|
|
|
3e75f9 |
g_object_unref(task);
|
|
|
3e75f9 |
}
|
|
|
3e75f9 |
}
|
|
|
3e75f9 |
--
|
|
|
3e75f9 |
2.21.0
|
|
|
3e75f9 |
|