diff --git a/SOURCES/virt-manager-addstorage-Don-t-pass-None-to-widget.set_active.patch b/SOURCES/virt-manager-addstorage-Don-t-pass-None-to-widget.set_active.patch new file mode 100644 index 0000000..51b77dc --- /dev/null +++ b/SOURCES/virt-manager-addstorage-Don-t-pass-None-to-widget.set_active.patch @@ -0,0 +1,33 @@ +From b533019b5776207412ed1aa886d97ead2550695a Mon Sep 17 00:00:00 2001 +From: Cole Robinson +Date: Sat, 21 Nov 2020 17:17:33 -0500 +Subject: [PATCH] addstorage: Don't pass None to widget.set_active() + +Older pygobject can't handle it. Mentioned here: +https://github.com/virt-manager/virt-manager/issues/188 + +Signed-off-by: Cole Robinson +(cherry picked from commit e7222b5058c8874b15fbfd998e5eeb233f571075) + +Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2026987 +Signed-off-by: Jonathon Jongsma +--- + virtManager/device/addstorage.py | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/virtManager/device/addstorage.py b/virtManager/device/addstorage.py +index dee0160c..49d0b693 100644 +--- a/virtManager/device/addstorage.py ++++ b/virtManager/device/addstorage.py +@@ -310,7 +310,7 @@ class vmmAddStorage(vmmGObjectUI): + detect_zeroes = disk.driver_detect_zeroes + ro = disk.read_only + share = disk.shareable +- removable = disk.removable ++ removable = bool(disk.removable) + serial = disk.serial + + self.set_disk_bus(disk.bus) +-- +2.31.1 + diff --git a/SPECS/virt-manager.spec b/SPECS/virt-manager.spec index fe2cbc3..7225b05 100644 --- a/SPECS/virt-manager.spec +++ b/SPECS/virt-manager.spec @@ -8,7 +8,7 @@ Name: virt-manager Version: 3.2.0 -Release: 1%{?dist}%{?extra_release} +Release: 2%{?dist}%{?extra_release} %global verrel %{version}-%{release} Summary: Desktop tool for managing virtual machines via libvirt @@ -25,6 +25,7 @@ Patch4: virt-manager-hostdev-use-method-get_mdev_uuid.patch Patch5: virt-manager-tests-verify-MDEV-support.patch Patch6: virt-manager-virt-manager-enable-MDEV-support.patch Patch7: virt-manager-Handle-new-nodedev-name-for-mediated-devices.patch +Patch8: virt-manager-addstorage-Don-t-pass-None-to-widget.set_active.patch Requires: virt-manager-common = %{verrel} @@ -194,6 +195,9 @@ done %changelog +* Thu Dec 9 2021 Jonathon Jongsma - 3.2.0-2 +- addstorage: Don't pass None to widget.set_active() (rhbz#2026987) + * Fri Nov 19 2021 Jonathon Jongsma - 3.2.0-1 - Rebased to virt-manager-3.2.0 (rhbz#2009080) - The rebase also fixes the following bugs: