|
 |
f3523c |
From 8676750b73bda178cfe0f278e76547711910f71d Mon Sep 17 00:00:00 2001
|
|
|
f3523c |
Message-Id: <8676750b73bda178cfe0f278e76547711910f71d@dist-git>
|
|
|
f3523c |
From: Pavel Hrdina <phrdina@redhat.com>
|
|
|
f3523c |
Date: Thu, 25 Jul 2019 14:09:53 +0200
|
|
|
f3523c |
Subject: [PATCH] virt-install: Use minutes instead of seconds on
|
|
|
f3523c |
get_time_string()
|
|
|
f3523c |
MIME-Version: 1.0
|
|
|
f3523c |
Content-Type: text/plain; charset=UTF-8
|
|
|
f3523c |
Content-Transfer-Encoding: 8bit
|
|
|
f3523c |
|
|
|
f3523c |
From: Fabiano Fidêncio <fidencio@redhat.com>
|
|
|
f3523c |
|
|
|
f3523c |
get_time_string() currently uses self._wait_secs, while it should use
|
|
|
f3523c |
self._wait_mins, resulting on confusing messages when using `--wait`
|
|
|
f3523c |
option, as shown below:
|
|
|
f3523c |
|
|
|
f3523c |
fidencio@laerte ~/src/upstream/virt-manager $ ./virt-install --install fedora30 --unattended --wait 20
|
|
|
f3523c |
...
|
|
|
f3523c |
Waiting 1200 minutes for installation to complete.
|
|
|
f3523c |
|
|
|
f3523c |
Reviewed-by: Cole Robinson <crobinso@redhat.com>
|
|
|
f3523c |
Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
|
|
|
f3523c |
(cherry picked from commit 414ffa5ef82548d502a4de98d40228a68bdb29c1)
|
|
|
f3523c |
|
|
|
f3523c |
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1777664
|
|
|
f3523c |
|
|
|
f3523c |
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
|
|
|
f3523c |
---
|
|
|
f3523c |
virt-install | 2 +-
|
|
|
f3523c |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
f3523c |
|
|
|
f3523c |
diff --git a/virt-install b/virt-install
|
|
|
f3523c |
index 009d03e1..022f947d 100755
|
|
|
f3523c |
--- a/virt-install
|
|
|
f3523c |
+++ b/virt-install
|
|
|
f3523c |
@@ -614,7 +614,7 @@ class WaitHandler:
|
|
|
f3523c |
self._start_time = time.time()
|
|
|
f3523c |
|
|
|
f3523c |
def get_time_string(self):
|
|
|
f3523c |
- timestr = _(" %d minutes") % self._wait_secs
|
|
|
f3523c |
+ timestr = _(" %d minutes") % self._wait_mins
|
|
|
f3523c |
if self._wait_forever:
|
|
|
f3523c |
timestr = ""
|
|
|
f3523c |
ret = _("Waiting%(time_string)s for installation to complete.") % {
|
|
|
f3523c |
--
|
|
|
f3523c |
2.26.2
|
|
|
f3523c |
|