|
 |
daf011 |
From 89766dae2418fb8fd9d54b7ce1d93a11d5faecdd Mon Sep 17 00:00:00 2001
|
|
|
daf011 |
From: Cole Robinson <crobinso@redhat.com>
|
|
|
daf011 |
Date: Wed, 7 Apr 2021 09:37:53 -0400
|
|
|
daf011 |
Subject: [PATCH] installer: Prefer xorrisofs over genisoimage/mkisofs
|
|
|
daf011 |
|
|
|
daf011 |
Apparently it's the most likely version to exist in distros these
|
|
|
daf011 |
days. Particularly the other options may not be shipped in stock
|
|
|
daf011 |
RHEL9
|
|
|
daf011 |
|
|
|
daf011 |
Signed-off-by: Cole Robinson <crobinso@redhat.com>
|
|
|
daf011 |
(cherry picked from commit 3785abc6f0cb07c02ecc55760547a6f425513915)
|
|
|
daf011 |
|
|
|
daf011 |
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1973236
|
|
|
daf011 |
|
|
|
daf011 |
Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
|
|
|
daf011 |
---
|
|
|
daf011 |
virtinst/install/installerinject.py | 10 ++++++----
|
|
|
daf011 |
1 file changed, 6 insertions(+), 4 deletions(-)
|
|
|
daf011 |
|
|
|
daf011 |
diff --git a/virtinst/install/installerinject.py b/virtinst/install/installerinject.py
|
|
|
daf011 |
index 29150c8e..97742f6a 100644
|
|
|
daf011 |
--- a/virtinst/install/installerinject.py
|
|
|
daf011 |
+++ b/virtinst/install/installerinject.py
|
|
|
daf011 |
@@ -45,10 +45,12 @@ def _run_initrd_commands(initrd, tempdir):
|
|
|
daf011 |
|
|
|
daf011 |
|
|
|
daf011 |
def _run_iso_commands(iso, tempdir, cloudinit=False):
|
|
|
daf011 |
- # Some distros do not link mkisofs to genisoimage (or vice-versa). As a
|
|
|
daf011 |
- # result of this, we have to actually check for both programs and use the
|
|
|
daf011 |
- # most appropriate one.
|
|
|
daf011 |
- programs = ["genisoimage", "mkisofs"]
|
|
|
daf011 |
+ # These three programs all behave similarly for our needs, and
|
|
|
daf011 |
+ # different distros only have some available. xorriso is apparently
|
|
|
daf011 |
+ # the actively maintained variant that should be available everywhere
|
|
|
daf011 |
+ # and without any license issues. Some more info here:
|
|
|
daf011 |
+ # https://wiki.debian.org/genisoimage
|
|
|
daf011 |
+ programs = ["xorrisofs", "genisoimage", "mkisofs"]
|
|
|
daf011 |
for program in programs:
|
|
|
daf011 |
if shutil.which(program):
|
|
|
daf011 |
break
|
|
|
daf011 |
--
|
|
|
daf011 |
2.31.1
|
|
|
daf011 |
|