|
 |
e2df08 |
From 9665fa59d97dcafead970dabc65ee88e3280470f Mon Sep 17 00:00:00 2001
|
|
|
e2df08 |
From: Cole Robinson <crobinso@redhat.com>
|
|
|
e2df08 |
Date: Fri, 12 Sep 2014 08:57:13 -0400
|
|
|
e2df08 |
Subject: [PATCH 2/4] domain: Remove the description/title hotplug hacks
|
|
|
e2df08 |
|
|
|
e2df08 |
We would unconditionally read VM description/hotplug from the inactive
|
|
|
e2df08 |
domain XML, this allowed us to emulate metadata hotplug where it wasn't
|
|
|
e2df08 |
implemented. However this means we end up doing many needless XMLDesc
|
|
|
e2df08 |
calls, which slows down connection startup for low latency connections.
|
|
|
e2df08 |
|
|
|
e2df08 |
Since SetMetadata has been in libvirt for 2 years now, drop this hack.
|
|
|
e2df08 |
|
|
|
e2df08 |
(cherry picked from commit f36d2ed9607b2530864ba331379f3167ea5ab86c)
|
|
|
e2df08 |
---
|
|
|
e2df08 |
virtManager/domain.py | 10 ++--------
|
|
|
e2df08 |
1 file changed, 2 insertions(+), 8 deletions(-)
|
|
|
e2df08 |
|
|
|
e2df08 |
diff --git a/virtManager/domain.py b/virtManager/domain.py
|
|
|
e2df08 |
index d22a143..4098e2d 100644
|
|
|
e2df08 |
--- a/virtManager/domain.py
|
|
|
e2df08 |
+++ b/virtManager/domain.py
|
|
|
e2df08 |
@@ -956,9 +956,6 @@ class vmmDomain(vmmLibvirtObject):
|
|
|
e2df08 |
self._backend.setMaxMemory(val)
|
|
|
e2df08 |
|
|
|
e2df08 |
def _hotplug_metadata(val, mtype):
|
|
|
e2df08 |
- if not self.conn.check_support(
|
|
|
e2df08 |
- self.conn.SUPPORT_DOMAIN_SET_METADATA, self._backend):
|
|
|
e2df08 |
- return
|
|
|
e2df08 |
flags = (libvirt.VIR_DOMAIN_AFFECT_LIVE |
|
|
|
e2df08 |
libvirt.VIR_DOMAIN_AFFECT_CONFIG)
|
|
|
e2df08 |
self._backend.setMetadata(mtype, val, None, None, flags)
|
|
|
e2df08 |
@@ -1093,12 +1090,9 @@ class vmmDomain(vmmLibvirtObject):
|
|
|
e2df08 |
return self.get_name()
|
|
|
e2df08 |
|
|
|
e2df08 |
def get_title(self):
|
|
|
e2df08 |
- return self.get_xmlobj(inactive=True).title
|
|
|
e2df08 |
-
|
|
|
e2df08 |
+ return self.get_xmlobj().title
|
|
|
e2df08 |
def get_description(self):
|
|
|
e2df08 |
- # Always show the inactive <description>, let's us fake hotplug
|
|
|
e2df08 |
- # for a field that's strictly metadata
|
|
|
e2df08 |
- return self.get_xmlobj(inactive=True).description
|
|
|
e2df08 |
+ return self.get_xmlobj().description
|
|
|
e2df08 |
|
|
|
e2df08 |
def get_memory(self):
|
|
|
e2df08 |
return int(self.get_xmlobj().memory)
|
|
|
e2df08 |
--
|
|
|
e2df08 |
1.9.3
|
|
|
e2df08 |
|