Blame SOURCES/vim-cve-var-retab.patch

da4393
diff --git a/src/indent.c b/src/indent.c
da4393
index e1c6f52..a002b4b 100644
da4393
--- a/src/indent.c
da4393
+++ b/src/indent.c
da4393
@@ -18,18 +18,19 @@
da4393
 /*
da4393
  * Set the integer values corresponding to the string setting of 'vartabstop'.
da4393
  * "array" will be set, caller must free it if needed.
da4393
+ * Return FAIL for an error.
da4393
  */
da4393
     int
da4393
 tabstop_set(char_u *var, int **array)
da4393
 {
da4393
-    int valcount = 1;
da4393
-    int t;
da4393
-    char_u *cp;
da4393
+    int	    valcount = 1;
da4393
+    int	    t;
da4393
+    char_u  *cp;
da4393
 
da4393
     if (var[0] == NUL || (var[0] == '0' && var[1] == NUL))
da4393
     {
da4393
 	*array = NULL;
da4393
-	return TRUE;
da4393
+	return OK;
da4393
     }
da4393
 
da4393
     for (cp = var; *cp != NUL; ++cp)
da4393
@@ -43,8 +44,8 @@ tabstop_set(char_u *var, int **array)
da4393
 		if (cp != end)
da4393
 		    emsg(_(e_positive));
da4393
 		else
da4393
-		    emsg(_(e_invarg));
da4393
-		return FALSE;
da4393
+		    semsg(_(e_invarg2), cp);
da4393
+		return FAIL;
da4393
 	    }
da4393
 	}
da4393
 
da4393
@@ -55,26 +56,36 @@ tabstop_set(char_u *var, int **array)
da4393
 	    ++valcount;
da4393
 	    continue;
da4393
 	}
da4393
-	emsg(_(e_invarg));
da4393
-	return FALSE;
da4393
+	semsg(_(e_invarg2), var);
da4393
+	return FAIL;
da4393
     }
da4393
 
da4393
     *array = ALLOC_MULT(int, valcount + 1);
da4393
     if (*array == NULL)
da4393
-	return FALSE;
da4393
+	return FAIL;
da4393
     (*array)[0] = valcount;
da4393
 
da4393
     t = 1;
da4393
     for (cp = var; *cp != NUL;)
da4393
     {
da4393
-	(*array)[t++] = atoi((char *)cp);
da4393
-	while (*cp  != NUL && *cp != ',')
da4393
+	int n = atoi((char *)cp);
da4393
+
da4393
+	// Catch negative values, overflow and ridiculous big values.
da4393
+	if (n < 0 || n > 9999)
da4393
+	{
da4393
+	    semsg(_(e_invarg2), cp);
da4393
+	    vim_free(*array);
da4393
+	    *array = NULL;
da4393
+	    return FAIL;
da4393
+	}
da4393
+	(*array)[t++] = n;
da4393
+	while (*cp != NUL && *cp != ',')
da4393
 	    ++cp;
da4393
 	if (*cp != NUL)
da4393
 	    ++cp;
da4393
     }
da4393
 
da4393
-    return TRUE;
da4393
+    return OK;
da4393
 }
da4393
 
da4393
 /*
da4393
@@ -1561,7 +1572,7 @@ ex_retab(exarg_T *eap)
da4393
 
da4393
 #ifdef FEAT_VARTABS
da4393
     new_ts_str = eap->arg;
da4393
-    if (!tabstop_set(eap->arg, &new_vts_array))
da4393
+    if (tabstop_set(eap->arg, &new_vts_array) == FAIL)
da4393
 	return;
da4393
     while (vim_isdigit(*(eap->arg)) || *(eap->arg) == ',')
da4393
 	++(eap->arg);
da4393
@@ -1577,12 +1588,18 @@ ex_retab(exarg_T *eap)
da4393
     else
da4393
 	new_ts_str = vim_strnsave(new_ts_str, eap->arg - new_ts_str);
da4393
 #else
da4393
-    new_ts = getdigits(&(eap->arg));
da4393
-    if (new_ts < 0)
da4393
+    ptr = eap->arg;
da4393
+    new_ts = getdigits(&ptr);
da4393
+    if (new_ts < 0 && *eap->arg == '-')
da4393
     {
da4393
 	emsg(_(e_positive));
da4393
 	return;
da4393
     }
da4393
+    if (new_ts < 0 || new_ts > 9999)
da4393
+    {
da4393
+	semsg(_(e_invarg2), eap->arg);
da4393
+	return;
da4393
+    }
da4393
     if (new_ts == 0)
da4393
 	new_ts = curbuf->b_p_ts;
da4393
 #endif
da4393
diff --git a/src/option.c b/src/option.c
da4393
index b9d7edb..9a3b71e 100644
da4393
--- a/src/option.c
da4393
+++ b/src/option.c
da4393
@@ -2349,9 +2349,9 @@ didset_options2(void)
da4393
 #endif
da4393
 #ifdef FEAT_VARTABS
da4393
     vim_free(curbuf->b_p_vsts_array);
da4393
-    tabstop_set(curbuf->b_p_vsts, &curbuf->b_p_vsts_array);
da4393
+    (void)tabstop_set(curbuf->b_p_vsts, &curbuf->b_p_vsts_array);
da4393
     vim_free(curbuf->b_p_vts_array);
da4393
-    tabstop_set(curbuf->b_p_vts,  &curbuf->b_p_vts_array);
da4393
+    (void)tabstop_set(curbuf->b_p_vts,  &curbuf->b_p_vts_array);
da4393
 #endif
da4393
 }
da4393
 
da4393
@@ -5828,7 +5828,7 @@ buf_copy_options(buf_T *buf, int flags)
da4393
 	    buf->b_p_vsts = vim_strsave(p_vsts);
da4393
 	    COPY_OPT_SCTX(buf, BV_VSTS);
da4393
 	    if (p_vsts && p_vsts != empty_option)
da4393
-		tabstop_set(p_vsts, &buf->b_p_vsts_array);
da4393
+		(void)tabstop_set(p_vsts, &buf->b_p_vsts_array);
da4393
 	    else
da4393
 		buf->b_p_vsts_array = 0;
da4393
 	    buf->b_p_vsts_nopaste = p_vsts_nopaste
da4393
@@ -5988,7 +5988,7 @@ buf_copy_options(buf_T *buf, int flags)
da4393
 		buf->b_p_isk = save_p_isk;
da4393
 #ifdef FEAT_VARTABS
da4393
 		if (p_vts && p_vts != empty_option && !buf->b_p_vts_array)
da4393
-		    tabstop_set(p_vts, &buf->b_p_vts_array);
da4393
+		    (void)tabstop_set(p_vts, &buf->b_p_vts_array);
da4393
 		else
da4393
 		    buf->b_p_vts_array = NULL;
da4393
 #endif
da4393
@@ -6003,7 +6003,7 @@ buf_copy_options(buf_T *buf, int flags)
da4393
 		buf->b_p_vts = vim_strsave(p_vts);
da4393
 		COPY_OPT_SCTX(buf, BV_VTS);
da4393
 		if (p_vts && p_vts != empty_option && !buf->b_p_vts_array)
da4393
-		    tabstop_set(p_vts, &buf->b_p_vts_array);
da4393
+		    (void)tabstop_set(p_vts, &buf->b_p_vts_array);
da4393
 		else
da4393
 		    buf->b_p_vts_array = NULL;
da4393
 #endif
da4393
@@ -6700,7 +6700,7 @@ paste_option_changed(void)
da4393
 	    if (buf->b_p_vsts_array)
da4393
 		vim_free(buf->b_p_vsts_array);
da4393
 	    if (buf->b_p_vsts && buf->b_p_vsts != empty_option)
da4393
-		tabstop_set(buf->b_p_vsts, &buf->b_p_vsts_array);
da4393
+		(void)tabstop_set(buf->b_p_vsts, &buf->b_p_vsts_array);
da4393
 	    else
da4393
 		buf->b_p_vsts_array = 0;
da4393
 #endif
da4393
diff --git a/src/optionstr.c b/src/optionstr.c
da4393
index 521242d..db015e8 100644
da4393
--- a/src/optionstr.c
da4393
+++ b/src/optionstr.c
da4393
@@ -2215,7 +2215,7 @@ ambw_end:
da4393
 	    if (errmsg == NULL)
da4393
 	    {
da4393
 		int *oldarray = curbuf->b_p_vsts_array;
da4393
-		if (tabstop_set(*varp, &(curbuf->b_p_vsts_array)))
da4393
+		if (tabstop_set(*varp, &(curbuf->b_p_vsts_array)) == OK)
da4393
 		{
da4393
 		    if (oldarray)
da4393
 			vim_free(oldarray);
da4393
@@ -2254,7 +2254,7 @@ ambw_end:
da4393
 	    {
da4393
 		int *oldarray = curbuf->b_p_vts_array;
da4393
 
da4393
-		if (tabstop_set(*varp, &(curbuf->b_p_vts_array)))
da4393
+		if (tabstop_set(*varp, &(curbuf->b_p_vts_array)) == OK)
da4393
 		{
da4393
 		    vim_free(oldarray);
da4393
 #ifdef FEAT_FOLDING
da4393
diff --git a/src/testdir/test_retab.vim b/src/testdir/test_retab.vim
da4393
index b792da5..c7190aa 100644
da4393
--- a/src/testdir/test_retab.vim
da4393
+++ b/src/testdir/test_retab.vim
da4393
@@ -75,6 +75,9 @@ endfunc
da4393
 func Test_retab_error()
da4393
   call assert_fails('retab -1',  'E487:')
da4393
   call assert_fails('retab! -1', 'E487:')
da4393
+  call assert_fails('ret -1000', 'E487:')
da4393
+  call assert_fails('ret 10000', 'E475:')
da4393
+  call assert_fails('ret 80000000000000000000', 'E475:')
da4393
 endfunc
da4393
 
da4393
 " vim: shiftwidth=2 sts=2 expandtab