073263
To: vim_dev@googlegroups.com
073263
Subject: Patch 7.4.486
073263
Fcc: outbox
073263
From: Bram Moolenaar <Bram@moolenaar.net>
073263
Mime-Version: 1.0
073263
Content-Type: text/plain; charset=UTF-8
073263
Content-Transfer-Encoding: 8bit
073263
------------
073263
073263
Patch 7.4.486
073263
Problem:    Check for writing to a yank register is wrong.
073263
Solution:   Negate the check. (Zyx).  Also clean up the #ifdefs.
073263
Files:	    src/ex_docmd.c, src/ex_cmds.h
073263
073263
073263
*** ../vim-7.4.485/src/ex_docmd.c	2014-09-19 20:07:22.546449677 +0200
073263
--- src/ex_docmd.c	2014-10-21 19:56:31.290287055 +0200
073263
***************
073263
*** 49,58 ****
073263
--- 49,63 ----
073263
  static char_u *get_user_command_name __ARGS((int idx));
073263
  # endif
073263
  
073263
+ /* Wether a command index indicates a user command. */
073263
+ # define IS_USER_CMDIDX(idx) ((int)(idx) < 0)
073263
+ 
073263
  #else
073263
  # define ex_command	ex_ni
073263
  # define ex_comclear	ex_ni
073263
  # define ex_delcommand	ex_ni
073263
+ /* Wether a command index indicates a user command. */
073263
+ # define IS_USER_CMDIDX(idx) (FALSE)
073263
  #endif
073263
  
073263
  #ifdef FEAT_EVAL
073263
***************
073263
*** 2190,2200 ****
073263
  	goto doend;
073263
      }
073263
  
073263
!     ni = (
073263
! #ifdef FEAT_USR_CMDS
073263
! 	    !USER_CMDIDX(ea.cmdidx) &&
073263
! #endif
073263
! 	    (cmdnames[ea.cmdidx].cmd_func == ex_ni
073263
  #ifdef HAVE_EX_SCRIPT_NI
073263
  	     || cmdnames[ea.cmdidx].cmd_func == ex_script_ni
073263
  #endif
073263
--- 2195,2202 ----
073263
  	goto doend;
073263
      }
073263
  
073263
!     ni = (!IS_USER_CMDIDX(ea.cmdidx)
073263
! 	    && (cmdnames[ea.cmdidx].cmd_func == ex_ni
073263
  #ifdef HAVE_EX_SCRIPT_NI
073263
  	     || cmdnames[ea.cmdidx].cmd_func == ex_script_ni
073263
  #endif
073263
***************
073263
*** 2229,2237 ****
073263
  /*
073263
   * 5. parse arguments
073263
   */
073263
! #ifdef FEAT_USR_CMDS
073263
!     if (!USER_CMDIDX(ea.cmdidx))
073263
! #endif
073263
  	ea.argt = (long)cmdnames[(int)ea.cmdidx].cmd_argt;
073263
  
073263
      if (!ea.skip)
073263
--- 2231,2237 ----
073263
  /*
073263
   * 5. parse arguments
073263
   */
073263
!     if (!IS_USER_CMDIDX(ea.cmdidx))
073263
  	ea.argt = (long)cmdnames[(int)ea.cmdidx].cmd_argt;
073263
  
073263
      if (!ea.skip)
073263
***************
073263
*** 2252,2261 ****
073263
  	}
073263
  
073263
  	if (text_locked() && !(ea.argt & CMDWIN)
073263
! # ifdef FEAT_USR_CMDS
073263
! 		&& !USER_CMDIDX(ea.cmdidx)
073263
! # endif
073263
! 	   )
073263
  	{
073263
  	    /* Command not allowed when editing the command line. */
073263
  #ifdef FEAT_CMDWIN
073263
--- 2252,2258 ----
073263
  	}
073263
  
073263
  	if (text_locked() && !(ea.argt & CMDWIN)
073263
! 		&& !IS_USER_CMDIDX(ea.cmdidx))
073263
  	{
073263
  	    /* Command not allowed when editing the command line. */
073263
  #ifdef FEAT_CMDWIN
073263
***************
073263
*** 2273,2281 ****
073263
  	if (!(ea.argt & CMDWIN)
073263
  		&& ea.cmdidx != CMD_edit
073263
  		&& ea.cmdidx != CMD_checktime
073263
! # ifdef FEAT_USR_CMDS
073263
! 		&& !USER_CMDIDX(ea.cmdidx)
073263
! # endif
073263
  		&& curbuf_locked())
073263
  	    goto doend;
073263
  #endif
073263
--- 2270,2276 ----
073263
  	if (!(ea.argt & CMDWIN)
073263
  		&& ea.cmdidx != CMD_edit
073263
  		&& ea.cmdidx != CMD_checktime
073263
! 		&& !IS_USER_CMDIDX(ea.cmdidx)
073263
  		&& curbuf_locked())
073263
  	    goto doend;
073263
  #endif
073263
***************
073263
*** 2468,2477 ****
073263
      /* accept numbered register only when no count allowed (:put) */
073263
      if (       (ea.argt & REGSTR)
073263
  	    && *ea.arg != NUL
073263
! #ifdef FEAT_USR_CMDS
073263
! 	    /* Do not allow register = for user commands */
073263
! 	    && (!USER_CMDIDX(ea.cmdidx) || *ea.arg != '=')
073263
! #endif
073263
  	    && !((ea.argt & COUNT) && VIM_ISDIGIT(*ea.arg)))
073263
      {
073263
  #ifndef FEAT_CLIPBOARD
073263
--- 2463,2470 ----
073263
      /* accept numbered register only when no count allowed (:put) */
073263
      if (       (ea.argt & REGSTR)
073263
  	    && *ea.arg != NUL
073263
! 	       /* Do not allow register = for user commands */
073263
! 	    && (!IS_USER_CMDIDX(ea.cmdidx) || *ea.arg != '=')
073263
  	    && !((ea.argt & COUNT) && VIM_ISDIGIT(*ea.arg)))
073263
      {
073263
  #ifndef FEAT_CLIPBOARD
073263
***************
073263
*** 2482,2495 ****
073263
  	    goto doend;
073263
  	}
073263
  #endif
073263
! 	if (
073263
! #ifdef FEAT_USR_CMDS
073263
! 	    valid_yank_reg(*ea.arg, (ea.cmdidx != CMD_put
073263
! 						   && USER_CMDIDX(ea.cmdidx)))
073263
! #else
073263
! 	    valid_yank_reg(*ea.arg, ea.cmdidx != CMD_put)
073263
! #endif
073263
! 	   )
073263
  	{
073263
  	    ea.regname = *ea.arg++;
073263
  #ifdef FEAT_EVAL
073263
--- 2475,2482 ----
073263
  	    goto doend;
073263
  	}
073263
  #endif
073263
! 	if (valid_yank_reg(*ea.arg, (ea.cmdidx != CMD_put
073263
! 					      && !IS_USER_CMDIDX(ea.cmdidx))))
073263
  	{
073263
  	    ea.regname = *ea.arg++;
073263
  #ifdef FEAT_EVAL
073263
***************
073263
*** 2663,2672 ****
073263
       * number.  Don't do this for a user command.
073263
       */
073263
      if ((ea.argt & BUFNAME) && *ea.arg != NUL && ea.addr_count == 0
073263
! # ifdef FEAT_USR_CMDS
073263
! 	    && !USER_CMDIDX(ea.cmdidx)
073263
! # endif
073263
! 	    )
073263
      {
073263
  	/*
073263
  	 * :bdelete, :bwipeout and :bunload take several arguments, separated
073263
--- 2650,2656 ----
073263
       * number.  Don't do this for a user command.
073263
       */
073263
      if ((ea.argt & BUFNAME) && *ea.arg != NUL && ea.addr_count == 0
073263
! 	    && !IS_USER_CMDIDX(ea.cmdidx))
073263
      {
073263
  	/*
073263
  	 * :bdelete, :bwipeout and :bunload take several arguments, separated
073263
***************
073263
*** 2704,2710 ****
073263
  #endif
073263
  
073263
  #ifdef FEAT_USR_CMDS
073263
!     if (USER_CMDIDX(ea.cmdidx))
073263
      {
073263
  	/*
073263
  	 * Execute a user-defined command.
073263
--- 2688,2694 ----
073263
  #endif
073263
  
073263
  #ifdef FEAT_USR_CMDS
073263
!     if (IS_USER_CMDIDX(ea.cmdidx))
073263
      {
073263
  	/*
073263
  	 * Execute a user-defined command.
073263
***************
073263
*** 2763,2773 ****
073263
      }
073263
  #ifdef FEAT_EVAL
073263
      do_errthrow(cstack,
073263
! 	    (ea.cmdidx != CMD_SIZE
073263
! # ifdef FEAT_USR_CMDS
073263
! 	     && !USER_CMDIDX(ea.cmdidx)
073263
! # endif
073263
! 	    ) ? cmdnames[(int)ea.cmdidx].cmd_name : (char_u *)NULL);
073263
  #endif
073263
  
073263
      if (verbose_save >= 0)
073263
--- 2747,2754 ----
073263
      }
073263
  #ifdef FEAT_EVAL
073263
      do_errthrow(cstack,
073263
! 	    (ea.cmdidx != CMD_SIZE && !IS_USER_CMDIDX(ea.cmdidx))
073263
! 			? cmdnames[(int)ea.cmdidx].cmd_name : (char_u *)NULL);
073263
  #endif
073263
  
073263
      if (verbose_save >= 0)
073263
***************
073263
*** 3361,3369 ****
073263
  /*
073263
   * 5. parse arguments
073263
   */
073263
! #ifdef FEAT_USR_CMDS
073263
!     if (!USER_CMDIDX(ea.cmdidx))
073263
! #endif
073263
  	ea.argt = (long)cmdnames[(int)ea.cmdidx].cmd_argt;
073263
  
073263
      arg = skipwhite(p);
073263
--- 3342,3348 ----
073263
  /*
073263
   * 5. parse arguments
073263
   */
073263
!     if (!IS_USER_CMDIDX(ea.cmdidx))
073263
  	ea.argt = (long)cmdnames[(int)ea.cmdidx].cmd_argt;
073263
  
073263
      arg = skipwhite(p);
073263
*** ../vim-7.4.485/src/ex_cmds.h	2014-09-19 20:07:22.546449677 +0200
073263
--- src/ex_cmds.h	2014-10-21 19:52:45.926286562 +0200
073263
***************
073263
*** 1153,1160 ****
073263
  #endif
073263
  };
073263
  
073263
- #define USER_CMDIDX(idx) ((int)(idx) < 0)
073263
- 
073263
  #ifndef DO_DECLARE_EXCMD
073263
  typedef enum CMD_index cmdidx_T;
073263
  
073263
--- 1153,1158 ----
073263
*** ../vim-7.4.485/src/version.c	2014-10-21 19:35:28.406284296 +0200
073263
--- src/version.c	2014-10-21 20:00:44.350287607 +0200
073263
***************
073263
*** 743,744 ****
073263
--- 743,746 ----
073263
  {   /* Add new patch number below this line */
073263
+ /**/
073263
+     486,
073263
  /**/
073263
073263
-- 
073263
FATHER: One day, lad, all this will be yours ...
073263
PRINCE: What - the curtains?
073263
                 "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
073263
073263
 /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net   \\\
073263
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
073263
\\\  an exciting new programming language -- http://www.Zimbu.org        ///
073263
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///