Blame SOURCES/0001-patch-8.2.4245-retab-0-may-cause-illegal-memory-acce.patch

da4393
diff -up vim82/src/indent.c.cve0417 vim82/src/indent.c
da4393
--- vim82/src/indent.c.cve0417	2022-02-09 10:01:34.250009316 +0100
da4393
+++ vim82/src/indent.c	2022-02-09 10:02:54.802588536 +0100
da4393
@@ -71,7 +71,7 @@ tabstop_set(char_u *var, int **array)
da4393
 	int n = atoi((char *)cp);
da4393
 
da4393
 	// Catch negative values, overflow and ridiculous big values.
da4393
-	if (n < 0 || n > 9999)
da4393
+	if (n < 0 || n > TABSTOP_MAX)
da4393
 	{
da4393
 	    semsg(_(e_invarg2), cp);
da4393
 	    vim_free(*array);
da4393
@@ -1595,7 +1595,7 @@ ex_retab(exarg_T *eap)
da4393
 	emsg(_(e_positive));
da4393
 	return;
da4393
     }
da4393
-    if (new_ts < 0 || new_ts > 9999)
da4393
+    if (new_ts < 0 || new_ts > TABSTOP_MAX)
da4393
     {
da4393
 	semsg(_(e_invarg2), eap->arg);
da4393
 	return;
da4393
diff -up vim82/src/option.c.cve0417 vim82/src/option.c
da4393
--- vim82/src/option.c.cve0417	2022-02-09 10:01:34.196009598 +0100
da4393
+++ vim82/src/option.c	2022-02-09 10:28:10.398548161 +0100
da4393
@@ -3640,6 +3640,11 @@ set_num_option(
da4393
 	errmsg = e_positive;
da4393
 	curbuf->b_p_ts = 8;
da4393
     }
da4393
+    else if (curbuf->b_p_ts > TABSTOP_MAX)
da4393
+    {
da4393
+	errmsg = e_invarg;
da4393
+	curbuf->b_p_ts = 8;
da4393
+    }
da4393
     if (p_tm < 0)
da4393
     {
da4393
 	errmsg = e_positive;
da4393
@@ -5830,7 +5835,7 @@ buf_copy_options(buf_T *buf, int flags)
da4393
 	    if (p_vsts && p_vsts != empty_option)
da4393
 		(void)tabstop_set(p_vsts, &buf->b_p_vsts_array);
da4393
 	    else
da4393
-		buf->b_p_vsts_array = 0;
da4393
+		buf->b_p_vsts_array = NULL;
da4393
 	    buf->b_p_vsts_nopaste = p_vsts_nopaste
da4393
 				 ? vim_strsave(p_vsts_nopaste) : NULL;
da4393
 #endif
da4393
@@ -6649,9 +6654,7 @@ paste_option_changed(void)
da4393
 	    if (buf->b_p_vsts)
da4393
 		free_string_option(buf->b_p_vsts);
da4393
 	    buf->b_p_vsts = empty_option;
da4393
-	    if (buf->b_p_vsts_array)
da4393
-		vim_free(buf->b_p_vsts_array);
da4393
-	    buf->b_p_vsts_array = 0;
da4393
+	    VIM_CLEAR(buf->b_p_vsts_array);
da4393
 #endif
da4393
 	}
da4393
 
da4393
@@ -6697,12 +6700,11 @@ paste_option_changed(void)
da4393
 		free_string_option(buf->b_p_vsts);
da4393
 	    buf->b_p_vsts = buf->b_p_vsts_nopaste
da4393
 			 ? vim_strsave(buf->b_p_vsts_nopaste) : empty_option;
da4393
-	    if (buf->b_p_vsts_array)
da4393
-		vim_free(buf->b_p_vsts_array);
da4393
+	    vim_free(buf->b_p_vsts_array);
da4393
 	    if (buf->b_p_vsts && buf->b_p_vsts != empty_option)
da4393
 		(void)tabstop_set(buf->b_p_vsts, &buf->b_p_vsts_array);
da4393
 	    else
da4393
-		buf->b_p_vsts_array = 0;
da4393
+		buf->b_p_vsts_array = NULL;
da4393
 #endif
da4393
 	}
da4393
 
da4393
diff -up vim82/src/testdir/test_options.vim.cve0417 vim82/src/testdir/test_options.vim
da4393
--- vim82/src/testdir/test_options.vim.cve0417	2021-03-22 10:02:42.000000000 +0100
da4393
+++ vim82/src/testdir/test_options.vim	2022-02-09 10:01:34.251009311 +0100
da4393
@@ -362,6 +362,8 @@ func Test_set_errors()
da4393
   call assert_fails('set shiftwidth=-1', 'E487:')
da4393
   call assert_fails('set sidescroll=-1', 'E487:')
da4393
   call assert_fails('set tabstop=-1', 'E487:')
da4393
+  call assert_fails('set tabstop=10000', 'E474:')
da4393
+  call assert_fails('set tabstop=5500000000', 'E474:')
da4393
   call assert_fails('set textwidth=-1', 'E487:')
da4393
   call assert_fails('set timeoutlen=-1', 'E487:')
da4393
   call assert_fails('set updatecount=-1', 'E487:')
da4393
diff -up vim82/src/vim.h.cve0417 vim82/src/vim.h
da4393
--- vim82/src/vim.h.cve0417	2021-03-22 10:02:42.000000000 +0100
da4393
+++ vim82/src/vim.h	2022-02-09 10:01:34.252009306 +0100
da4393
@@ -2032,6 +2032,8 @@ typedef int sock_T;
da4393
 
da4393
 #define DICT_MAXNEST 100	// maximum nesting of lists and dicts
da4393
 
da4393
+#define TABSTOP_MAX 9999
da4393
+
da4393
 #ifdef FEAT_CLIPBOARD
da4393
 
da4393
 // VIM_ATOM_NAME is the older Vim-specific selection type for X11.  Still