|
 |
da4393 |
From 8d02ce1ed75d008c34a5c9aaa51b67cbb9d33baa Mon Sep 17 00:00:00 2001
|
|
|
da4393 |
From: Bram Moolenaar <Bram@vim.org>
|
|
|
da4393 |
Date: Tue, 25 Jan 2022 18:24:00 +0000
|
|
|
da4393 |
Subject: [PATCH] patch 8.2.4217: illegal memory access when undo makes Visual
|
|
|
da4393 |
area invalid
|
|
|
da4393 |
|
|
|
da4393 |
Problem: Illegal memory access when undo makes Visual area invalid.
|
|
|
da4393 |
Solution: Correct the Visual area after undo.
|
|
|
da4393 |
---
|
|
|
da4393 |
src/testdir/test_visual.vim | 15 +++++++++++++++
|
|
|
da4393 |
src/undo.c | 2 ++
|
|
|
da4393 |
src/version.c | 2 ++
|
|
|
da4393 |
3 files changed, 19 insertions(+)
|
|
|
da4393 |
|
|
|
da4393 |
diff --git a/src/testdir/test_visual.vim b/src/testdir/test_visual.vim
|
|
|
da4393 |
index 9b322fd21..b2beda08d 100644
|
|
|
da4393 |
--- a/src/testdir/test_visual.vim
|
|
|
da4393 |
+++ b/src/testdir/test_visual.vim
|
|
|
da4393 |
@@ -1339,5 +1339,20 @@ func Test_visual_ex_copy_line()
|
|
|
da4393 |
bwipe!
|
|
|
da4393 |
endfunc
|
|
|
da4393 |
|
|
|
da4393 |
+" This was leaving the end of the Visual area beyond the end of a line.
|
|
|
da4393 |
+" Set 'undolevels' to start a new undo block.
|
|
|
da4393 |
+func Test_visual_undo_deletes_last_line()
|
|
|
da4393 |
+ new
|
|
|
da4393 |
+ call setline(1, ["aaa", "ccc", "dyd"])
|
|
|
da4393 |
+ set undolevels=100
|
|
|
da4393 |
+ exe "normal obbbbbbbbbxbb\<Esc>"
|
|
|
da4393 |
+ set undolevels=100
|
|
|
da4393 |
+ /y
|
|
|
da4393 |
+ exe "normal ggvjfxO"
|
|
|
da4393 |
+ undo
|
|
|
da4393 |
+ normal gNU
|
|
|
da4393 |
+ bwipe!
|
|
|
da4393 |
+endfunc
|
|
|
da4393 |
+
|
|
|
da4393 |
|
|
|
da4393 |
" vim: shiftwidth=2 sts=2 expandtab
|
|
|
da4393 |
diff --git a/src/undo.c b/src/undo.c
|
|
|
da4393 |
index 4d186d453..636144aef 100644
|
|
|
da4393 |
--- a/src/undo.c
|
|
|
da4393 |
+++ b/src/undo.c
|
|
|
da4393 |
@@ -3029,6 +3029,8 @@ u_undo_end(
|
|
|
da4393 |
}
|
|
|
da4393 |
}
|
|
|
da4393 |
#endif
|
|
|
da4393 |
+ if (VIsual_active)
|
|
|
da4393 |
+ check_pos(curbuf, &VIsual);
|
|
|
da4393 |
|
|
|
da4393 |
smsg_attr_keep(0, _("%ld %s; %s #%ld %s"),
|
|
|
da4393 |
u_oldcount < 0 ? -u_oldcount : u_oldcount,
|
|
|
da4393 |
--
|
|
|
da4393 |
2.34.1
|
|
|
da4393 |
|