Blame SOURCES/0001-patch-8.2.3290-Vim9-compiling-dict-may-use-pointer-a.patch

da4393
diff --git a/src/vim9compile.c b/src/vim9compile.c
da4393
index 535de05..ae7b253 100644
da4393
--- a/src/vim9compile.c
da4393
+++ b/src/vim9compile.c
da4393
@@ -1073,21 +1073,26 @@ generate_PUSHF(cctx_T *cctx, float_T fnumber)
da4393
 
da4393
 /*
da4393
  * Generate an ISN_PUSHS instruction.
da4393
- * Consumes "str".
da4393
+ * Consumes "*str".  When freed *str is set to NULL, unless "str" is NULL.
da4393
  */
da4393
     static int
da4393
-generate_PUSHS(cctx_T *cctx, char_u *str)
da4393
+generate_PUSHS(cctx_T *cctx, char_u **str)
da4393
 {
da4393
     isn_T	*isn;
da4393
 
da4393
     if (cctx->ctx_skip == SKIP_YES)
da4393
     {
da4393
-	vim_free(str);
da4393
+	if (str != NULL)
da4393
+	    VIM_CLEAR(*str);
da4393
 	return OK;
da4393
     }
da4393
     if ((isn = generate_instr_type(cctx, ISN_PUSHS, &t_string)) == NULL)
da4393
+    {
da4393
+	if (str != NULL)
da4393
+	    VIM_CLEAR(*str);
da4393
 	return FAIL;
da4393
-    isn->isn_arg.string = str;
da4393
+    }
da4393
+    isn->isn_arg.string = str == NULL ? NULL : *str;
da4393
 
da4393
     return OK;
da4393
 }
da4393
@@ -2547,7 +2552,7 @@ generate_tv_PUSH(cctx_T *cctx, typval_T *tv)
da4393
 		tv->vval.v_blob = NULL;
da4393
 		break;
da4393
 	    case VAR_STRING:
da4393
-		generate_PUSHS(cctx, tv->vval.v_string);
da4393
+		generate_PUSHS(cctx, &tv->vval.v_string);
da4393
 		tv->vval.v_string = NULL;
da4393
 		break;
da4393
 	    default:
da4393
@@ -3301,7 +3306,7 @@ compile_dict(char_u **arg, cctx_T *cctx, ppconst_T *ppconst)
da4393
 	    key = get_literal_key(arg);
da4393
 	    if (key == NULL)
da4393
 		return FAIL;
da4393
-	    if (generate_PUSHS(cctx, key) == FAIL)
da4393
+	    if (generate_PUSHS(cctx, &key) == FAIL)
da4393
 		return FAIL;
da4393
 	}
da4393
 
da4393
@@ -5978,7 +5983,7 @@ compile_assign_unlet(
da4393
 	char_u *key_end = to_name_end(p + 1, TRUE);
da4393
 	char_u *key = vim_strnsave(p + 1, key_end - p - 1);
da4393
 
da4393
-	r = generate_PUSHS(cctx, key);
da4393
+	r = generate_PUSHS(cctx, &key);
da4393
     }
da4393
     if (r == FAIL)
da4393
 	return FAIL;
da4393
@@ -6149,7 +6154,7 @@ compile_assignment(char_u *arg, exarg_T *eap, cmdidx_T cmdidx, cctx_T *cctx)
da4393
 	    // Push each line and the create the list.
da4393
 	    FOR_ALL_LIST_ITEMS(l, li)
da4393
 	    {
da4393
-		generate_PUSHS(cctx, li->li_tv.vval.v_string);
da4393
+		generate_PUSHS(cctx, &li->li_tv.vval.v_string);
da4393
 		li->li_tv.vval.v_string = NULL;
da4393
 	    }
da4393
 	    generate_NEWLIST(cctx, l->lv_len);
da4393
@@ -7709,7 +7714,7 @@ compile_catch(char_u *arg, cctx_T *cctx UNUSED)
da4393
 	p += len + 2 + dropped;
da4393
 	if (pat == NULL)
da4393
 	    return FAIL;
da4393
-	if (generate_PUSHS(cctx, pat) == FAIL)
da4393
+	if (generate_PUSHS(cctx, &pat) == FAIL)
da4393
 	    return FAIL;
da4393
 
da4393
 	if (generate_COMPARE(cctx, EXPR_MATCH, FALSE) == FAIL)
da4393
@@ -8080,7 +8085,9 @@ compile_exec(char_u *line, exarg_T *eap, cctx_T *cctx)
da4393
 	{
da4393
 	    if (p > start)
da4393
 	    {
da4393
-		generate_PUSHS(cctx, vim_strnsave(start, p - start));
da4393
+		char_u *val = vim_strnsave(start, p - start);
da4393
+
da4393
+		generate_PUSHS(cctx, &val;;
da4393
 		++count;
da4393
 	    }
da4393
 	    p += 2;
da4393
@@ -8101,7 +8108,9 @@ compile_exec(char_u *line, exarg_T *eap, cctx_T *cctx)
da4393
 	    {
da4393
 		if (*skipwhite(start) != NUL)
da4393
 		{
da4393
-		    generate_PUSHS(cctx, vim_strsave(start));
da4393
+		    char_u *val = vim_strsave(start);
da4393
+
da4393
+		    generate_PUSHS(cctx, &val;;
da4393
 		    ++count;
da4393
 		}
da4393
 		break;