Karsten Hopp 563e59
To: vim-dev@vim.org
Karsten Hopp 563e59
Subject: Patch 7.2.089 (extra)
Karsten Hopp 563e59
Fcc: outbox
Karsten Hopp 563e59
From: Bram Moolenaar <Bram@moolenaar.net>
Karsten Hopp 563e59
Mime-Version: 1.0
Karsten Hopp 563e59
Content-Type: text/plain; charset=ISO-8859-1
Karsten Hopp 563e59
Content-Transfer-Encoding: 8bit
Karsten Hopp 563e59
------------
Karsten Hopp 563e59
Karsten Hopp 563e59
Patch 7.2.089 (extra)
Karsten Hopp 563e59
Problem:    Win32: crash when using Ultramon buttons.
Karsten Hopp 563e59
Solution:   Don't use a WM_OLE message of zero size. (Ray Megal)
Karsten Hopp 563e59
Files:	    src/if_ole.cpp, src/gui_w48.c
Karsten Hopp 563e59
Karsten Hopp 563e59
Karsten Hopp 563e59
*** ../vim-7.2.088/src/if_ole.cpp	Sun Mar 16 14:53:11 2008
Karsten Hopp 563e59
--- src/if_ole.cpp	Mon Jan 19 21:16:33 2009
Karsten Hopp 563e59
***************
Karsten Hopp 563e59
*** 353,361 ****
Karsten Hopp 563e59
      }
Karsten Hopp 563e59
  
Karsten Hopp 563e59
      /* Pass the string to the main input loop. The memory will be freed when
Karsten Hopp 563e59
!      * the message is processed.
Karsten Hopp 563e59
       */
Karsten Hopp 563e59
!     PostMessage(NULL, WM_OLE, 0, (LPARAM)str);
Karsten Hopp 563e59
  
Karsten Hopp 563e59
      return S_OK;
Karsten Hopp 563e59
  }
Karsten Hopp 563e59
--- 353,365 ----
Karsten Hopp 563e59
      }
Karsten Hopp 563e59
  
Karsten Hopp 563e59
      /* Pass the string to the main input loop. The memory will be freed when
Karsten Hopp 563e59
!      * the message is processed.  Except for an empty message, we don't need
Karsten Hopp 563e59
!      * to post it then.
Karsten Hopp 563e59
       */
Karsten Hopp 563e59
!     if (*str == NUL)
Karsten Hopp 563e59
! 	vim_free(str);
Karsten Hopp 563e59
!     else
Karsten Hopp 563e59
! 	PostMessage(NULL, WM_OLE, 0, (LPARAM)str);
Karsten Hopp 563e59
  
Karsten Hopp 563e59
      return S_OK;
Karsten Hopp 563e59
  }
Karsten Hopp 563e59
*** ../vim-7.2.088/src/gui_w48.c	Wed Dec 24 12:20:10 2008
Karsten Hopp 563e59
--- src/gui_w48.c	Mon Jan 19 21:19:30 2009
Karsten Hopp 563e59
***************
Karsten Hopp 563e59
*** 1663,1670 ****
Karsten Hopp 563e59
      if (msg.message == WM_OLE)
Karsten Hopp 563e59
      {
Karsten Hopp 563e59
  	char_u *str = (char_u *)msg.lParam;
Karsten Hopp 563e59
! 	add_to_input_buf(str, (int)STRLEN(str));
Karsten Hopp 563e59
! 	vim_free(str);
Karsten Hopp 563e59
  	return;
Karsten Hopp 563e59
      }
Karsten Hopp 563e59
  #endif
Karsten Hopp 563e59
--- 1663,1679 ----
Karsten Hopp 563e59
      if (msg.message == WM_OLE)
Karsten Hopp 563e59
      {
Karsten Hopp 563e59
  	char_u *str = (char_u *)msg.lParam;
Karsten Hopp 563e59
! 	if (str == NULL || *str == NUL)
Karsten Hopp 563e59
! 	{
Karsten Hopp 563e59
! 	    /* Message can't be ours, forward it.  Fixes problem with Ultramon
Karsten Hopp 563e59
! 	     * 3.0.4 */
Karsten Hopp 563e59
! 	    DispatchMessage(&msg;;
Karsten Hopp 563e59
! 	}
Karsten Hopp 563e59
! 	else
Karsten Hopp 563e59
! 	{
Karsten Hopp 563e59
! 	    add_to_input_buf(str, (int)STRLEN(str));
Karsten Hopp 563e59
! 	    vim_free(str);  /* was allocated in CVim::SendKeys() */
Karsten Hopp 563e59
! 	}
Karsten Hopp 563e59
  	return;
Karsten Hopp 563e59
      }
Karsten Hopp 563e59
  #endif
Karsten Hopp 563e59
*** ../vim-7.2.088/src/version.c	Thu Jan 22 21:49:21 2009
Karsten Hopp 563e59
--- src/version.c	Wed Jan 28 14:16:01 2009
Karsten Hopp 563e59
***************
Karsten Hopp 563e59
*** 678,679 ****
Karsten Hopp 563e59
--- 678,681 ----
Karsten Hopp 563e59
  {   /* Add new patch number below this line */
Karsten Hopp 563e59
+ /**/
Karsten Hopp 563e59
+     89,
Karsten Hopp 563e59
  /**/
Karsten Hopp 563e59
Karsten Hopp 563e59
Karsten Hopp 563e59
-- 
Karsten Hopp 563e59
How To Keep A Healthy Level Of Insanity:
Karsten Hopp 563e59
16. Have your coworkers address you by your wrestling name, Rock Hard Kim.
Karsten Hopp 563e59
Karsten Hopp 563e59
 /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net   \\\
Karsten Hopp 563e59
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
Karsten Hopp 563e59
\\\        download, build and distribute -- http://www.A-A-P.org        ///
Karsten Hopp 563e59
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///