2be083
commit a53adb79711ccfc76a4ee32b20253045cdab55c7
2be083
Author: Mark Wielaard <mark@klomp.org>
2be083
Date:   Mon Jul 27 16:36:17 2020 +0200
2be083
2be083
    Handle linux syscalls sched_getattr and sched_setattr
2be083
    
2be083
    The only "special" thing about these syscalls is that the given
2be083
    struct sched_attr determines its own size for future expansion.
2be083
    
2be083
    Original fix by "ISHIKAWA,chiaki" <ishikawa@yk.rim.or.jp>
2be083
    
2be083
    https://bugs.kde.org/show_bug.cgi?id=369029
2be083
2be083
diff --git a/coregrind/m_syswrap/priv_syswrap-linux.h b/coregrind/m_syswrap/priv_syswrap-linux.h
2be083
index cdc73c1e6..eb0b320ca 100644
2be083
--- a/coregrind/m_syswrap/priv_syswrap-linux.h
2be083
+++ b/coregrind/m_syswrap/priv_syswrap-linux.h
2be083
@@ -227,6 +227,8 @@ DECL_TEMPLATE(linux, sys_fremovexattr);
2be083
 // syscalls.
2be083
 DECL_TEMPLATE(linux, sys_sched_setparam);
2be083
 DECL_TEMPLATE(linux, sys_sched_getparam);
2be083
+DECL_TEMPLATE(linux, sys_sched_setattr);
2be083
+DECL_TEMPLATE(linux, sys_sched_getattr);
2be083
 DECL_TEMPLATE(linux, sys_sched_setscheduler);
2be083
 DECL_TEMPLATE(linux, sys_sched_getscheduler);
2be083
 DECL_TEMPLATE(linux, sys_sched_yield);
2be083
diff --git a/coregrind/m_syswrap/syswrap-amd64-linux.c b/coregrind/m_syswrap/syswrap-amd64-linux.c
2be083
index 28d90135a..d6f3eb910 100644
2be083
--- a/coregrind/m_syswrap/syswrap-amd64-linux.c
2be083
+++ b/coregrind/m_syswrap/syswrap-amd64-linux.c
2be083
@@ -846,9 +846,8 @@ static SyscallTableEntry syscall_table[] = {
2be083
    LINX_(__NR_process_vm_writev, sys_process_vm_writev),// 311
2be083
    LINX_(__NR_kcmp,              sys_kcmp),             // 312
2be083
    LINX_(__NR_finit_module,      sys_finit_module),     // 313
2be083
-//   LIN__(__NR_sched_setattr,     sys_ni_syscall),       // 314
2be083
-
2be083
-//   LIN__(__NR_sched_getattr,     sys_ni_syscall),       // 315
2be083
+   LINX_(__NR_sched_setattr,     sys_sched_setattr),    // 314
2be083
+   LINXY(__NR_sched_getattr,     sys_sched_getattr),    // 315
2be083
    LINX_(__NR_renameat2,         sys_renameat2),        // 316
2be083
 //   LIN__(__NR_seccomp,           sys_ni_syscall),       // 317
2be083
    LINXY(__NR_getrandom,         sys_getrandom),        // 318
2be083
diff --git a/coregrind/m_syswrap/syswrap-arm-linux.c b/coregrind/m_syswrap/syswrap-arm-linux.c
2be083
index 579542785..70700e53f 100644
2be083
--- a/coregrind/m_syswrap/syswrap-arm-linux.c
2be083
+++ b/coregrind/m_syswrap/syswrap-arm-linux.c
2be083
@@ -1009,6 +1009,8 @@ static SyscallTableEntry syscall_main_table[] = {
2be083
    LINXY(__NR_process_vm_readv,  sys_process_vm_readv), // 376
2be083
    LINX_(__NR_process_vm_writev, sys_process_vm_writev),// 377
2be083
 
2be083
+   LINX_(__NR_sched_setattr,     sys_sched_setattr),    // 380
2be083
+   LINXY(__NR_sched_getattr,     sys_sched_getattr),    // 381
2be083
    LINX_(__NR_renameat2,         sys_renameat2),        // 382
2be083
 
2be083
    LINXY(__NR_getrandom,         sys_getrandom),        // 384
2be083
diff --git a/coregrind/m_syswrap/syswrap-arm64-linux.c b/coregrind/m_syswrap/syswrap-arm64-linux.c
2be083
index 81e01456f..acca02442 100644
2be083
--- a/coregrind/m_syswrap/syswrap-arm64-linux.c
2be083
+++ b/coregrind/m_syswrap/syswrap-arm64-linux.c
2be083
@@ -806,8 +806,8 @@ static SyscallTableEntry syscall_main_table[] = {
2be083
    LINX_(__NR_process_vm_writev, sys_process_vm_writev), // 271
2be083
    LINX_(__NR_kcmp,              sys_kcmp),              // 272
2be083
    LINX_(__NR_finit_module,      sys_finit_module),      // 273
2be083
-   //   (__NR_sched_setattr,     sys_ni_syscall),        // 274
2be083
-   //   (__NR_sched_getattr,     sys_ni_syscall),        // 275
2be083
+   LINX_(__NR_sched_setattr,     sys_sched_setattr),     // 274
2be083
+   LINXY(__NR_sched_getattr,     sys_sched_getattr),     // 275
2be083
    LINX_(__NR_renameat2,         sys_renameat2),         // 276
2be083
    //   (__NR_seccomp,           sys_ni_syscall),        // 277
2be083
    LINXY(__NR_getrandom,         sys_getrandom),         // 278
2be083
diff --git a/coregrind/m_syswrap/syswrap-linux.c b/coregrind/m_syswrap/syswrap-linux.c
2be083
index 5b5b7eee6..56be3032d 100644
2be083
--- a/coregrind/m_syswrap/syswrap-linux.c
2be083
+++ b/coregrind/m_syswrap/syswrap-linux.c
2be083
@@ -3677,6 +3677,41 @@ POST(sys_sched_getparam)
2be083
    POST_MEM_WRITE( ARG2, sizeof(struct vki_sched_param) );
2be083
 }
2be083
 
2be083
+PRE(sys_sched_setattr)
2be083
+{
2be083
+   struct vki_sched_attr *attr;
2be083
+   PRINT("sched_setattr ( %ld, %#" FMT_REGWORD "x, %#"
2be083
+         FMT_REGWORD "x )", SARG1, ARG2, ARG3 );
2be083
+   PRE_REG_READ3(long, "sched_setattr",
2be083
+                 vki_pid_t, pid, struct sched_attr *, p, unsigned int, flags);
2be083
+   /* We need to be able to read at least the size field.  */
2be083
+   PRE_MEM_READ( "sched_setattr(attr->size)", ARG2, sizeof(vki_uint32_t) );
2be083
+   attr = (struct vki_sched_attr *)(Addr)ARG2;
2be083
+   if (ML_(safe_to_deref)(attr,sizeof(vki_uint32_t)))
2be083
+      PRE_MEM_READ( "sched_setattr(attr)", (Addr)attr, attr->size);
2be083
+}
2be083
+
2be083
+PRE(sys_sched_getattr)
2be083
+{
2be083
+   struct vki_sched_attr *attr;
2be083
+   PRINT("sched_getattr ( %ld, %#" FMT_REGWORD "x, %ld, %#"
2be083
+         FMT_REGWORD "x )", SARG1, ARG2, ARG3, ARG4 );
2be083
+   PRE_REG_READ4(long, "sched_getattr",
2be083
+                 vki_pid_t, pid, struct sched_attr *, p,
2be083
+                 unsigned int, size, unsigned int, flags);
2be083
+   /* We need to be able to read at least the size field.  */
2be083
+   PRE_MEM_READ( "sched_setattr(attr->size)", ARG2, sizeof(vki_uint32_t) );
2be083
+   /* And the kernel needs to be able to write to the whole struct size. */
2be083
+   attr = (struct vki_sched_attr *)(Addr)ARG2;
2be083
+   if (ML_(safe_to_deref)(attr,sizeof(vki_uint32_t)))
2be083
+      PRE_MEM_WRITE( "sched_setattr(attr)", (Addr)attr, attr->size);
2be083
+}
2be083
+POST(sys_sched_getattr)
2be083
+{
2be083
+   struct vki_sched_attr *attr = (struct vki_sched_attr *)(Addr)ARG2;
2be083
+   POST_MEM_WRITE( (Addr)attr, attr->size );
2be083
+}
2be083
+
2be083
 PRE(sys_sched_getscheduler)
2be083
 {
2be083
    PRINT("sys_sched_getscheduler ( %ld )", SARG1);
2be083
diff --git a/coregrind/m_syswrap/syswrap-ppc32-linux.c b/coregrind/m_syswrap/syswrap-ppc32-linux.c
2be083
index eed12a1bc..c19cb9e0e 100644
2be083
--- a/coregrind/m_syswrap/syswrap-ppc32-linux.c
2be083
+++ b/coregrind/m_syswrap/syswrap-ppc32-linux.c
2be083
@@ -1016,6 +1016,9 @@ static SyscallTableEntry syscall_table[] = {
2be083
    LINXY(__NR_process_vm_readv,  sys_process_vm_readv), // 351
2be083
    LINX_(__NR_process_vm_writev, sys_process_vm_writev),// 352
2be083
 
2be083
+   LINX_(__NR_sched_setattr,     sys_sched_setattr),    // 355
2be083
+   LINXY(__NR_sched_getattr,     sys_sched_getattr),    // 356
2be083
+
2be083
    LINXY(__NR_getrandom,         sys_getrandom),        // 359
2be083
    LINXY(__NR_memfd_create,      sys_memfd_create),     // 360
2be083
 
2be083
diff --git a/coregrind/m_syswrap/syswrap-ppc64-linux.c b/coregrind/m_syswrap/syswrap-ppc64-linux.c
2be083
index d58200b49..b6422a765 100644
2be083
--- a/coregrind/m_syswrap/syswrap-ppc64-linux.c
2be083
+++ b/coregrind/m_syswrap/syswrap-ppc64-linux.c
2be083
@@ -998,6 +998,8 @@ static SyscallTableEntry syscall_table[] = {
2be083
    LINXY(__NR_process_vm_readv,  sys_process_vm_readv), // 351
2be083
    LINX_(__NR_process_vm_writev, sys_process_vm_writev),// 352
2be083
 
2be083
+   LINX_(__NR_sched_setattr,     sys_sched_setattr),    // 355
2be083
+   LINXY(__NR_sched_getattr,     sys_sched_getattr),    // 356
2be083
    LINX_(__NR_renameat2,         sys_renameat2),        // 357
2be083
 
2be083
    LINXY(__NR_getrandom,         sys_getrandom),        // 359
2be083
diff --git a/coregrind/m_syswrap/syswrap-s390x-linux.c b/coregrind/m_syswrap/syswrap-s390x-linux.c
2be083
index a0a330aa2..3427fee16 100644
2be083
--- a/coregrind/m_syswrap/syswrap-s390x-linux.c
2be083
+++ b/coregrind/m_syswrap/syswrap-s390x-linux.c
2be083
@@ -825,8 +825,8 @@ static SyscallTableEntry syscall_table[] = {
2be083
    LINX_(__NR_kcmp, sys_kcmp),                                        // 343
2be083
 // ?????(__NR_finit_module, ),                                        // 344
2be083
 
2be083
-// ?????(__NR_sched_setattr, ),                                       // 345
2be083
-// ?????(__NR_sched_getattr, ),                                       // 346
2be083
+   LINX_(__NR_sched_setattr, sys_sched_setattr),                      // 345
2be083
+   LINXY(__NR_sched_getattr, sys_sched_getattr),                      // 346
2be083
    LINX_(__NR_renameat2, sys_renameat2),                              // 347
2be083
 // ?????(__NR_seccomp, ),                                             // 348
2be083
    LINXY(__NR_getrandom, sys_getrandom),                              // 349
2be083
diff --git a/coregrind/m_syswrap/syswrap-x86-linux.c b/coregrind/m_syswrap/syswrap-x86-linux.c
2be083
index 332ed0bf2..b59d96f37 100644
2be083
--- a/coregrind/m_syswrap/syswrap-x86-linux.c
2be083
+++ b/coregrind/m_syswrap/syswrap-x86-linux.c
2be083
@@ -1580,8 +1580,8 @@ static SyscallTableEntry syscall_table[] = {
2be083
    LINX_(__NR_kcmp,              sys_kcmp),             // 349
2be083
 
2be083
 //   LIN__(__NR_finit_module,      sys_ni_syscall),       // 350
2be083
-//   LIN__(__NR_sched_setattr,     sys_ni_syscall),       // 351
2be083
-//   LIN__(__NR_sched_getattr,     sys_ni_syscall),       // 352
2be083
+   LINX_(__NR_sched_setattr,     sys_sched_setattr),    // 351
2be083
+   LINXY(__NR_sched_getattr,     sys_sched_getattr),    // 352
2be083
    LINX_(__NR_renameat2,         sys_renameat2),        // 353
2be083
 //   LIN__(__NR_seccomp,           sys_ni_syscall),       // 354
2be083
 
2be083
diff --git a/include/vki/vki-linux.h b/include/vki/vki-linux.h
2be083
index 75b583165..ef93b9258 100644
2be083
--- a/include/vki/vki-linux.h
2be083
+++ b/include/vki/vki-linux.h
2be083
@@ -410,6 +410,23 @@ struct vki_sched_param {
2be083
 	int sched_priority;
2be083
 };
2be083
 
2be083
+struct vki_sched_attr {
2be083
+	vki_uint32_t size;
2be083
+	vki_uint32_t sched_policy;
2be083
+	vki_uint64_t sched_flags;
2be083
+
2be083
+	/* SCHED_NORMAL, SCHED_BATCH */
2be083
+	vki_int32_t sched_nice;
2be083
+
2be083
+	/* SCHED_FIFO, SCHED_RR */
2be083
+	vki_uint32_t sched_priority;
2be083
+
2be083
+	/* SCHED_DEADLINE */
2be083
+	vki_uint64_t sched_runtime;
2be083
+	vki_uint64_t sched_deadline;
2be083
+	vki_uint64_t sched_period;
2be083
+};
2be083
+
2be083
 #define VKI_TASK_COMM_LEN 16
2be083
 
2be083
 //----------------------------------------------------------------------