7a6b42
commit be7a73004583aab5d4c97cf55276ca58d5b3090b
7a6b42
Author: Mark Wielaard <mark@klomp.org>
7a6b42
Date:   Wed Dec 12 14:15:28 2018 +0100
7a6b42
7a6b42
    Mark helper regs defined in final_tidyup before freeres_wrapper call.
7a6b42
    
7a6b42
    In final_tidyup we setup the guest to call the freeres_wrapper, which
7a6b42
    will (possibly) call __gnu_cxx::__freeres() and/or __libc_freeres().
7a6b42
    
7a6b42
    In a couple of cases (ppc64be, ppc64le and mips32) this involves setting
7a6b42
    up one or more helper registers. Since we setup these guest registers
7a6b42
    we should make sure to mark them as fully defined. Otherwise we might
7a6b42
    see spurious warnings about undefined value usage if the guest register
7a6b42
    happened to not be fully defined before.
7a6b42
    
7a6b42
    This fixes PR402006.
7a6b42
7a6b42
diff --git a/coregrind/m_main.c b/coregrind/m_main.c
7a6b42
index 00702fc..22872a2 100644
7a6b42
--- a/coregrind/m_main.c
7a6b42
+++ b/coregrind/m_main.c
7a6b42
@@ -2304,22 +2304,35 @@ static void final_tidyup(ThreadId tid)
7a6b42
                    "Caught __NR_exit; running %s wrapper\n", msgs[to_run - 1]);
7a6b42
    }
7a6b42
       
7a6b42
-   /* set thread context to point to freeres_wrapper */
7a6b42
-   /* ppc64be-linux note: freeres_wrapper gives us the real
7a6b42
+   /* Set thread context to point to freeres_wrapper.
7a6b42
+      ppc64be-linux note: freeres_wrapper gives us the real
7a6b42
       function entry point, not a fn descriptor, so can use it
7a6b42
       directly.  However, we need to set R2 (the toc pointer)
7a6b42
       appropriately. */
7a6b42
    VG_(set_IP)(tid, freeres_wrapper);
7a6b42
+
7a6b42
 #  if defined(VGP_ppc64be_linux)
7a6b42
    VG_(threads)[tid].arch.vex.guest_GPR2 = r2;
7a6b42
+   VG_TRACK(post_reg_write, Vg_CoreClientReq, tid,
7a6b42
+            offsetof(VexGuestPPC64State, guest_GPR2),
7a6b42
+            sizeof(VG_(threads)[tid].arch.vex.guest_GPR2));
7a6b42
 #  elif  defined(VGP_ppc64le_linux)
7a6b42
    /* setting GPR2 but not really needed, GPR12 is needed */
7a6b42
    VG_(threads)[tid].arch.vex.guest_GPR2  = freeres_wrapper;
7a6b42
+   VG_TRACK(post_reg_write, Vg_CoreClientReq, tid,
7a6b42
+            offsetof(VexGuestPPC64State, guest_GPR2),
7a6b42
+            sizeof(VG_(threads)[tid].arch.vex.guest_GPR2));
7a6b42
    VG_(threads)[tid].arch.vex.guest_GPR12 = freeres_wrapper;
7a6b42
+   VG_TRACK(post_reg_write, Vg_CoreClientReq, tid,
7a6b42
+            offsetof(VexGuestPPC64State, guest_GPR12),
7a6b42
+            sizeof(VG_(threads)[tid].arch.vex.guest_GPR12));
7a6b42
 #  endif
7a6b42
    /* mips-linux note: we need to set t9 */
7a6b42
 #  if defined(VGP_mips32_linux) || defined(VGP_mips64_linux)
7a6b42
    VG_(threads)[tid].arch.vex.guest_r25 = freeres_wrapper;
7a6b42
+   VG_TRACK(post_reg_write, Vg_CoreClientReq, tid,
7a6b42
+            offsetof(VexGuestMIPS32State, guest_r25),
7a6b42
+            sizeof(VG_(threads)[tid].arch.vex.guest_r25));
7a6b42
 #  endif
7a6b42
 
7a6b42
    /* Pass a parameter to freeres_wrapper(). */