|
 |
531551 |
From d94c73b186ea4fec6333d1fb6cced1b4b8515d58 Mon Sep 17 00:00:00 2001
|
|
|
531551 |
From: Karel Zak <kzak@redhat.com>
|
|
|
531551 |
Date: Mon, 7 Apr 2014 11:53:05 +0200
|
|
|
531551 |
Subject: [PATCH 097/116] mount: fix --all and nofail return code
|
|
|
531551 |
|
|
|
531551 |
Now the "nofail" affects warnings warning messages only. That's wrong
|
|
|
531551 |
and regression (against original non-libmount version). The nofail has
|
|
|
531551 |
to control return code too.
|
|
|
531551 |
|
|
|
531551 |
Upstream: https://github.com/karelzak/util-linux/commit/8ab82185eed76bc20694a197fe10c5f9fb795b80
|
|
|
531551 |
Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1357746
|
|
|
531551 |
Reported-by: Patrick McLean <chutzpah@gentoo.org>
|
|
|
531551 |
Signed-off-by: Karel Zak <kzak@redhat.com>
|
|
|
531551 |
---
|
|
|
531551 |
sys-utils/mount.c | 10 ++++++----
|
|
|
531551 |
1 file changed, 6 insertions(+), 4 deletions(-)
|
|
|
531551 |
|
|
|
531551 |
diff --git a/sys-utils/mount.c b/sys-utils/mount.c
|
|
|
531551 |
index f332070..44e2b7c 100644
|
|
|
531551 |
--- a/sys-utils/mount.c
|
|
|
531551 |
+++ b/sys-utils/mount.c
|
|
|
531551 |
@@ -197,12 +197,14 @@ static int mount_all(struct libmnt_context *cxt)
|
|
|
531551 |
if (mnt_context_is_verbose(cxt))
|
|
|
531551 |
printf("%-25s: mount successfully forked\n", tgt);
|
|
|
531551 |
} else {
|
|
|
531551 |
- mk_exit_code(cxt, mntrc); /* to print warnings */
|
|
|
531551 |
-
|
|
|
531551 |
- if (mnt_context_get_status(cxt)) {
|
|
|
531551 |
+ if (mk_exit_code(cxt, mntrc) == MOUNT_EX_SUCCESS) {
|
|
|
531551 |
nsucc++;
|
|
|
531551 |
|
|
|
531551 |
- if (mnt_context_is_verbose(cxt))
|
|
|
531551 |
+ /* Note that MOUNT_EX_SUCCESS return code does
|
|
|
531551 |
+ * not mean that FS has been really mounted
|
|
|
531551 |
+ * (e.g. nofail option) */
|
|
|
531551 |
+ if (mnt_context_get_status(cxt)
|
|
|
531551 |
+ && mnt_context_is_verbose(cxt))
|
|
|
531551 |
printf("%-25s: successfully mounted\n", tgt);
|
|
|
531551 |
} else
|
|
|
531551 |
nerrs++;
|
|
|
531551 |
--
|
|
|
531551 |
2.9.3
|
|
|
531551 |
|