Blame SOURCES/0033-lib-path-make-ul_path_read_buffer-more-robust-coveri.patch
|
 |
dbeef3 |
From f6fffc1a89e57b7d5dd4adf1ee6b2146e58ec411 Mon Sep 17 00:00:00 2001
|
|
|
dbeef3 |
From: Karel Zak <kzak@redhat.com>
|
|
|
dbeef3 |
Date: Thu, 17 Mar 2022 12:18:03 +0100
|
|
|
dbeef3 |
Subject: lib/path: make ul_path_read_buffer() more robust [coverity scan]
|
|
|
dbeef3 |
|
|
|
dbeef3 |
Make sure we never call buf[rc - 1] for rc=0.
|
|
|
dbeef3 |
|
|
|
dbeef3 |
Upstream: http://github.com/util-linux/util-linux/commit/ea459dcf95d0bb04c816b71d2b85fbcd8cfc5ee4
|
|
|
dbeef3 |
Addresses: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2109459
|
|
|
dbeef3 |
Signed-off-by: Karel Zak <kzak@redhat.com>
|
|
|
dbeef3 |
---
|
|
|
dbeef3 |
lib/path.c | 17 ++++++++++-------
|
|
|
dbeef3 |
1 file changed, 10 insertions(+), 7 deletions(-)
|
|
|
dbeef3 |
|
|
|
dbeef3 |
diff --git a/lib/path.c b/lib/path.c
|
|
|
dbeef3 |
index 21f9bd1c4..ab034e110 100644
|
|
|
dbeef3 |
--- a/lib/path.c
|
|
|
dbeef3 |
+++ b/lib/path.c
|
|
|
dbeef3 |
@@ -666,14 +666,17 @@ int ul_path_readf_string(struct path_cxt *pc, char **str, const char *path, ...)
|
|
|
dbeef3 |
int ul_path_read_buffer(struct path_cxt *pc, char *buf, size_t bufsz, const char *path)
|
|
|
dbeef3 |
{
|
|
|
dbeef3 |
int rc = ul_path_read(pc, buf, bufsz - 1, path);
|
|
|
dbeef3 |
- if (rc < 0)
|
|
|
dbeef3 |
- return rc;
|
|
|
dbeef3 |
|
|
|
dbeef3 |
- /* Remove tailing newline (usual in sysfs) */
|
|
|
dbeef3 |
- if (rc > 0 && *(buf + rc - 1) == '\n')
|
|
|
dbeef3 |
- buf[--rc] = '\0';
|
|
|
dbeef3 |
- else
|
|
|
dbeef3 |
- buf[rc - 1] = '\0';
|
|
|
dbeef3 |
+ if (rc == 0)
|
|
|
dbeef3 |
+ buf[0] = '\0';
|
|
|
dbeef3 |
+
|
|
|
dbeef3 |
+ else if (rc > 0) {
|
|
|
dbeef3 |
+ /* Remove tailing newline (usual in sysfs) */
|
|
|
dbeef3 |
+ if (*(buf + rc - 1) == '\n')
|
|
|
dbeef3 |
+ buf[--rc] = '\0';
|
|
|
dbeef3 |
+ else
|
|
|
dbeef3 |
+ buf[rc - 1] = '\0';
|
|
|
dbeef3 |
+ }
|
|
|
dbeef3 |
|
|
|
dbeef3 |
return rc;
|
|
|
dbeef3 |
}
|
|
|
dbeef3 |
--
|
|
|
dbeef3 |
2.36.1
|
|
|
dbeef3 |
|