|
 |
1ed299 |
From 754137e70cf58a64ad524b704a86b651ba0cde07 Mon Sep 17 00:00:00 2001
|
|
|
1ed299 |
From: Petr Stodulka <pstodulk@redhat.com>
|
|
|
1ed299 |
Date: Wed, 14 Dec 2016 16:30:36 +0100
|
|
|
1ed299 |
Subject: [PATCH] Fix CVE-2016-9844 (rhbz#1404283)
|
|
|
1ed299 |
|
|
|
1ed299 |
Fixes buffer overflow in zipinfo in similar way like fix for
|
|
|
1ed299 |
CVE-2014-9913 provided by upstream.
|
|
|
1ed299 |
---
|
|
|
1ed299 |
zipinfo.c | 14 +++++++++++++-
|
|
|
1ed299 |
1 file changed, 13 insertions(+), 1 deletion(-)
|
|
|
1ed299 |
|
|
|
1ed299 |
diff --git a/zipinfo.c b/zipinfo.c
|
|
|
1ed299 |
index c03620e..accca2a 100644
|
|
|
1ed299 |
--- a/zipinfo.c
|
|
|
1ed299 |
+++ b/zipinfo.c
|
|
|
1ed299 |
@@ -1984,7 +1984,19 @@ static int zi_short(__G) /* return PK-type error code */
|
|
|
1ed299 |
ush dnum=(ush)((G.crec.general_purpose_bit_flag>>1) & 3);
|
|
|
1ed299 |
methbuf[3] = dtype[dnum];
|
|
|
1ed299 |
} else if (methnum >= NUM_METHODS) { /* unknown */
|
|
|
1ed299 |
- sprintf(&methbuf[1], "%03u", G.crec.compression_method);
|
|
|
1ed299 |
+ /* 2016-12-05 SMS.
|
|
|
1ed299 |
+ * https://launchpad.net/bugs/1643750
|
|
|
1ed299 |
+ * Unexpectedly large compression methods overflow
|
|
|
1ed299 |
+ * &methbuf[]. Use the old, three-digit decimal format
|
|
|
1ed299 |
+ * for values which fit. Otherwise, sacrifice the "u",
|
|
|
1ed299 |
+ * and use four-digit hexadecimal.
|
|
|
1ed299 |
+ */
|
|
|
1ed299 |
+ if (G.crec.compression_method <= 999) {
|
|
|
1ed299 |
+ sprintf( &methbuf[ 1], "%03u", G.crec.compression_method);
|
|
|
1ed299 |
+ } else {
|
|
|
1ed299 |
+ sprintf( &methbuf[ 0], "%04X", G.crec.compression_method);
|
|
|
1ed299 |
+ }
|
|
|
1ed299 |
+
|
|
|
1ed299 |
}
|
|
|
1ed299 |
|
|
|
1ed299 |
for (k = 0; k < 15; ++k)
|
|
|
1ed299 |
--
|
|
|
1ed299 |
2.5.5
|
|
|
1ed299 |
|