|
 |
59cea9 |
From de7c59d25d9fd2464543d649951b2ae47c2a839b Mon Sep 17 00:00:00 2001
|
|
|
59cea9 |
From: wouter <wouter@be551aaa-1e26-0410-a405-d3ace91eadb9>
|
|
|
59cea9 |
Date: Wed, 21 Aug 2013 13:31:09 +0000
|
|
|
59cea9 |
Subject: [PATCH] - Fix#520: Errors found by static analysis from Tomas
|
|
|
59cea9 |
Hozza(redhat).
|
|
|
59cea9 |
|
|
|
59cea9 |
git-svn-id: http://unbound.nlnetlabs.nl/svn/trunk@2942 be551aaa-1e26-0410-a405-d3ace91eadb9
|
|
|
59cea9 |
Signed-off-by: Tomas Hozza <thozza@redhat.com>
|
|
|
59cea9 |
---
|
|
|
59cea9 |
libunbound/libworker.c | 3 +++
|
|
|
59cea9 |
testcode/streamtcp.c | 2 +-
|
|
|
59cea9 |
util/tube.c | 2 +-
|
|
|
59cea9 |
validator/autotrust.c | 6 +++++-
|
|
|
59cea9 |
4 files changed, 10 insertions(+), 3 deletions(-)
|
|
|
59cea9 |
|
|
|
59cea9 |
diff --git a/libunbound/libworker.c b/libunbound/libworker.c
|
|
|
59cea9 |
index dd3316d..8f2aa48 100644
|
|
|
59cea9 |
--- a/libunbound/libworker.c
|
|
|
59cea9 |
+++ b/libunbound/libworker.c
|
|
|
59cea9 |
@@ -198,7 +198,10 @@ libworker_setup(struct ub_ctx* ctx, int is_bg)
|
|
|
59cea9 |
}
|
|
|
59cea9 |
numports = cfg_condense_ports(cfg, &ports);
|
|
|
59cea9 |
if(numports == 0) {
|
|
|
59cea9 |
+ int locked = !w->is_bg || w->is_bg_thread;
|
|
|
59cea9 |
libworker_delete(w);
|
|
|
59cea9 |
+ if(locked)
|
|
|
59cea9 |
+ lock_basic_unlock(&ctx->cfglock);
|
|
|
59cea9 |
return NULL;
|
|
|
59cea9 |
}
|
|
|
59cea9 |
w->back = outside_network_create(w->base, cfg->msg_buffer_size,
|
|
|
59cea9 |
diff --git a/testcode/streamtcp.c b/testcode/streamtcp.c
|
|
|
59cea9 |
index dbdf140..06a18e4 100644
|
|
|
59cea9 |
--- a/testcode/streamtcp.c
|
|
|
59cea9 |
+++ b/testcode/streamtcp.c
|
|
|
59cea9 |
@@ -121,9 +121,9 @@ write_q(int fd, int udp, SSL* ssl, ldns_buffer* buf, uint16_t id,
|
|
|
59cea9 |
exit(1);
|
|
|
59cea9 |
}
|
|
|
59cea9 |
qinfo.qname = memdup(ldns_rdf_data(rdf), ldns_rdf_size(rdf));
|
|
|
59cea9 |
+ if(!qinfo.qname) fatal_exit("out of memory");
|
|
|
59cea9 |
(void)dname_count_size_labels(qinfo.qname, &qinfo.qname_len);
|
|
|
59cea9 |
ldns_rdf_deep_free(rdf);
|
|
|
59cea9 |
- if(!qinfo.qname) fatal_exit("out of memory");
|
|
|
59cea9 |
|
|
|
59cea9 |
/* qtype and qclass */
|
|
|
59cea9 |
qinfo.qtype = ldns_get_rr_type_by_name(strtype);
|
|
|
59cea9 |
diff --git a/util/tube.c b/util/tube.c
|
|
|
59cea9 |
index 28c51d7..fde8496 100644
|
|
|
59cea9 |
--- a/util/tube.c
|
|
|
59cea9 |
+++ b/util/tube.c
|
|
|
59cea9 |
@@ -368,7 +368,7 @@ int tube_read_msg(struct tube* tube, uint8_t** buf, uint32_t* len,
|
|
|
59cea9 |
return 0;
|
|
|
59cea9 |
}
|
|
|
59cea9 |
d = 0;
|
|
|
59cea9 |
- while(d != (ssize_t)*len) {
|
|
|
59cea9 |
+ while(d < (ssize_t)*len) {
|
|
|
59cea9 |
if((r=read(fd, (*buf)+d, (size_t)((ssize_t)*len)-d)) == -1) {
|
|
|
59cea9 |
log_err("tube msg read failed: %s", strerror(errno));
|
|
|
59cea9 |
(void)fd_set_nonblock(fd);
|
|
|
59cea9 |
diff --git a/validator/autotrust.c b/validator/autotrust.c
|
|
|
59cea9 |
index 1e24b4c..dc7cbf6 100644
|
|
|
59cea9 |
--- a/validator/autotrust.c
|
|
|
59cea9 |
+++ b/validator/autotrust.c
|
|
|
59cea9 |
@@ -976,9 +976,13 @@ void autr_write_file(struct module_env* env, struct trust_anchor* tp)
|
|
|
59cea9 |
char* fname = tp->autr->file;
|
|
|
59cea9 |
char tempf[2048];
|
|
|
59cea9 |
log_assert(tp->autr);
|
|
|
59cea9 |
+ if(!env) {
|
|
|
59cea9 |
+ log_err("autr_write_file: Module environment is NULL.");
|
|
|
59cea9 |
+ return;
|
|
|
59cea9 |
+ }
|
|
|
59cea9 |
/* unique name with pid number and thread number */
|
|
|
59cea9 |
snprintf(tempf, sizeof(tempf), "%s.%d-%d", fname, (int)getpid(),
|
|
|
59cea9 |
- env&&env->worker?*(int*)env->worker:0);
|
|
|
59cea9 |
+ env->worker?*(int*)env->worker:0);
|
|
|
59cea9 |
verbose(VERB_ALGO, "autotrust: write to disk: %s", tempf);
|
|
|
59cea9 |
out = fopen(tempf, "w");
|
|
|
59cea9 |
if(!out) {
|
|
|
59cea9 |
--
|
|
|
59cea9 |
1.8.3.1
|
|
|
59cea9 |
|