6903c7
From eb917d346bc8592924c5f6566b01841176c53c8c Mon Sep 17 00:00:00 2001
6903c7
From: Tomas Bzatek <tbzatek@redhat.com>
6903c7
Date: Mon, 22 Aug 2022 16:27:11 +0200
6903c7
Subject: [PATCH] udiskslinuxblock: Only permit ATA Secure Erase during
6903c7
 Format() on a whole block device
6903c7
6903c7
ATA Secure Erase requested as an option to the Format() method call used
6903c7
to perform the actual erase on a whole drive object it looked up. When
6903c7
Format() was called on a partition, this led to data loss on a whole drive.
6903c7
This commit adds a safeguard to check that the Format() is requested
6903c7
on a whole block device.
6903c7
6903c7
Severity of this issue was slightly lowered by a failure to submit
6903c7
the ATA Secure erase command in case some filesystem was mounted
6903c7
at that point.
6903c7
---
6903c7
 src/udiskslinuxblock.c | 16 ++++++++++++++++
6903c7
 1 file changed, 16 insertions(+)
6903c7
6903c7
diff --git a/src/udiskslinuxblock.c b/src/udiskslinuxblock.c
6903c7
index d1da94edf..db0ed2bf6 100644
6903c7
--- a/src/udiskslinuxblock.c
6903c7
+++ b/src/udiskslinuxblock.c
6903c7
@@ -2354,6 +2354,7 @@ erase_ata_device (UDisksBlock   *block,
6903c7
 {
6903c7
   gboolean ret = FALSE;
6903c7
   UDisksObject *drive_object = NULL;
6903c7
+  UDisksLinuxBlockObject *block_object = NULL;
6903c7
   UDisksDriveAta *ata = NULL;
6903c7
 
6903c7
   drive_object = udisks_daemon_find_object (daemon, udisks_block_get_drive (block));
6903c7
@@ -2369,6 +2370,20 @@ erase_ata_device (UDisksBlock   *block,
6903c7
       goto out;
6903c7
     }
6903c7
 
6903c7
+  /* Reverse check to ensure we're erasing whole block device and not a partition */
6903c7
+  block_object = udisks_linux_drive_object_get_block (UDISKS_LINUX_DRIVE_OBJECT (drive_object), FALSE /* get_hw */);
6903c7
+  if (block_object == NULL)
6903c7
+    {
6903c7
+      g_set_error (error, UDISKS_ERROR, UDISKS_ERROR_FAILED, "Couldn't find a block device for the drive to erase");
6903c7
+      goto out;
6903c7
+    }
6903c7
+  if (g_strcmp0 (g_dbus_object_get_object_path (G_DBUS_OBJECT (object)),
6903c7
+                 g_dbus_object_get_object_path (G_DBUS_OBJECT (block_object))) != 0)
6903c7
+    {
6903c7
+      g_set_error (error, UDISKS_ERROR, UDISKS_ERROR_FAILED, "ATA secure erase needs to be performed on a whole block device");
6903c7
+      goto out;
6903c7
+    }
6903c7
+
6903c7
   /* sleep a tiny bit here to avoid the secure erase code racing with
6903c7
    * programs spawned by udev
6903c7
    */
6903c7
@@ -2382,6 +2397,7 @@ erase_ata_device (UDisksBlock   *block,
6903c7
  out:
6903c7
   g_clear_object (&ata;;
6903c7
   g_clear_object (&drive_object);
6903c7
+  g_clear_object (&block_object);
6903c7
   return ret;
6903c7
 }
6903c7