|
 |
ea29f4 |
commit 0b91f8a668201fc58fa732b8acc496caedfdbae0
|
|
|
ea29f4 |
Author: Florian Weimer <fw@deneb.enyo.de>
|
|
|
ea29f4 |
Date: Sun Apr 29 12:18:33 2018 -0700
|
|
|
ea29f4 |
|
|
|
ea29f4 |
Indicate that _PyGC_Head is only 8-byte aligned. (closes bpo-33374)
|
|
|
ea29f4 |
|
|
|
ea29f4 |
By spec, the "long double" in _PyGC_Head requires the union to always be 16-byte
|
|
|
ea29f4 |
aligned. However, obmalloc only yields 8-byte alignment. Compilers including GCC
|
|
|
ea29f4 |
8 are starting to use alignment information to do store-merging. So, the "long
|
|
|
ea29f4 |
double" needs to be changed to a simple "double" as was long ago done in Python
|
|
|
ea29f4 |
3 by e348c8d154cf6342c79d627ebfe89dfe9de23817. For 2.7, we need to add some
|
|
|
ea29f4 |
dummy padding to make sure _PyGC_Head stays the same size.
|
|
|
ea29f4 |
|
|
|
ea29f4 |
diff --git a/Include/objimpl.h b/Include/objimpl.h
|
|
|
ea29f4 |
index 5f28683329..cbf6bc3f87 100644
|
|
|
ea29f4 |
--- Python-2.7.13/Include/objimpl.h
|
|
|
ea29f4 |
+++ Python-2.7.13/Include/objimpl.h
|
|
|
ea29f4 |
@@ -248,6 +248,20 @@ PyAPI_FUNC(PyVarObject *) _PyObject_GC_Resize(PyVarObject *, Py_ssize_t);
|
|
|
ea29f4 |
/* for source compatibility with 2.2 */
|
|
|
ea29f4 |
#define _PyObject_GC_Del PyObject_GC_Del
|
|
|
ea29f4 |
|
|
|
ea29f4 |
+/*
|
|
|
ea29f4 |
+ * Former over-aligned definition of PyGC_Head, used to compute the size of the
|
|
|
ea29f4 |
+ * padding for the new version below.
|
|
|
ea29f4 |
+ */
|
|
|
ea29f4 |
+union _gc_head;
|
|
|
ea29f4 |
+union _gc_head_old {
|
|
|
ea29f4 |
+ struct {
|
|
|
ea29f4 |
+ union _gc_head_old *gc_next;
|
|
|
ea29f4 |
+ union _gc_head_old *gc_prev;
|
|
|
ea29f4 |
+ Py_ssize_t gc_refs;
|
|
|
ea29f4 |
+ } gc;
|
|
|
ea29f4 |
+ long double dummy;
|
|
|
ea29f4 |
+};
|
|
|
ea29f4 |
+
|
|
|
ea29f4 |
/* GC information is stored BEFORE the object structure. */
|
|
|
ea29f4 |
typedef union _gc_head {
|
|
|
ea29f4 |
struct {
|
|
|
ea29f4 |
@@ -255,7 +269,8 @@ typedef union _gc_head {
|
|
|
ea29f4 |
union _gc_head *gc_prev;
|
|
|
ea29f4 |
Py_ssize_t gc_refs;
|
|
|
ea29f4 |
} gc;
|
|
|
ea29f4 |
- long double dummy; /* force worst-case alignment */
|
|
|
ea29f4 |
+ double dummy; /* Force at least 8-byte alignment. */
|
|
|
ea29f4 |
+ char dummy_padding[sizeof(union _gc_head_old)];
|
|
|
ea29f4 |
} PyGC_Head;
|
|
|
ea29f4 |
|
|
|
ea29f4 |
extern PyGC_Head *_PyGC_generation0;
|
|
|
ea29f4 |
diff --git a/Misc/NEWS.d/next/Core and Builtins/2018-04-29-12-07-00.bpo-33374.-xegL6.rst b/Misc/NEWS.d/next/Core and Builtins/2018-04-29-12-07-00.bpo-33374.-xegL6.rst
|
|
|
ea29f4 |
new file mode 100644
|
|
|
ea29f4 |
index 0000000000..9ec1a605c8
|
|
|
ea29f4 |
--- /dev/null
|
|
|
ea29f4 |
+++ Python-2.7.13/Misc/NEWS.d/next/Core and Builtins/2018-04-29-12-07-00.bpo-33374.-xegL6.rst
|
|
|
ea29f4 |
@@ -0,0 +1,3 @@
|
|
|
ea29f4 |
+Tweak the definition of PyGC_Head, so compilers do not believe it is always
|
|
|
ea29f4 |
+16-byte aligned on x86. This prevents crashes with more aggressive
|
|
|
ea29f4 |
+optimizations present in GCC 8.
|