Blame SOURCES/telnet-0.17-CAN-2005-468_469.patch

e4a049
--- netkit-telnet-0.17/telnet/telnet.c.CAN-2005-468_469	2005-03-17 13:48:58.000000000 +0100
e4a049
+++ netkit-telnet-0.17/telnet/telnet.c	2005-03-17 14:02:27.000000000 +0100
e4a049
@@ -1310,22 +1310,66 @@
e4a049
 }
e4a049
 
e4a049
 
e4a049
-unsigned char slc_reply[128];
e4a049
+#define SLC_REPLY_SIZE 128
e4a049
+unsigned char *slc_reply;
e4a049
 unsigned char *slc_replyp;
e4a049
+unsigned char *slc_replyend;
e4a049
 
e4a049
 	void
e4a049
 slc_start_reply(void)
e4a049
 {
e4a049
+        slc_reply = (unsigned char *)malloc(SLC_REPLY_SIZE);
e4a049
+        if (slc_reply == NULL) {
e4a049
+/*@*/           printf("slc_start_reply: malloc()/realloc() failed!!!\n");
e4a049
+                slc_reply = slc_replyp = slc_replyend = NULL;
e4a049
+                return;
e4a049
+	}
e4a049
+
e4a049
 	slc_replyp = slc_reply;
e4a049
+	slc_replyend = slc_reply + SLC_REPLY_SIZE;
e4a049
 	*slc_replyp++ = IAC;
e4a049
 	*slc_replyp++ = SB;
e4a049
 	*slc_replyp++ = TELOPT_LINEMODE;
e4a049
 	*slc_replyp++ = LM_SLC;
e4a049
 }
e4a049
 
e4a049
+static int
e4a049
+slc_assure_buffer(int want_len);
e4a049
+
e4a049
+	static int
e4a049
+slc_assure_buffer(int want_len)
e4a049
+{
e4a049
+        if ((slc_replyp + want_len) >= slc_replyend) {
e4a049
+                int len;
e4a049
+		int old_len = slc_replyp - slc_reply;
e4a049
+		unsigned char *p;
e4a049
+
e4a049
+                len = old_len
e4a049
+			+ (want_len / SLC_REPLY_SIZE + 1) * SLC_REPLY_SIZE;
e4a049
+                p = (unsigned char *)realloc(slc_reply, len);
e4a049
+                if (p == NULL)
e4a049
+                        free(slc_reply);
e4a049
+                slc_reply = p;
e4a049
+                if (slc_reply == NULL) {
e4a049
+/*@*/                   printf("slc_add_reply: realloc() failed!!!\n");
e4a049
+                        slc_reply = slc_replyp = slc_replyend = NULL;
e4a049
+                        return 1;
e4a049
+                }
e4a049
+                slc_replyp = slc_reply + old_len;
e4a049
+                slc_replyend = slc_reply + len;
e4a049
+        }
e4a049
+	return 0;
e4a049
+}
e4a049
+
e4a049
 	void
e4a049
 slc_add_reply(unsigned char func, unsigned char flags, cc_t value)
e4a049
 {
e4a049
+	if (slc_assure_buffer(6))
e4a049
+		return;
e4a049
+
e4a049
+	if (slc_replyp == NULL)
e4a049
+		return;
e4a049
+
e4a049
 	if ((*slc_replyp++ = func) == IAC)
e4a049
 		*slc_replyp++ = IAC;
e4a049
 	if ((*slc_replyp++ = flags) == IAC)
e4a049
@@ -1339,6 +1383,12 @@
e4a049
 {
e4a049
     int len;
e4a049
 
e4a049
+    if (slc_assure_buffer(2))
e4a049
+	return;
e4a049
+
e4a049
+    if (slc_replyp == NULL)
e4a049
+	return;
e4a049
+
e4a049
     *slc_replyp++ = IAC;
e4a049
     *slc_replyp++ = SE;
e4a049
     len = slc_replyp - slc_reply;
e4a049
@@ -1456,7 +1506,7 @@
e4a049
 	}
e4a049
 }
e4a049
 
e4a049
-#define	OPT_REPLY_SIZE	256
e4a049
+#define	OPT_REPLY_SIZE	1024
e4a049
 unsigned char *opt_reply;
e4a049
 unsigned char *opt_replyp;
e4a049
 unsigned char *opt_replyend;
e4a049
@@ -1490,10 +1540,38 @@
e4a049
 env_opt_start_info(void)
e4a049
 {
e4a049
 	env_opt_start();
e4a049
-	if (opt_replyp)
e4a049
+	if (opt_replyp && (opt_replyp > opt_reply))
e4a049
 	    opt_replyp[-1] = TELQUAL_INFO;
e4a049
 }
e4a049
 
e4a049
+static int
e4a049
+env_opt_assure_buffer(int want_len);
e4a049
+
e4a049
+	static int
e4a049
+env_opt_assure_buffer(int want_len)
e4a049
+{
e4a049
+        if ((opt_replyp + want_len) >= opt_replyend) {
e4a049
+		int len;
e4a049
+		unsigned char *p;
e4a049
+		int old_len = opt_replyp - opt_reply;
e4a049
+
e4a049
+		len = old_len
e4a049
+			+ (want_len / OPT_REPLY_SIZE + 1) * OPT_REPLY_SIZE;
e4a049
+		p = (unsigned char *)realloc(opt_reply, len);
e4a049
+		if (p == NULL)
e4a049
+			free(opt_reply);
e4a049
+		opt_reply = p;
e4a049
+		if (opt_reply == NULL) {
e4a049
+/*@*/			printf("env_opt_add: realloc() failed!!!\n");
e4a049
+			opt_reply = opt_replyp = opt_replyend = NULL;
e4a049
+			return 1;
e4a049
+		}
e4a049
+		opt_replyp = opt_reply + old_len;
e4a049
+		opt_replyend = opt_reply + len;
e4a049
+	}
e4a049
+	return 0;
e4a049
+}
e4a049
+
e4a049
 	void
e4a049
 env_opt_add(unsigned char *ep)
e4a049
 {
e4a049
@@ -1515,25 +1593,12 @@
e4a049
 		return;
e4a049
 	}
e4a049
 	vp = env_getvalue(ep, 1);
e4a049
-	if (opt_replyp + (vp ? strlen((char *)vp) : 0) +
e4a049
-				strlen((char *)ep) + 6 > opt_replyend)
e4a049
-	{
e4a049
-		int len;
e4a049
-		unsigned char *p;
e4a049
-		opt_replyend += OPT_REPLY_SIZE;
e4a049
-		len = opt_replyend - opt_reply;
e4a049
-		p = (unsigned char *)realloc(opt_reply, len);
e4a049
-		if (p == NULL)
e4a049
-			free(opt_reply);
e4a049
-		opt_reply = p;
e4a049
-		if (opt_reply == NULL) {
e4a049
-/*@*/			printf("env_opt_add: realloc() failed!!!\n");
e4a049
-			opt_reply = opt_replyp = opt_replyend = NULL;
e4a049
-			return;
e4a049
-		}
e4a049
-		opt_replyp = opt_reply + len - (opt_replyend - opt_replyp);
e4a049
-		opt_replyend = opt_reply + len;
e4a049
-	}
e4a049
+
e4a049
+	/* use the double length in case it gots escaped */
e4a049
+	if (env_opt_assure_buffer((vp ? strlen((char *)vp)*2 : 0) +
e4a049
+				strlen((char *)ep)*2 + 6))
e4a049
+		return;
e4a049
+
e4a049
 	if (opt_welldefined((char *)ep))
e4a049
 #ifdef	OLD_ENVIRON
e4a049
 		if (telopt_environ == TELOPT_OLD_ENVIRON)
e4a049
@@ -1588,8 +1653,14 @@
e4a049
 {
e4a049
 	int len;
e4a049
 
e4a049
+        if (opt_reply == NULL)          /*XXX*/
e4a049
+                return;                 /*XXX*/
e4a049
+
e4a049
+
e4a049
 	len = opt_replyp - opt_reply + 2;
e4a049
 	if (emptyok || len > 6) {
e4a049
+		if (env_opt_assure_buffer(2))
e4a049
+			return;
e4a049
 		*opt_replyp++ = IAC;
e4a049
 		*opt_replyp++ = SE;
e4a049
 		if (NETROOM() > len) {