Blame SOURCES/netkit-telnet-0.17-covscan.patch

3521ef
--- a/telnet/commands.c.old
3521ef
+++ b/telnet/commands.c
3521ef
@@ -2181,12 +2181,13 @@ cmdrc(char *m1, char *m2)
3521ef
     int gotmachine = 0;
3521ef
     int l1 = strlen(m1);
3521ef
     int l2 = strlen(m2);
3521ef
-    char m1save[MAXHOSTNAMELEN];
3521ef
+    char m1save[MAXHOSTNAMELEN+1];
3521ef
 
3521ef
     if (skiprc)
3521ef
 	return;
3521ef
 
3521ef
     strncpy(m1save, m1, sizeof(m1save));
3521ef
+    m1save[MAXHOSTNAMELEN] = 0;
3521ef
     m1 = m1save;
3521ef
 
3521ef
     if (rcname[0] == 0) {
3521ef
@@ -2218,11 +2218,11 @@ cmdrc(char *m1, char *m2)
3521ef
 	    if (isspace(line[0]))
3521ef
 		continue;
3521ef
 	    if (strncasecmp(line, m1, l1) == 0)
3521ef
-		strncpy(line, &line[l1], sizeof(line) - l1);
3521ef
+		memmove(line, &line[l1], sizeof(line) - l1);
3521ef
 	    else if (strncasecmp(line, m2, l2) == 0)
3521ef
-		strncpy(line, &line[l2], sizeof(line) - l2);
3521ef
+		memmove(line, &line[l2], sizeof(line) - l2);
3521ef
 	    else if (strncasecmp(line, "DEFAULT", 7) == 0)
3521ef
-		strncpy(line, &line[7], sizeof(line) - 7);
3521ef
+		memmove(line, &line[7], sizeof(line) - 7);
3521ef
 	    else
3521ef
 		continue;
3521ef
 	    if (line[0] != ' ' && line[0] != '\t' && line[0] != '\n')
3521ef
@@ -2345,6 +2345,7 @@ tn(int argc, char *argv[])
3521ef
 	}
3521ef
     usage:
3521ef
 	printf("usage: %s [-l user] [-a] host-name [port]\r\n", cmd);
3521ef
+    free(user);
3521ef
 	return 0;
3521ef
     }
3521ef
     if (hostp == 0)
3521ef
--- a/telnetd/utility.c
3521ef
+++ b/telnetd/utility.c
3521ef
@@ -68,8 +68,10 @@ output_data(const char *format, ...)
3521ef
 	char *buf;
3521ef
 
3521ef
 	va_start(args, format);
3521ef
-	if ((len = vasprintf(&buf, format, args)) == -1)
3521ef
+	if ((len = vasprintf(&buf, format, args)) == -1) {
3521ef
+		va_end(args);
3521ef
 		return -1;
3521ef
+	}
3521ef
 	output_datalen(buf, len);
3521ef
 	va_end(args);
3521ef
 	free(buf);