f3cfdd
commit 47cab810bb7ea315a2dec23c2f61e7ba74515b82
f3cfdd
Author: Martin Cermak <mcermak@redhat.com>
f3cfdd
Date:   Fri Dec 16 16:08:20 2022 -0500
f3cfdd
f3cfdd
    tapset: nfs.proc.commit_done compilation on some kernels
f3cfdd
    
f3cfdd
    Correct:
f3cfdd
    9.0 Server x86_64 # stap -vp3 nfs.proc.commit_done.stp
f3cfdd
    
f3cfdd
    Pass 1: parsed user script and 482 library scripts using 108088virt/88468res/12460shr/75476data kb, in 190usr/60sys/501real ms.
f3cfdd
    semantic error: invalid access '->task' vs 'void*': operator '->' at /usr/share/systemtap/tapset/linux/nfs_proc.stpm:16:21
f3cfdd
            source:         ( get_ip(&@nfs_data->task) )
f3cfdd
                                               ^
f3cfdd
            in expansion of macro: operator '@_nfs_data_server_ip' at /usr/share/systemtap/tapset/linux/nfs_proc.stp:1421:15
f3cfdd
            source:                 server_ip = @_nfs_data_server_ip($task->tk_calldata)
f3cfdd
                                                ^
f3cfdd
f3cfdd
diff --git a/tapset/linux/nfs_proc.stp b/tapset/linux/nfs_proc.stp
f3cfdd
index 9b1f65f5f..4413384f9 100644
f3cfdd
--- a/tapset/linux/nfs_proc.stp
f3cfdd
+++ b/tapset/linux/nfs_proc.stp
f3cfdd
@@ -1442,10 +1442,11 @@ probe nfs.proc3.commit_done = kernel.function("nfs3_commit_done") !,
f3cfdd
 		valid = @_nfs_data_valid($data)
f3cfdd
 	}
f3cfdd
 	else {
f3cfdd
-		server_ip = @_nfs_data_server_ip($task->tk_calldata)
f3cfdd
-		prot = @_nfs_data_prot($task->tk_calldata)
f3cfdd
-		count = @_nfs_data_res_count($task->tk_calldata)
f3cfdd
-		valid = @_nfs_data_valid($task->tk_calldata)
f3cfdd
+                _tk_calldata=@choose_defined($task->tk_calldata, @cast($task, "rpc_task", "kernel:nfs")->tk_calldata)
f3cfdd
+                server_ip = @_nfs_data_server_ip(_tk_calldata)
f3cfdd
+                prot = @_nfs_data_prot(_tk_calldata)
f3cfdd
+                count = @_nfs_data_res_count(_tk_calldata)
f3cfdd
+                valid = @_nfs_data_valid(_tk_calldata)
f3cfdd
 	}
f3cfdd
 	timestamp = 0
f3cfdd
 	version = 3
f3cfdd
diff --git a/tapset/linux/nfs_proc.stpm b/tapset/linux/nfs_proc.stpm
f3cfdd
index 8576c0f33..4fe40b2a5 100644
f3cfdd
--- a/tapset/linux/nfs_proc.stpm
f3cfdd
+++ b/tapset/linux/nfs_proc.stpm
f3cfdd
@@ -13,7 +13,7 @@
f3cfdd
 
f3cfdd
 @define _nfs_data_server_ip(nfs_data)
f3cfdd
 %(
f3cfdd
-	( get_ip(&@nfs_data->task) )
f3cfdd
+	( get_ip(@choose_defined(&@nfs_data->task, &@cast(@nfs_data, "nfs_commit_data", "kernel:nfs")->task)) )
f3cfdd
 %)
f3cfdd
 
f3cfdd
 @define _nfs_data_prot(nfs_data)