|
 |
e4e640 |
From 6adc7dbeccecff18357751b9eecfa232ee8a8172 Mon Sep 17 00:00:00 2001
|
|
|
e4e640 |
From: Serhei Makarov <smakarov@redhat.com>
|
|
|
e4e640 |
Date: Tue, 13 Nov 2018 11:42:46 -0500
|
|
|
e4e640 |
Subject: [PATCH 29/32] PR23860 bpf_interpret() :: NEG should not fall through
|
|
|
e4e640 |
to DIV
|
|
|
e4e640 |
|
|
|
e4e640 |
---
|
|
|
e4e640 |
stapbpf/bpfinterp.cxx | 26 ++++++++++++++++++--------
|
|
|
e4e640 |
1 file changed, 18 insertions(+), 8 deletions(-)
|
|
|
e4e640 |
|
|
|
e4e640 |
diff --git a/stapbpf/bpfinterp.cxx b/stapbpf/bpfinterp.cxx
|
|
|
e4e640 |
index 13ac8ee71..2a90c24c9 100644
|
|
|
e4e640 |
--- a/stapbpf/bpfinterp.cxx
|
|
|
e4e640 |
+++ b/stapbpf/bpfinterp.cxx
|
|
|
e4e640 |
@@ -254,18 +254,23 @@ bpf_interpret(size_t ninsns, const struct bpf_insn insns[],
|
|
|
e4e640 |
case BPF_ALU64 | BPF_MOV | BPF_K: dr = s1; break;
|
|
|
e4e640 |
case BPF_ALU64 | BPF_ARSH | BPF_X:
|
|
|
e4e640 |
case BPF_ALU64 | BPF_ARSH | BPF_K: dr = (int64_t)dr >> s1; break;
|
|
|
e4e640 |
- case BPF_ALU64 | BPF_NEG: dr = -sr;
|
|
|
e4e640 |
- /* Fallthrough */
|
|
|
e4e640 |
+ case BPF_ALU64 | BPF_NEG: dr = -sr; break;
|
|
|
e4e640 |
case BPF_ALU64 | BPF_DIV | BPF_X:
|
|
|
e4e640 |
case BPF_ALU64 | BPF_DIV | BPF_K:
|
|
|
e4e640 |
if (s1 == 0)
|
|
|
e4e640 |
- return 0;
|
|
|
e4e640 |
+ {
|
|
|
e4e640 |
+ // TODO: Signal a proper error.
|
|
|
e4e640 |
+ return 0;
|
|
|
e4e640 |
+ }
|
|
|
e4e640 |
dr /= s1;
|
|
|
e4e640 |
break;
|
|
|
e4e640 |
case BPF_ALU64 | BPF_MOD | BPF_X:
|
|
|
e4e640 |
case BPF_ALU64 | BPF_MOD | BPF_K:
|
|
|
e4e640 |
if (s1 == 0)
|
|
|
e4e640 |
- return 0;
|
|
|
e4e640 |
+ {
|
|
|
e4e640 |
+ // TODO: Signal a proper error.
|
|
|
e4e640 |
+ return 0;
|
|
|
e4e640 |
+ }
|
|
|
e4e640 |
dr %= s1;
|
|
|
e4e640 |
break;
|
|
|
e4e640 |
|
|
|
e4e640 |
@@ -289,18 +294,23 @@ bpf_interpret(size_t ninsns, const struct bpf_insn insns[],
|
|
|
e4e640 |
case BPF_ALU | BPF_MOV | BPF_K: dr = (uint32_t)s1; break;
|
|
|
e4e640 |
case BPF_ALU | BPF_ARSH | BPF_X:
|
|
|
e4e640 |
case BPF_ALU | BPF_ARSH | BPF_K: dr = (int32_t)dr >> s1; break;
|
|
|
e4e640 |
- case BPF_ALU | BPF_NEG: dr = -(uint32_t)sr;
|
|
|
e4e640 |
- /* Fallthrough */
|
|
|
e4e640 |
+ case BPF_ALU | BPF_NEG: dr = -(uint32_t)sr; break;
|
|
|
e4e640 |
case BPF_ALU | BPF_DIV | BPF_X:
|
|
|
e4e640 |
case BPF_ALU | BPF_DIV | BPF_K:
|
|
|
e4e640 |
if ((uint32_t)s1 == 0)
|
|
|
e4e640 |
- return 0;
|
|
|
e4e640 |
+ {
|
|
|
e4e640 |
+ // TODO: Signal a proper error.
|
|
|
e4e640 |
+ return 0;
|
|
|
e4e640 |
+ }
|
|
|
e4e640 |
dr = (uint32_t)dr / (uint32_t)s1;
|
|
|
e4e640 |
break;
|
|
|
e4e640 |
case BPF_ALU | BPF_MOD | BPF_X:
|
|
|
e4e640 |
case BPF_ALU | BPF_MOD | BPF_K:
|
|
|
e4e640 |
if ((uint32_t)s1 == 0)
|
|
|
e4e640 |
- return 0;
|
|
|
e4e640 |
+ {
|
|
|
e4e640 |
+ // TODO: Signal a proper error.
|
|
|
e4e640 |
+ return 0;
|
|
|
e4e640 |
+ }
|
|
|
e4e640 |
dr = (uint32_t)dr % (uint32_t)s1;
|
|
|
e4e640 |
break;
|
|
|
e4e640 |
|
|
|
e4e640 |
--
|
|
|
e4e640 |
2.14.5
|
|
|
e4e640 |
|