From 86be3e1e6558f4e7e20c537e644656eb6f37b7d0 Mon Sep 17 00:00:00 2001 From: Thomas Hindoe Paaboel Andersen <phomes@gmail.com> Date: Sun, 14 Sep 2014 22:06:37 +0200 Subject: [PATCH] sd-dhcp: fix test of magic cookie The magic cookie is set in dhcp_message_init. Test the magic cookie value intead of writing the last 3/4 of it directly. Found with Coverity. Fixes: CID#1237732 CID#1237734 CID#1237735 --- src/libsystemd-network/test-dhcp-option.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libsystemd-network/test-dhcp-option.c b/src/libsystemd-network/test-dhcp-option.c index 92c58e0d58..7a0fac8d33 100644 --- a/src/libsystemd-network/test-dhcp-option.c +++ b/src/libsystemd-network/test-dhcp-option.c @@ -100,9 +100,9 @@ static void test_message_init(void) magic = (uint8_t*)&message->magic; assert_se(magic[0] == 99); - assert_se(magic[1] = 130); - assert_se(magic[2] = 83); - assert_se(magic[3] = 99); + assert_se(magic[1] == 130); + assert_se(magic[2] == 83); + assert_se(magic[3] == 99); assert_se(dhcp_option_parse(message, len, NULL, NULL) >= 0); }