984f77
From c20e06c1c0319e3759a11bf9051a8041898f79b2 Mon Sep 17 00:00:00 2001
984f77
From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= <zbyszek@in.waw.pl>
984f77
Date: Sun, 7 Mar 2021 12:08:06 +0100
984f77
Subject: [PATCH] journal-remote: check return value from
984f77
 MHD_add_response_header
984f77
984f77
Sadly, the API does not allow us to distinguish oom from invalid settings.
984f77
If the call fails, let's assume oom happened.
984f77
984f77
Coverity CID#1444714.
984f77
984f77
(cherry picked from commit 60d9c4f3b972ce70dfadc0a3f1a478a056c2ea7a)
984f77
984f77
Resolves: #2051981
984f77
---
984f77
 src/journal-remote/journal-gatewayd.c | 22 ++++++++++++++++------
984f77
 src/journal-remote/microhttpd-util.c  |  3 ++-
984f77
 2 files changed, 18 insertions(+), 7 deletions(-)
984f77
984f77
diff --git a/src/journal-remote/journal-gatewayd.c b/src/journal-remote/journal-gatewayd.c
984f77
index 3a167ab890..54446ff7b5 100644
984f77
--- a/src/journal-remote/journal-gatewayd.c
984f77
+++ b/src/journal-remote/journal-gatewayd.c
984f77
@@ -492,7 +492,9 @@ static int request_handler_entries(
984f77
         if (!response)
984f77
                 return respond_oom(connection);
984f77
 
984f77
-        MHD_add_response_header(response, "Content-Type", mime_types[m->mode]);
984f77
+        if (MHD_add_response_header(response, "Content-Type", mime_types[m->mode]) == MHD_NO)
984f77
+                return respond_oom(connection);
984f77
+
984f77
         return MHD_queue_response(connection, MHD_HTTP_OK, response);
984f77
 }
984f77
 
984f77
@@ -627,7 +629,9 @@ static int request_handler_fields(
984f77
         if (!response)
984f77
                 return respond_oom(connection);
984f77
 
984f77
-        MHD_add_response_header(response, "Content-Type", mime_types[m->mode == OUTPUT_JSON ? OUTPUT_JSON : OUTPUT_SHORT]);
984f77
+        if (MHD_add_response_header(response, "Content-Type", mime_types[m->mode == OUTPUT_JSON ? OUTPUT_JSON : OUTPUT_SHORT]) == MHD_NO)
984f77
+                return respond_oom(connection);
984f77
+
984f77
         return MHD_queue_response(connection, MHD_HTTP_OK, response);
984f77
 }
984f77
 
984f77
@@ -650,8 +654,10 @@ static int request_handler_redirect(
984f77
                 return respond_oom(connection);
984f77
         }
984f77
 
984f77
-        MHD_add_response_header(response, "Content-Type", "text/html");
984f77
-        MHD_add_response_header(response, "Location", target);
984f77
+        if (MHD_add_response_header(response, "Content-Type", "text/html") == MHD_NO ||
984f77
+            MHD_add_response_header(response, "Location", target) == MHD_NO)
984f77
+                return respond_oom(connection);
984f77
+
984f77
         return MHD_queue_response(connection, MHD_HTTP_MOVED_PERMANENTLY, response);
984f77
 }
984f77
 
984f77
@@ -680,7 +686,9 @@ static int request_handler_file(
984f77
                 return respond_oom(connection);
984f77
         TAKE_FD(fd);
984f77
 
984f77
-        MHD_add_response_header(response, "Content-Type", mime_type);
984f77
+        if (MHD_add_response_header(response, "Content-Type", mime_type) == MHD_NO)
984f77
+                return respond_oom(connection);
984f77
+
984f77
         return MHD_queue_response(connection, MHD_HTTP_OK, response);
984f77
 }
984f77
 
984f77
@@ -781,7 +789,9 @@ static int request_handler_machine(
984f77
                 return respond_oom(connection);
984f77
         TAKE_PTR(json);
984f77
 
984f77
-        MHD_add_response_header(response, "Content-Type", "application/json");
984f77
+        if (MHD_add_response_header(response, "Content-Type", "application/json") == MHD_NO)
984f77
+                return respond_oom(connection);
984f77
+
984f77
         return MHD_queue_response(connection, MHD_HTTP_OK, response);
984f77
 }
984f77
 
984f77
diff --git a/src/journal-remote/microhttpd-util.c b/src/journal-remote/microhttpd-util.c
984f77
index 2ae5172fe9..fdfeaeb2f5 100644
984f77
--- a/src/journal-remote/microhttpd-util.c
984f77
+++ b/src/journal-remote/microhttpd-util.c
984f77
@@ -40,7 +40,8 @@ static int mhd_respond_internal(struct MHD_Connection *connection,
984f77
                 return MHD_NO;
984f77
 
984f77
         log_debug("Queueing response %u: %s", code, buffer);
984f77
-        MHD_add_response_header(response, "Content-Type", "text/plain");
984f77
+        if (MHD_add_response_header(response, "Content-Type", "text/plain") == MHD_NO)
984f77
+                return MHD_NO;
984f77
         return MHD_queue_response(connection, code, response);
984f77
 }
984f77