|
 |
803fb7 |
From 93c5087eed9abf8012dc5b0ccd2dd7ead1323899 Mon Sep 17 00:00:00 2001
|
|
|
803fb7 |
From: Franck Bui <fbui@suse.com>
|
|
|
803fb7 |
Date: Thu, 29 Sep 2016 19:44:34 +0200
|
|
|
803fb7 |
Subject: [PATCH] pid1: don't return any error in manager_dispatch_notify_fd()
|
|
|
803fb7 |
(#4240)
|
|
|
803fb7 |
|
|
|
803fb7 |
If manager_dispatch_notify_fd() fails and returns an error then the handling of
|
|
|
803fb7 |
service notifications will be disabled entirely leading to a compromised system.
|
|
|
803fb7 |
|
|
|
803fb7 |
For example pid1 won't be able to receive the WATCHDOG messages anymore and
|
|
|
803fb7 |
will kill all services supposed to send such messages.
|
|
|
803fb7 |
Cherry-picked from: 9987750e7a4c62e0eb8473603150596ba7c3a015
|
|
|
803fb7 |
Resolves: #1380259
|
|
|
803fb7 |
---
|
|
|
803fb7 |
src/core/manager.c | 13 +++++++++----
|
|
|
803fb7 |
1 file changed, 9 insertions(+), 4 deletions(-)
|
|
|
803fb7 |
|
|
|
803fb7 |
diff --git a/src/core/manager.c b/src/core/manager.c
|
|
|
803fb7 |
index 689b26615..ed8105955 100644
|
|
|
803fb7 |
--- a/src/core/manager.c
|
|
|
803fb7 |
+++ b/src/core/manager.c
|
|
|
803fb7 |
@@ -1673,10 +1673,14 @@ static int manager_dispatch_notify_fd(sd_event_source *source, int fd, uint32_t
|
|
|
803fb7 |
|
|
|
803fb7 |
n = recvmsg(m->notify_fd, &msghdr, MSG_DONTWAIT|MSG_CMSG_CLOEXEC);
|
|
|
803fb7 |
if (n < 0) {
|
|
|
803fb7 |
- if (errno == EAGAIN || errno == EINTR)
|
|
|
803fb7 |
- return 0;
|
|
|
803fb7 |
+ if (!IN_SET(errno, EAGAIN, EINTR))
|
|
|
803fb7 |
+ log_error("Failed to receive notification message: %m");
|
|
|
803fb7 |
|
|
|
803fb7 |
- return -errno;
|
|
|
803fb7 |
+ /* It's not an option to return an error here since it
|
|
|
803fb7 |
+ * would disable the notification handler entirely. Services
|
|
|
803fb7 |
+ * wouldn't be able to send the WATCHDOG message for
|
|
|
803fb7 |
+ * example... */
|
|
|
803fb7 |
+ return 0;
|
|
|
803fb7 |
}
|
|
|
803fb7 |
if (n == 0) {
|
|
|
803fb7 |
log_debug("Got zero-length notification message. Ignoring.");
|
|
|
803fb7 |
@@ -1703,7 +1707,8 @@ static int manager_dispatch_notify_fd(sd_event_source *source, int fd, uint32_t
|
|
|
803fb7 |
r = fdset_new_array(&fds, fd_array, n_fds);
|
|
|
803fb7 |
if (r < 0) {
|
|
|
803fb7 |
close_many(fd_array, n_fds);
|
|
|
803fb7 |
- return log_oom();
|
|
|
803fb7 |
+ log_oom();
|
|
|
803fb7 |
+ return 0;
|
|
|
803fb7 |
}
|
|
|
803fb7 |
}
|
|
|
803fb7 |
|