923a60
From 9b33863a2cfa31bbe57bab685776b64731f528f1 Mon Sep 17 00:00:00 2001
923a60
From: Lukas Nykryn <lnykryn@redhat.com>
923a60
Date: Wed, 30 Mar 2016 13:49:50 +0200
923a60
Subject: [PATCH] core: improve error message when starting template without
923a60
 instance
923a60
923a60
Cherry-picked from: 5d512d54429aa9d2f4a0ca215bb2e982db720d6b
923a60
Resolves: #1142369
923a60
---
923a60
 src/core/manager.c | 6 +++++-
923a60
 1 file changed, 5 insertions(+), 1 deletion(-)
923a60
923a60
diff --git a/src/core/manager.c b/src/core/manager.c
923a60
index bde17ce0be..bb5050303c 100644
923a60
--- a/src/core/manager.c
923a60
+++ b/src/core/manager.c
923a60
@@ -1328,8 +1328,12 @@ int manager_load_unit_prepare(
923a60
 
923a60
         t = unit_name_to_type(name);
923a60
 
923a60
-        if (t == _UNIT_TYPE_INVALID || !unit_name_is_valid(name, UNIT_NAME_PLAIN|UNIT_NAME_INSTANCE))
923a60
+        if (t == _UNIT_TYPE_INVALID || !unit_name_is_valid(name, UNIT_NAME_PLAIN|UNIT_NAME_INSTANCE)) {
923a60
+                if (unit_name_is_valid(name, UNIT_NAME_TEMPLATE))
923a60
+                        return sd_bus_error_setf(e, SD_BUS_ERROR_INVALID_ARGS, "Unit name %s is missing the instance name.", name);
923a60
+
923a60
                 return sd_bus_error_setf(e, SD_BUS_ERROR_INVALID_ARGS, "Unit name %s is not valid.", name);
923a60
+        }
923a60
 
923a60
         ret = manager_get_unit(m, name);
923a60
         if (ret) {