|
 |
2aacef |
From ae1806eea8c688c6561b5f7dcbaa6f682233b73e Mon Sep 17 00:00:00 2001
|
|
|
2aacef |
From: Lennart Poettering <lennart@poettering.net>
|
|
|
2aacef |
Date: Mon, 16 Jan 2023 14:16:14 +0100
|
|
|
2aacef |
Subject: [PATCH] busctl: simplify peeking the type
|
|
|
2aacef |
|
|
|
2aacef |
let's peek the type before we enter the variant, not after, so that we
|
|
|
2aacef |
can reuse it as-is, instead having to recombine it later.
|
|
|
2aacef |
|
|
|
2aacef |
Follow-up for: #26049
|
|
|
2aacef |
|
|
|
2aacef |
(cherry picked from commit ec56edf55c26ed2c65cf8e86b81ab0b516c94dd9)
|
|
|
2aacef |
|
|
|
2aacef |
Related: #2138081
|
|
|
2aacef |
---
|
|
|
2aacef |
src/busctl/busctl.c | 30 ++++++++++--------------------
|
|
|
2aacef |
1 file changed, 10 insertions(+), 20 deletions(-)
|
|
|
2aacef |
|
|
|
2aacef |
diff --git a/src/busctl/busctl.c b/src/busctl/busctl.c
|
|
|
2aacef |
index cc2d0e3458..901b0e15f6 100644
|
|
|
2aacef |
--- a/src/busctl/busctl.c
|
|
|
2aacef |
+++ b/src/busctl/busctl.c
|
|
|
2aacef |
@@ -1021,17 +1021,16 @@ static int introspect(int argc, char **argv, void *userdata) {
|
|
|
2aacef |
return bus_log_parse_error(r);
|
|
|
2aacef |
|
|
|
2aacef |
for (;;) {
|
|
|
2aacef |
- Member *z;
|
|
|
2aacef |
- _cleanup_free_ char *buf = NULL, *signature = NULL;
|
|
|
2aacef |
_cleanup_fclose_ FILE *mf = NULL;
|
|
|
2aacef |
- size_t sz = 0;
|
|
|
2aacef |
+ _cleanup_free_ char *buf = NULL;
|
|
|
2aacef |
const char *name, *contents;
|
|
|
2aacef |
+ size_t sz = 0;
|
|
|
2aacef |
+ Member *z;
|
|
|
2aacef |
char type;
|
|
|
2aacef |
|
|
|
2aacef |
r = sd_bus_message_enter_container(reply, 'e', "sv");
|
|
|
2aacef |
if (r < 0)
|
|
|
2aacef |
return bus_log_parse_error(r);
|
|
|
2aacef |
-
|
|
|
2aacef |
if (r == 0)
|
|
|
2aacef |
break;
|
|
|
2aacef |
|
|
|
2aacef |
@@ -1039,24 +1038,15 @@ static int introspect(int argc, char **argv, void *userdata) {
|
|
|
2aacef |
if (r < 0)
|
|
|
2aacef |
return bus_log_parse_error(r);
|
|
|
2aacef |
|
|
|
2aacef |
- r = sd_bus_message_enter_container(reply, 'v', NULL);
|
|
|
2aacef |
+ r = sd_bus_message_peek_type(reply, &type, &contents);
|
|
|
2aacef |
if (r < 0)
|
|
|
2aacef |
return bus_log_parse_error(r);
|
|
|
2aacef |
+ if (type != 'v')
|
|
|
2aacef |
+ return bus_log_parse_error(EINVAL);
|
|
|
2aacef |
|
|
|
2aacef |
- r = sd_bus_message_peek_type(reply, &type, &contents);
|
|
|
2aacef |
- if (r <= 0)
|
|
|
2aacef |
- return bus_log_parse_error(r == 0 ? EINVAL : r);
|
|
|
2aacef |
-
|
|
|
2aacef |
- if (type == SD_BUS_TYPE_STRUCT_BEGIN)
|
|
|
2aacef |
- signature = strjoin(CHAR_TO_STR(SD_BUS_TYPE_STRUCT_BEGIN), contents, CHAR_TO_STR(SD_BUS_TYPE_STRUCT_END));
|
|
|
2aacef |
- else if (type == SD_BUS_TYPE_DICT_ENTRY_BEGIN)
|
|
|
2aacef |
- signature = strjoin(CHAR_TO_STR(SD_BUS_TYPE_DICT_ENTRY_BEGIN), contents, CHAR_TO_STR(SD_BUS_TYPE_DICT_ENTRY_END));
|
|
|
2aacef |
- else if (contents)
|
|
|
2aacef |
- signature = strjoin(CHAR_TO_STR(type), contents);
|
|
|
2aacef |
- else
|
|
|
2aacef |
- signature = strdup(CHAR_TO_STR(type));
|
|
|
2aacef |
- if (!signature)
|
|
|
2aacef |
- return log_oom();
|
|
|
2aacef |
+ r = sd_bus_message_enter_container(reply, 'v', contents);
|
|
|
2aacef |
+ if (r < 0)
|
|
|
2aacef |
+ return bus_log_parse_error(r);
|
|
|
2aacef |
|
|
|
2aacef |
mf = open_memstream_unlocked(&buf, &sz);
|
|
|
2aacef |
if (!mf)
|
|
|
2aacef |
@@ -1071,7 +1061,7 @@ static int introspect(int argc, char **argv, void *userdata) {
|
|
|
2aacef |
z = set_get(members, &((Member) {
|
|
|
2aacef |
.type = "property",
|
|
|
2aacef |
.interface = m->interface,
|
|
|
2aacef |
- .signature = signature,
|
|
|
2aacef |
+ .signature = (char*) contents,
|
|
|
2aacef |
.name = (char*) name }));
|
|
|
2aacef |
if (z)
|
|
|
2aacef |
free_and_replace(z->value, buf);
|