4bff0a
From b63440ad69581bad39a2eda7ab449f8a3f901c4e Mon Sep 17 00:00:00 2001
4bff0a
From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= <zbyszek@in.waw.pl>
4bff0a
Date: Sat, 11 Aug 2018 11:43:09 +0200
4bff0a
Subject: [PATCH] bus-message: return -EBADMSG not -EINVAL on invalid !gvariant
4bff0a
 messages
4bff0a
4bff0a
(cherry picked from commit d831fb6f2bde829f9309aea242f502587662d1cc)
4bff0a
4bff0a
Resolves: #1696224
4bff0a
---
4bff0a
 src/libsystemd/sd-bus/bus-message.c               |   2 +-
4bff0a
 ...crash-4162a61a79e4c5a832ca5232212f75fa560a1f75 | Bin 0 -> 534 bytes
4bff0a
 2 files changed, 1 insertion(+), 1 deletion(-)
4bff0a
 create mode 100644 test/fuzz/fuzz-bus-message/crash-4162a61a79e4c5a832ca5232212f75fa560a1f75
4bff0a
4bff0a
diff --git a/src/libsystemd/sd-bus/bus-message.c b/src/libsystemd/sd-bus/bus-message.c
4bff0a
index e71d29f91d..613722a1a0 100644
4bff0a
--- a/src/libsystemd/sd-bus/bus-message.c
4bff0a
+++ b/src/libsystemd/sd-bus/bus-message.c
4bff0a
@@ -5047,7 +5047,7 @@ static int message_skip_fields(
4bff0a
 
4bff0a
                         *signature += l;
4bff0a
                 } else
4bff0a
-                        return -EINVAL;
4bff0a
+                        return -EBADMSG;
4bff0a
         }
4bff0a
 }
4bff0a
 
4bff0a
diff --git a/test/fuzz/fuzz-bus-message/crash-4162a61a79e4c5a832ca5232212f75fa560a1f75 b/test/fuzz/fuzz-bus-message/crash-4162a61a79e4c5a832ca5232212f75fa560a1f75
4bff0a
new file mode 100644
4bff0a
index 0000000000000000000000000000000000000000..5faf3308e7ac9c14d66422169e74ba8c05ad7319
4bff0a
GIT binary patch
4bff0a
literal 534
4bff0a
zcmd5(y$ZrW3{L#Rf|Cy*1sA)t;uE+zxcCZJw53qIqj#v2xH$UGez{(yI63-3NWO$5
4bff0a
zU+!uqzB5rdCwdYQvnEi=V1glA8o?i`lMy}upTQSe=c-Assy=GTr+lHv=4$0!Vy$EX
4bff0a
z_LzYX&1*Ob(W(=vPGKsxuBpzYaDn6&un5*x;uk`Xz?Yk^O%qgGJ(zd
4bff0a
sLgf|{Zt3X?n*AhyXRr3JnuD(2&Q!)fgDPC^-?wYdB
4bff0a
4bff0a
literal 0
4bff0a
HcmV?d00001
4bff0a