65878a
From 03269523c0f254846613ae3ae0183f4724e47ed8 Mon Sep 17 00:00:00 2001
65878a
From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= <zbyszek@in.waw.pl>
65878a
Date: Tue, 12 Nov 2013 22:05:16 -0500
65878a
Subject: [PATCH] random-seed: improve debugging messages a bit
65878a
65878a
---
65878a
 Makefile.am                   | 2 ++
65878a
 src/random-seed/random-seed.c | 8 ++++----
65878a
 2 files changed, 6 insertions(+), 4 deletions(-)
65878a
65878a
diff --git a/Makefile.am b/Makefile.am
65878a
index 0c11477..3103bac 100644
65878a
--- a/Makefile.am
65878a
+++ b/Makefile.am
65878a
@@ -159,6 +159,7 @@ AM_CPPFLAGS = \
65878a
 	-DSYSTEMD_TTY_ASK_PASSWORD_AGENT_BINARY_PATH=\"$(rootbindir)/systemd-tty-ask-password-agent\" \
65878a
 	-DSYSTEMD_STDIO_BRIDGE_BINARY_PATH=\"$(bindir)/systemd-stdio-bridge\" \
65878a
 	-DROOTPREFIX=\"$(rootprefix)\" \
65878a
+	-DRANDOM_SEED_DIR=\"$(localstatedir)/lib/systemd/\" \
65878a
 	-DRANDOM_SEED=\"$(localstatedir)/lib/systemd/random-seed\" \
65878a
 	-DSYSTEMD_CRYPTSETUP_PATH=\"$(rootlibexecdir)/systemd-cryptsetup\" \
65878a
 	-DSYSTEM_GENERATOR_PATH=\"$(systemgeneratordir)\" \
65878a
@@ -4227,6 +4228,7 @@ substitutions = \
65878a
        '|PACKAGE_VERSION=$(PACKAGE_VERSION)|' \
65878a
        '|PACKAGE_NAME=$(PACKAGE_NAME)|' \
65878a
        '|PACKAGE_URL=$(PACKAGE_URL)|' \
65878a
+       '|RANDOM_SEED_DIR=$(localstatedir)/lib/systemd/|' \
65878a
        '|RANDOM_SEED=$(localstatedir)/lib/systemd/random-seed|' \
65878a
        '|prefix=$(prefix)|' \
65878a
        '|exec_prefix=$(exec_prefix)|' \
65878a
diff --git a/src/random-seed/random-seed.c b/src/random-seed/random-seed.c
65878a
index afbd500..af79ecf 100644
65878a
--- a/src/random-seed/random-seed.c
65878a
+++ b/src/random-seed/random-seed.c
65878a
@@ -72,7 +72,7 @@ int main(int argc, char *argv[]) {
65878a
 
65878a
         r = mkdir_parents_label(RANDOM_SEED, 0755);
65878a
         if (r < 0) {
65878a
-                log_error("Failed to create parent directory of " RANDOM_SEED ": %s", strerror(-r));
65878a
+                log_error("Failed to create directory " RANDOM_SEED_DIR ": %s", strerror(-r));
65878a
                 goto finish;
65878a
         }
65878a
 
65878a
@@ -86,7 +86,7 @@ int main(int argc, char *argv[]) {
65878a
                 if (seed_fd < 0) {
65878a
                         seed_fd = open(RANDOM_SEED, O_RDONLY|O_CLOEXEC|O_NOCTTY);
65878a
                         if (seed_fd < 0) {
65878a
-                                log_error("Failed to open random seed: %m");
65878a
+                                log_error("Failed to open " RANDOM_SEED ": %m");
65878a
                                 r = -errno;
65878a
                                 goto finish;
65878a
                         }
65878a
@@ -106,7 +106,7 @@ int main(int argc, char *argv[]) {
65878a
                 if (k <= 0) {
65878a
 
65878a
                         if (r != 0)
65878a
-                                log_error("Failed to read seed file: %m");
65878a
+                                log_error("Failed to read seed from " RANDOM_SEED ": %m");
65878a
 
65878a
                         r = k == 0 ? -EIO : (int) k;
65878a
 
65878a
@@ -125,7 +125,7 @@ int main(int argc, char *argv[]) {
65878a
 
65878a
                 seed_fd = open(RANDOM_SEED, O_WRONLY|O_CLOEXEC|O_NOCTTY|O_CREAT, 0600);
65878a
                 if (seed_fd < 0) {
65878a
-                        log_error("Failed to open random seed: %m");
65878a
+                        log_error("Failed to open " RANDOM_SEED ": %m");
65878a
                         r = -errno;
65878a
                         goto finish;
65878a
                 }