|
Zbigniew Jędrzejewski-Szmek |
399a2a |
From 67ec035b3c192e71fb040959fe8d311d9c89edaa Mon Sep 17 00:00:00 2001
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
From: Tom Gundersen <teg@jklm.no>
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
Date: Wed, 4 Mar 2015 10:33:50 +0100
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
Subject: [PATCH] networkd: netdev - inform when we take over an existing
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
netdev
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
The crucial point here is that we will not change the settings of a netdev created by someone else
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
we simply use it as is and trust it was set up as intended.
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
This is confusing in the case of the pre-created netdev's (bond0 etc.), the solution should probably
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
be to simply make the kernel stop creating these devices as they are pretty useless.
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
(cherry picked from commit ff88a301e93cf1bddbaa7faa981f390a2a81a4bb)
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
---
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
src/network/networkd-netdev.c | 2 +-
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
diff --git a/src/network/networkd-netdev.c b/src/network/networkd-netdev.c
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
index 8119205dde..7d193d088e 100644
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
--- a/src/network/networkd-netdev.c
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
+++ b/src/network/networkd-netdev.c
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
@@ -261,7 +261,7 @@ static int netdev_create_handler(sd_rtnl *rtnl, sd_rtnl_message *m, void *userda
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
r = sd_rtnl_message_get_errno(m);
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
if (r == -EEXIST)
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
- log_netdev_debug(netdev, "netdev exists, using existing");
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
+ log_info_netdev(netdev, "netdev exists, using existing without changing its parameters");
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
else if (r < 0) {
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
log_warning_netdev(netdev, "netdev could not be created: %s", strerror(-r));
|
|
Zbigniew Jędrzejewski-Szmek |
399a2a |
netdev_drop(netdev);
|