Zbigniew Jędrzejewski-Szmek 62fe94
From 03664a62914782dbd8f069bbcf8a0c8ca1df7010 Mon Sep 17 00:00:00 2001
Zbigniew Jędrzejewski-Szmek 62fe94
From: Lukas Nykryn <lnykryn@redhat.com>
Zbigniew Jędrzejewski-Szmek 62fe94
Date: Wed, 20 Aug 2014 14:34:23 +0200
Zbigniew Jędrzejewski-Szmek 62fe94
Subject: [PATCH] resolved-dns-rr: fix typo
Zbigniew Jędrzejewski-Szmek 62fe94
Zbigniew Jędrzejewski-Szmek 62fe94
a->rrsig.type_covered != a->rrsig.type_covered" is always false
Zbigniew Jędrzejewski-Szmek 62fe94
regardless of the values of its operands because those operands are identical.
Zbigniew Jędrzejewski-Szmek 62fe94
---
Zbigniew Jędrzejewski-Szmek 62fe94
 src/resolve/resolved-dns-rr.c | 14 +++++++-------
Zbigniew Jędrzejewski-Szmek 62fe94
 1 file changed, 7 insertions(+), 7 deletions(-)
Zbigniew Jędrzejewski-Szmek 62fe94
Zbigniew Jędrzejewski-Szmek 62fe94
diff --git a/src/resolve/resolved-dns-rr.c b/src/resolve/resolved-dns-rr.c
Zbigniew Jędrzejewski-Szmek 62fe94
index c792deda47..c5f7cb931e 100644
Zbigniew Jędrzejewski-Szmek 62fe94
--- a/src/resolve/resolved-dns-rr.c
Zbigniew Jędrzejewski-Szmek 62fe94
+++ b/src/resolve/resolved-dns-rr.c
Zbigniew Jędrzejewski-Szmek 62fe94
@@ -425,13 +425,13 @@ int dns_resource_record_equal(const DnsResourceRecord *a, const DnsResourceRecor
Zbigniew Jędrzejewski-Szmek 62fe94
 
Zbigniew Jędrzejewski-Szmek 62fe94
         case DNS_TYPE_RRSIG:
Zbigniew Jędrzejewski-Szmek 62fe94
                 /* do the fast comparisons first */
Zbigniew Jędrzejewski-Szmek 62fe94
-                if (a->rrsig.type_covered != a->rrsig.type_covered ||
Zbigniew Jędrzejewski-Szmek 62fe94
-                    a->rrsig.algorithm != a->rrsig.algorithm ||
Zbigniew Jędrzejewski-Szmek 62fe94
-                    a->rrsig.labels != a->rrsig.labels ||
Zbigniew Jędrzejewski-Szmek 62fe94
-                    a->rrsig.original_ttl != a->rrsig.original_ttl ||
Zbigniew Jędrzejewski-Szmek 62fe94
-                    a->rrsig.expiration != a->rrsig.expiration ||
Zbigniew Jędrzejewski-Szmek 62fe94
-                    a->rrsig.inception != a->rrsig.inception ||
Zbigniew Jędrzejewski-Szmek 62fe94
-                    a->rrsig.key_tag != a->rrsig.key_tag ||
Zbigniew Jędrzejewski-Szmek 62fe94
+                if (a->rrsig.type_covered != b->rrsig.type_covered ||
Zbigniew Jędrzejewski-Szmek 62fe94
+                    a->rrsig.algorithm != b->rrsig.algorithm ||
Zbigniew Jędrzejewski-Szmek 62fe94
+                    a->rrsig.labels != b->rrsig.labels ||
Zbigniew Jędrzejewski-Szmek 62fe94
+                    a->rrsig.original_ttl != b->rrsig.original_ttl ||
Zbigniew Jędrzejewski-Szmek 62fe94
+                    a->rrsig.expiration != b->rrsig.expiration ||
Zbigniew Jędrzejewski-Szmek 62fe94
+                    a->rrsig.inception != b->rrsig.inception ||
Zbigniew Jędrzejewski-Szmek 62fe94
+                    a->rrsig.key_tag != b->rrsig.key_tag ||
Zbigniew Jędrzejewski-Szmek 62fe94
                     a->rrsig.signature_size != b->rrsig.signature_size ||
Zbigniew Jędrzejewski-Szmek 62fe94
                     memcmp(a->rrsig.signature, b->rrsig.signature, a->rrsig.signature_size) != 0)
Zbigniew Jędrzejewski-Szmek 62fe94
                         return false;