|
 |
c288c9 |
From f3964e0fa19e0c33470f37014ebcebf0b4253363 Mon Sep 17 00:00:00 2001
|
|
|
c288c9 |
From: Michal Sekletar <msekleta@redhat.com>
|
|
|
c288c9 |
Date: Fri, 30 Sep 2016 18:05:44 +0200
|
|
|
c288c9 |
Subject: [PATCH] sar: make buffers that hold timestamps bigger
|
|
|
c288c9 |
MIME-Version: 1.0
|
|
|
c288c9 |
Content-Type: text/plain; charset=UTF-8
|
|
|
c288c9 |
Content-Transfer-Encoding: 8bit
|
|
|
c288c9 |
|
|
|
c288c9 |
On systems that use Korean UTF-8 locale sar will not print timestamp
|
|
|
c288c9 |
because there is not enough space in the buffer.
|
|
|
c288c9 |
|
|
|
c288c9 |
I bumped buffer size to 64 bytes because I figured out that 32 bytes is
|
|
|
c288c9 |
still not enough to print out timestamp when using some glibc supported
|
|
|
c288c9 |
locales.
|
|
|
c288c9 |
|
|
|
c288c9 |
$ LC_TIME=ko_KR.UTF-8 ./sar 1 1
|
|
|
c288c9 |
|
|
|
c288c9 |
Before:
|
|
|
c288c9 |
Linux 4.7.2-201.fc24.x86_64 (morgoth.usersys.redhat.com) 2016년 09월 30일 _x86_64_ (4 CPU)
|
|
|
c288c9 |
|
|
|
c288c9 |
CPU %user %nice %system %iowait %steal %idle
|
|
|
c288c9 |
all 4.51 0.00 2.51 0.00 0.00 92.98
|
|
|
c288c9 |
Average: all 4.51 0.00 2.51 0.00 0.00 92.98
|
|
|
c288c9 |
|
|
|
c288c9 |
After:
|
|
|
c288c9 |
Linux 4.7.2-201.fc24.x86_64 (morgoth.usersys.redhat.com) 2016년 09월 30일 _x86_64_ (4 CPU)
|
|
|
c288c9 |
|
|
|
c288c9 |
18시 18분 36초 CPU %user %nice %system %iowait %steal %idle
|
|
|
c288c9 |
18시 18분 37초 all 3.76 0.00 2.26 0.00 0.00 93.98
|
|
|
c288c9 |
Average: all 3.76 0.00 2.26 0.00 0.00 93.98
|
|
|
c288c9 |
---
|
|
|
c288c9 |
sa.h | 2 +-
|
|
|
c288c9 |
sar.c | 4 ++--
|
|
|
c288c9 |
2 files changed, 3 insertions(+), 3 deletions(-)
|
|
|
c288c9 |
|
|
|
c288c9 |
diff --git a/sa.h b/sa.h
|
|
|
c288c9 |
index 54e7a4e..c11dbe9 100644
|
|
|
c288c9 |
--- a/sa.h
|
|
|
c288c9 |
+++ b/sa.h
|
|
|
c288c9 |
@@ -199,7 +199,7 @@
|
|
|
c288c9 |
#define NR_USB_PREALLOC 5
|
|
|
c288c9 |
|
|
|
c288c9 |
#define UTSNAME_LEN 65
|
|
|
c288c9 |
-#define TIMESTAMP_LEN 16
|
|
|
c288c9 |
+#define TIMESTAMP_LEN 64
|
|
|
c288c9 |
#define HEADER_LINE_LEN 512
|
|
|
c288c9 |
|
|
|
c288c9 |
/* Maximum number of args that can be passed to sadc */
|
|
|
c288c9 |
diff --git a/sar.c b/sar.c
|
|
|
c288c9 |
index e8ad83e..8dd998b 100644
|
|
|
c288c9 |
--- a/sar.c
|
|
|
c288c9 |
+++ b/sar.c
|
|
|
c288c9 |
@@ -469,10 +469,10 @@ int write_stats(int curr, int read_from_file, long *cnt, int use_tm_start,
|
|
|
c288c9 |
}
|
|
|
c288c9 |
|
|
|
c288c9 |
/* Set previous timestamp */
|
|
|
c288c9 |
- if (set_record_timestamp_string(!curr, timestamp[!curr], 16))
|
|
|
c288c9 |
+ if (set_record_timestamp_string(!curr, timestamp[!curr], TIMESTAMP_LEN))
|
|
|
c288c9 |
return 0;
|
|
|
c288c9 |
/* Set current timestamp */
|
|
|
c288c9 |
- if (set_record_timestamp_string(curr, timestamp[curr], 16))
|
|
|
c288c9 |
+ if (set_record_timestamp_string(curr, timestamp[curr], TIMESTAMP_LEN))
|
|
|
c288c9 |
return 0;
|
|
|
c288c9 |
|
|
|
c288c9 |
/* Check if we are beginning a new day */
|
|
|
c288c9 |
--
|
|
|
c288c9 |
2.9.3
|
|
|
c288c9 |
|