Blame SOURCES/sudo-1.8.23-legacy-group-processing.patch

683145
diff -up sudo-1.8.23/plugins/sudoers/cvtsudoers.c.legacy-group-processing sudo-1.8.23/plugins/sudoers/cvtsudoers.c
683145
--- sudo-1.8.23/plugins/sudoers/cvtsudoers.c.legacy-group-processing	2018-06-28 11:24:25.966475241 +0200
683145
+++ sudo-1.8.23/plugins/sudoers/cvtsudoers.c	2018-06-28 11:26:40.215025493 +0200
683145
@@ -321,6 +321,15 @@ main(int argc, char *argv[])
683145
 	sudo_fatalx("error: unhandled input %d", input_format);
683145
     }
683145
 
683145
+    /*
683145
+     * cvtsudoers group filtering doesn't work if def_match_group_by_gid
683145
+     * is set to true by default (at compile-time). It cannot be set to false
683145
+     * because cvtsudoers doesn't apply the parsed Defaults.
683145
+     *
683145
+     * Related: sudo-1.8.23-legacy-group-processing.patch
683145
+     */
683145
+    def_match_group_by_gid = def_legacy_group_processing = false;
683145
+
683145
     /* Apply filters. */
683145
     filter_userspecs(conf);
683145
     filter_defaults(conf);
683145
diff -up sudo-1.8.23/plugins/sudoers/defaults.c.legacy-group-processing sudo-1.8.23/plugins/sudoers/defaults.c
683145
--- sudo-1.8.23/plugins/sudoers/defaults.c.legacy-group-processing	2018-04-29 21:59:31.000000000 +0200
683145
+++ sudo-1.8.23/plugins/sudoers/defaults.c	2018-06-28 11:24:25.966475241 +0200
683145
@@ -87,6 +87,7 @@ static struct early_default early_defaul
683145
     { I_FQDN },
683145
 #endif
683145
     { I_MATCH_GROUP_BY_GID },
683145
+    { I_LEGACY_GROUP_PROCESSING },
683145
     { I_GROUP_PLUGIN },
683145
     { I_RUNAS_DEFAULT },
683145
     { I_SUDOERS_LOCALE },
683145
@@ -488,6 +489,8 @@ init_defaults(void)
683145
     }
683145
 
683145
     /* First initialize the flags. */
683145
+    def_legacy_group_processing = true;
683145
+    def_match_group_by_gid = true;
683145
 #ifdef LONG_OTP_PROMPT
683145
     def_long_otp_prompt = true;
683145
 #endif
683145
diff -up sudo-1.8.23/plugins/sudoers/def_data.c.legacy-group-processing sudo-1.8.23/plugins/sudoers/def_data.c
683145
--- sudo-1.8.23/plugins/sudoers/def_data.c.legacy-group-processing	2018-04-29 21:59:31.000000000 +0200
683145
+++ sudo-1.8.23/plugins/sudoers/def_data.c	2018-06-28 11:24:25.966475241 +0200
683145
@@ -494,6 +494,10 @@ struct sudo_defs_types sudo_defs_table[]
683145
 	N_("Ignore case when matching group names"),
683145
 	NULL,
683145
     }, {
683145
+	"legacy_group_processing", T_FLAG,
683145
+	N_("Don't pre-resolve all group names"),
683145
+	NULL,
683145
+    }, {
683145
 	NULL, 0, NULL
683145
     }
683145
 };
683145
diff -up sudo-1.8.23/plugins/sudoers/def_data.h.legacy-group-processing sudo-1.8.23/plugins/sudoers/def_data.h
683145
--- sudo-1.8.23/plugins/sudoers/def_data.h.legacy-group-processing	2018-04-29 21:59:31.000000000 +0200
683145
+++ sudo-1.8.23/plugins/sudoers/def_data.h	2018-06-28 11:24:25.967475238 +0200
683145
@@ -226,6 +226,8 @@
683145
 #define def_case_insensitive_user (sudo_defs_table[I_CASE_INSENSITIVE_USER].sd_un.flag)
683145
 #define I_CASE_INSENSITIVE_GROUP 113
683145
 #define def_case_insensitive_group (sudo_defs_table[I_CASE_INSENSITIVE_GROUP].sd_un.flag)
683145
+#define I_LEGACY_GROUP_PROCESSING 114
683145
+#define def_legacy_group_processing (sudo_defs_table[I_LEGACY_GROUP_PROCESSING].sd_un.flag)
683145
 
683145
 enum def_tuple {
683145
 	never,
683145
diff -up sudo-1.8.23/plugins/sudoers/def_data.in.legacy-group-processing sudo-1.8.23/plugins/sudoers/def_data.in
683145
--- sudo-1.8.23/plugins/sudoers/def_data.in.legacy-group-processing	2018-04-29 21:59:31.000000000 +0200
683145
+++ sudo-1.8.23/plugins/sudoers/def_data.in	2018-06-28 11:24:25.967475238 +0200
683145
@@ -357,3 +357,6 @@ case_insensitive_user
683145
 case_insensitive_group
683145
 	T_FLAG
683145
 	"Ignore case when matching group names"
683145
+legacy_group_processing
683145
+	T_FLAG
683145
+	"Don't pre-resolve all group names"
683145
diff -up sudo-1.8.23/plugins/sudoers/sudoers.c.legacy-group-processing sudo-1.8.23/plugins/sudoers/sudoers.c
683145
--- sudo-1.8.23/plugins/sudoers/sudoers.c.legacy-group-processing	2018-04-29 21:59:31.000000000 +0200
683145
+++ sudo-1.8.23/plugins/sudoers/sudoers.c	2018-06-28 11:24:25.967475238 +0200
683145
@@ -209,6 +209,10 @@ sudoers_policy_init(void *info, char * c
683145
     if (set_loginclass(runas_pw ? runas_pw : sudo_user.pw))
683145
 	ret = true;
683145
 
683145
+    if (!def_match_group_by_gid || !def_legacy_group_processing) {
683145
+        def_match_group_by_gid = false;
683145
+	def_legacy_group_processing = false;
683145
+    }
683145
 cleanup:
683145
     if (!restore_perms())
683145
 	ret = -1;