Blame SOURCES/sudo-1.8.23-legacy-group-processing.patch

0eb21d
diff -up ./plugins/sudoers/cvtsudoers.c.legacy-processing ./plugins/sudoers/cvtsudoers.c
3379fe
--- ./plugins/sudoers/cvtsudoers.c.legacy-processing	2019-10-28 13:28:52.000000000 +0100
3379fe
+++ ./plugins/sudoers/cvtsudoers.c	2019-10-30 13:32:43.309480623 +0100
3379fe
@@ -347,6 +347,15 @@ main(int argc, char *argv[])
0eb21d
 	sudo_fatalx("error: unhandled input %d", input_format);
0eb21d
     }
0eb21d
 
0eb21d
+    /*
0eb21d
+     * cvtsudoers group filtering doesn't work if def_match_group_by_gid
0eb21d
+     * is set to true by default (at compile-time). It cannot be set to false
0eb21d
+     * because cvtsudoers doesn't apply the parsed Defaults.
0eb21d
+     *
0eb21d
+     * Related: sudo-1.8.23-legacy-group-processing.patch
0eb21d
+     */
0eb21d
+    def_match_group_by_gid = def_legacy_group_processing = false;
0eb21d
+
0eb21d
     /* Apply filters. */
0eb21d
     filter_userspecs(&parsed_policy, conf);
0eb21d
     filter_defaults(&parsed_policy, conf);
0eb21d
diff -up ./plugins/sudoers/defaults.c.legacy-processing ./plugins/sudoers/defaults.c
3379fe
--- ./plugins/sudoers/defaults.c.legacy-processing	2019-10-28 13:28:52.000000000 +0100
3379fe
+++ ./plugins/sudoers/defaults.c	2019-10-30 13:32:43.309480623 +0100
3379fe
@@ -93,6 +93,7 @@ static struct early_default early_defaul
0eb21d
     { I_FQDN },
0eb21d
 #endif
0eb21d
     { I_MATCH_GROUP_BY_GID },
0eb21d
+    { I_LEGACY_GROUP_PROCESSING },
0eb21d
     { I_GROUP_PLUGIN },
0eb21d
     { I_RUNAS_DEFAULT },
0eb21d
     { I_SUDOERS_LOCALE },
3379fe
@@ -494,6 +495,8 @@ init_defaults(void)
0eb21d
     }
0eb21d
 
0eb21d
     /* First initialize the flags. */
0eb21d
+    def_legacy_group_processing = true;
0eb21d
+    def_match_group_by_gid = true;
0eb21d
 #ifdef LONG_OTP_PROMPT
0eb21d
     def_long_otp_prompt = true;
0eb21d
 #endif
0eb21d
diff -up ./plugins/sudoers/def_data.c.legacy-processing ./plugins/sudoers/def_data.c
3379fe
--- ./plugins/sudoers/def_data.c.legacy-processing	2019-10-30 13:32:43.309480623 +0100
3379fe
+++ ./plugins/sudoers/def_data.c	2019-10-30 13:37:25.914602825 +0100
3379fe
@@ -506,6 +506,10 @@ struct sudo_defs_types sudo_defs_table[]
3379fe
 	N_("Log when a command is denied by sudoers"),
0eb21d
 	NULL,
0eb21d
     }, {
0eb21d
+	"legacy_group_processing", T_FLAG,
0eb21d
+	N_("Don't pre-resolve all group names"),
0eb21d
+	NULL,
0eb21d
+    }, {
0eb21d
 	NULL, 0, NULL
0eb21d
     }
0eb21d
 };
0eb21d
diff -up ./plugins/sudoers/def_data.h.legacy-processing ./plugins/sudoers/def_data.h
3379fe
--- ./plugins/sudoers/def_data.h.legacy-processing	2019-10-30 13:32:43.310480638 +0100
3379fe
+++ ./plugins/sudoers/def_data.h	2019-10-30 13:40:59.651713757 +0100
3379fe
@@ -232,6 +232,8 @@
3379fe
 #define def_log_allowed         (sudo_defs_table[I_LOG_ALLOWED].sd_un.flag)
3379fe
 #define I_LOG_DENIED            116
3379fe
 #define def_log_denied          (sudo_defs_table[I_LOG_DENIED].sd_un.flag)
3379fe
+#define I_LEGACY_GROUP_PROCESSING 117
0eb21d
+#define def_legacy_group_processing (sudo_defs_table[I_LEGACY_GROUP_PROCESSING].sd_un.flag)
0eb21d
 
0eb21d
 enum def_tuple {
0eb21d
 	never,
0eb21d
diff -up ./plugins/sudoers/def_data.in.legacy-processing ./plugins/sudoers/def_data.in
3379fe
--- ./plugins/sudoers/def_data.in.legacy-processing	2019-10-30 13:32:43.310480638 +0100
3379fe
+++ ./plugins/sudoers/def_data.in	2019-10-30 13:42:20.915896239 +0100
3379fe
@@ -366,3 +366,6 @@ log_allowed
3379fe
 log_denied
0eb21d
 	T_FLAG
3379fe
 	"Log when a command is denied by sudoers"
0eb21d
+legacy_group_processing
0eb21d
+	T_FLAG
0eb21d
+	"Don't pre-resolve all group names"
0eb21d
diff -up ./plugins/sudoers/sudoers.c.legacy-processing ./plugins/sudoers/sudoers.c
3379fe
--- ./plugins/sudoers/sudoers.c.legacy-processing	2019-10-28 13:28:53.000000000 +0100
3379fe
+++ ./plugins/sudoers/sudoers.c	2019-10-30 13:32:43.310480638 +0100
3379fe
@@ -221,6 +221,10 @@ sudoers_policy_init(void *info, char * c
0eb21d
     if (set_loginclass(runas_pw ? runas_pw : sudo_user.pw))
0eb21d
 	ret = true;
0eb21d
 
0eb21d
+    if (!def_match_group_by_gid || !def_legacy_group_processing) {
0eb21d
+        def_match_group_by_gid = false;
0eb21d
+	def_legacy_group_processing = false;
0eb21d
+    }
0eb21d
 cleanup:
0eb21d
     if (!restore_perms())
0eb21d
 	ret = -1;