|
 |
270793 |
diff -up stunnel-5.48/src/file.c.coverity stunnel-5.48/src/file.c
|
|
|
270793 |
--- stunnel-5.48/src/file.c.coverity 2018-04-06 16:25:10.000000000 +0200
|
|
|
270793 |
+++ stunnel-5.48/src/file.c 2018-09-04 17:24:08.948928882 +0200
|
|
|
270793 |
@@ -120,7 +120,7 @@ DISK_FILE *file_open(char *name, FILE_MO
|
|
|
270793 |
return NULL;
|
|
|
270793 |
|
|
|
270793 |
/* setup df structure */
|
|
|
270793 |
- df=str_alloc(sizeof df);
|
|
|
270793 |
+ df=str_alloc(sizeof *df);
|
|
|
270793 |
df->fd=fd;
|
|
|
270793 |
return df;
|
|
|
270793 |
}
|
|
|
270793 |
diff -up stunnel-5.48/src/options.c.coverity stunnel-5.48/src/options.c
|
|
|
270793 |
--- stunnel-5.48/src/options.c.coverity 2018-09-04 17:24:08.946928836 +0200
|
|
|
270793 |
+++ stunnel-5.48/src/options.c 2018-09-04 18:47:03.135083884 +0200
|
|
|
270793 |
@@ -515,8 +515,7 @@ NOEXPORT int options_include(char *direc
|
|
|
270793 |
"%s/%s",
|
|
|
270793 |
#endif
|
|
|
270793 |
directory, namelist[i]->d_name);
|
|
|
270793 |
- stat(name, &sb);
|
|
|
270793 |
- if(S_ISREG(sb.st_mode))
|
|
|
270793 |
+ if(stat(name, &sb) == 0 && S_ISREG(sb.st_mode))
|
|
|
270793 |
err=options_file(name, CONF_FILE, section);
|
|
|
270793 |
else
|
|
|
270793 |
s_log(LOG_DEBUG, "\"%s\" is not a file", name);
|
|
|
270793 |
@@ -3773,6 +3772,7 @@ NOEXPORT PSK_KEYS *psk_dup(PSK_KEYS *src
|
|
|
270793 |
else
|
|
|
270793 |
head=curr;
|
|
|
270793 |
tail=curr;
|
|
|
270793 |
+ src=src->next;
|
|
|
270793 |
}
|
|
|
270793 |
return head;
|
|
|
270793 |
}
|
|
|
270793 |
diff -up stunnel-5.48/src/str.c.coverity stunnel-5.48/src/str.c
|
|
|
270793 |
--- stunnel-5.48/src/str.c.coverity 2018-07-02 23:30:10.000000000 +0200
|
|
|
270793 |
+++ stunnel-5.48/src/str.c 2018-09-04 17:24:08.949928906 +0200
|
|
|
270793 |
@@ -165,6 +165,7 @@ char *str_vprintf(const char *format, va
|
|
|
270793 |
for(;;) {
|
|
|
270793 |
va_copy(ap, start_ap);
|
|
|
270793 |
n=vsnprintf(p, size, format, ap);
|
|
|
270793 |
+ va_end(ap);
|
|
|
270793 |
if(n>-1 && n<(int)size)
|
|
|
270793 |
return p;
|
|
|
270793 |
if(n>-1) /* glibc 2.1 */
|
|
|
270793 |
diff -up stunnel-5.48/src/stunnel.c.coverity stunnel-5.48/src/stunnel.c
|
|
|
270793 |
--- stunnel-5.48/src/stunnel.c.coverity 2018-07-02 23:30:10.000000000 +0200
|
|
|
270793 |
+++ stunnel-5.48/src/stunnel.c 2018-09-04 17:24:08.949928906 +0200
|
|
|
270793 |
@@ -364,7 +364,6 @@ NOEXPORT int accept_connection(SERVICE_O
|
|
|
270793 |
#endif
|
|
|
270793 |
if(create_client(fd, s, alloc_client_session(opt, s, s))) {
|
|
|
270793 |
s_log(LOG_ERR, "Connection rejected: create_client failed");
|
|
|
270793 |
- closesocket(s);
|
|
|
270793 |
#ifndef USE_FORK
|
|
|
270793 |
service_free(opt);
|
|
|
270793 |
#endif
|