Blame SOURCES/0114-io_uring-Add-io_cqring_offset-flags.patch

d811e0
From c51b292b237214ccfcae5a84085f8d0a7e85c8ba Mon Sep 17 00:00:00 2001
d811e0
From: Chris Packham <chris.packham@alliedtelesis.co.nz>
d811e0
Date: Mon, 15 Jun 2020 22:01:26 +1200
d811e0
Subject: [PATCH 114/115] io_uring: Add io_cqring_offset flags
d811e0
d811e0
Add support for displaying struct io_cqring_offsets.flags introduced
d811e0
by Linux kernel commits v5.8-rc1~190^2~22 and v5.8-rc1~190^2~21.
d811e0
d811e0
* types/io_uring.h (struct_io_cqring_offsets): Replace resv array
d811e0
with flags, resv1, and resv2 fields.
d811e0
* xlat/uring_cqring_flags.in: New file.
d811e0
* configure.ac (AC_CHECK_MEMBERS): Check struct io_cqring_offsets.flags.
d811e0
* io_uring.c: Include "xlat/uring_cqring_flags.h".
d811e0
(SYS_FUNC(io_uring_setup)): Replace printing of the resv array
d811e0
of struct io_cqring_offsets with flags, resv1, and resv2 fields.
d811e0
* tests/io_uring_setup.c: Check it.
d811e0
d811e0
Co-authored-by: Dmitry V. Levin <ldv@altlinux.org>
d811e0
Resolves: https://github.com/strace/strace/issues/138
d811e0
---
d811e0
 configure.ac               |  1 +
d811e0
 io_uring.c                 | 11 +++++++----
d811e0
 tests/io_uring_setup.c     | 31 ++++++++++++++++++++++++++-----
d811e0
 types/io_uring.h           |  4 +++-
d811e0
 xlat/uring_cqring_flags.in |  1 +
d811e0
 5 files changed, 38 insertions(+), 10 deletions(-)
d811e0
 create mode 100644 xlat/uring_cqring_flags.in
d811e0
d811e0
Index: strace-5.7/configure.ac
d811e0
===================================================================
d811e0
--- strace-5.7.orig/configure.ac	2020-11-09 04:39:07.197892960 +0100
d811e0
+++ strace-5.7/configure.ac	2020-11-09 04:39:14.943826575 +0100
d811e0
@@ -481,6 +481,7 @@
d811e0
 
d811e0
 AC_CHECK_HEADERS([linux/io_uring.h], [
d811e0
 	AC_CHECK_MEMBERS(m4_normalize([
d811e0
+		struct io_cqring_offsets.flags,
d811e0
 		struct io_uring_params.features,
d811e0
 		struct io_uring_params.wq_fd,
d811e0
 		struct io_uring_params.resv
d811e0
Index: strace-5.7/io_uring.c
d811e0
===================================================================
d811e0
--- strace-5.7.orig/io_uring.c	2020-11-09 04:39:07.197892960 +0100
d811e0
+++ strace-5.7/io_uring.c	2020-11-09 04:39:14.943826575 +0100
d811e0
@@ -17,6 +17,7 @@
d811e0
 #include "xlat/uring_setup_flags.h"
d811e0
 #include "xlat/uring_enter_flags.h"
d811e0
 #include "xlat/uring_register_opcodes.h"
d811e0
+#include "xlat/uring_cqring_flags.h"
d811e0
 
d811e0
 #ifdef HAVE_STRUCT_IO_URING_PARAMS
d811e0
 # ifdef HAVE_STRUCT_IO_URING_PARAMS_RESV
d811e0
@@ -88,10 +89,12 @@
d811e0
 		PRINT_FIELD_U(", ", params.cq_off, ring_entries);
d811e0
 		PRINT_FIELD_U(", ", params.cq_off, overflow);
d811e0
 		PRINT_FIELD_U(", ", params.cq_off, cqes);
d811e0
-		if (!IS_ARRAY_ZERO(params.cq_off.resv)) {
d811e0
-			PRINT_FIELD_ARRAY(", ", params.cq_off, resv, tcp,
d811e0
-					  print_xint64_array_member);
d811e0
-		}
d811e0
+		PRINT_FIELD_FLAGS(", ", params.cq_off, flags,
d811e0
+				  uring_cqring_flags, "IORING_CQ_???");
d811e0
+		if (params.cq_off.resv1)
d811e0
+			PRINT_FIELD_X(", ", params.cq_off, resv1);
d811e0
+		if (params.cq_off.resv2)
d811e0
+			PRINT_FIELD_X(", ", params.cq_off, resv2);
d811e0
 		tprints("}");
d811e0
 	}
d811e0
 	tprints("}");
d811e0
Index: strace-5.7/tests/io_uring_setup.c
d811e0
===================================================================
d811e0
--- strace-5.7.orig/tests/io_uring_setup.c	2020-11-09 04:39:07.197892960 +0100
d811e0
+++ strace-5.7/tests/io_uring_setup.c	2020-11-09 04:39:14.943826575 +0100
d811e0
@@ -27,6 +27,7 @@
d811e0
 # include "xlat.h"
d811e0
 
d811e0
 # include "xlat/uring_setup_features.h"
d811e0
+# include "xlat/uring_cqring_flags.h"
d811e0
 
d811e0
 # ifdef HAVE_STRUCT_IO_URING_PARAMS_FEATURES
d811e0
 #  ifdef HAVE_STRUCT_IO_URING_PARAMS_WQ_FD
d811e0
@@ -144,20 +145,40 @@
d811e0
 						params->sq_off.resv2);
d811e0
 
d811e0
 			printf("}, cq_off={head=%u, tail=%u, ring_mask=%u"
d811e0
-			       ", ring_entries=%u, overflow=%u, cqes=%u",
d811e0
+			       ", ring_entries=%u, overflow=%u, cqes=%u, flags=",
d811e0
 			       params->cq_off.head,
d811e0
 			       params->cq_off.tail,
d811e0
 			       params->cq_off.ring_mask,
d811e0
 			       params->cq_off.ring_entries,
d811e0
 			       params->cq_off.overflow,
d811e0
 			       params->cq_off.cqes);
d811e0
-			if (params->cq_off.resv[0] || params->cq_off.resv[1]) {
d811e0
-				printf(", resv=[%#llx, %#llx]",
d811e0
+#ifdef HAVE_STRUCT_IO_CQRING_OFFSETS_FLAGS
d811e0
+			printflags(uring_cqring_flags,
d811e0
+			       params->cq_off.flags,
d811e0
+			       "IORING_CQ_???");
d811e0
+			if (params->cq_off.resv1)
d811e0
+				printf(", resv1=%#x", params->cq_off.resv1);
d811e0
+			if (params->cq_off.resv2)
d811e0
+				printf(", resv2=%#llx",
d811e0
 				       (unsigned long long)
d811e0
-						params->cq_off.resv[0],
d811e0
+						params->cq_off.resv2);
d811e0
+#else
d811e0
+			union {
d811e0
+				struct {
d811e0
+					uint32_t flags;
d811e0
+					uint32_t resv1;
d811e0
+				} s;
d811e0
+				uint64_t v;
d811e0
+			} u = { .v = params->cq_off.resv[0] };
d811e0
+			printflags(uring_cqring_flags, u.s.flags,
d811e0
+				   "IORING_CQ_???");
d811e0
+			if (u.s.resv1)
d811e0
+				printf(", resv1=%#x", u.s.resv1);
d811e0
+			if (params->cq_off.resv[1])
d811e0
+				printf(", resv2=%#llx",
d811e0
 				       (unsigned long long)
d811e0
 						params->cq_off.resv[1]);
d811e0
-			}
d811e0
+#endif
d811e0
 
d811e0
 			printf("}}) = %ld<anon_inode:[io_uring]>\n", rc);
d811e0
 		}
d811e0
Index: strace-5.7/types/io_uring.h
d811e0
===================================================================
d811e0
--- strace-5.7.orig/types/io_uring.h	2020-11-09 04:39:07.198892952 +0100
d811e0
+++ strace-5.7/types/io_uring.h	2020-11-09 04:39:14.944826567 +0100
d811e0
@@ -31,7 +31,9 @@
d811e0
 	uint32_t ring_entries;
d811e0
 	uint32_t overflow;
d811e0
 	uint32_t cqes;
d811e0
-	uint64_t resv[2];
d811e0
+	/** Added by v5.8-rc1~190^2~22 */	uint32_t flags;
d811e0
+	/** Added by v5.8-rc1~190^2~22 */	uint32_t resv1;
d811e0
+	/** Added by v5.8-rc1~190^2~22 */	uint64_t resv2;
d811e0
 } struct_io_cqring_offsets;
d811e0
 
d811e0
 typedef struct {
d811e0
Index: strace-5.7/xlat/uring_cqring_flags.in
d811e0
===================================================================
d811e0
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
d811e0
+++ strace-5.7/xlat/uring_cqring_flags.in	2020-11-09 04:39:14.944826567 +0100
d811e0
@@ -0,0 +1 @@
d811e0
+IORING_CQ_EVENTFD_DISABLED	1U
d811e0
Index: strace-5.7/Makefile.in
d811e0
===================================================================
d811e0
--- strace-5.7.orig/Makefile.in	2020-11-09 04:39:07.201892926 +0100
d811e0
+++ strace-5.7/Makefile.in	2020-11-09 04:42:54.519945367 +0100
d811e0
@@ -1506,10 +1506,10 @@
d811e0
 	xlat/uffd_register_mode_flags.in xlat/uffd_zeropage_flags.in \
d811e0
 	xlat/umount_flags.in xlat/unix_diag_attrs.in \
d811e0
 	xlat/unix_diag_show.in xlat/unshare_flags.in \
d811e0
-	xlat/uring_enter_flags.in xlat/uring_op_flags.in \
d811e0
-	xlat/uring_ops.in xlat/uring_register_opcodes.in \
d811e0
-	xlat/uring_setup_features.in xlat/uring_setup_flags.in \
d811e0
-	xlat/usagewho.in xlat/v4l2_buf_flags.in \
d811e0
+	xlat/uring_cqring_flags.in xlat/uring_enter_flags.in \
d811e0
+	xlat/uring_op_flags.in xlat/uring_ops.in \
d811e0
+	xlat/uring_register_opcodes.in xlat/uring_setup_features.in \
d811e0
+	xlat/uring_setup_flags.in xlat/usagewho.in xlat/v4l2_buf_flags.in \
d811e0
 	xlat/v4l2_buf_flags_masks.in xlat/v4l2_buf_flags_ts_src.in \
d811e0
 	xlat/v4l2_buf_flags_ts_type.in xlat/v4l2_buf_types.in \
d811e0
 	xlat/v4l2_capture_modes.in xlat/v4l2_colorspaces.in \
d811e0
@@ -1755,10 +1755,10 @@
d811e0
 	xlat/uffd_register_mode_flags.h xlat/uffd_zeropage_flags.h \
d811e0
 	xlat/umount_flags.h xlat/unix_diag_attrs.h \
d811e0
 	xlat/unix_diag_show.h xlat/unshare_flags.h \
d811e0
-	xlat/uring_enter_flags.h xlat/uring_op_flags.h \
d811e0
-	xlat/uring_ops.h xlat/uring_register_opcodes.h \
d811e0
-	xlat/uring_setup_features.h xlat/uring_setup_flags.h \
d811e0
-	xlat/usagewho.h xlat/v4l2_buf_flags.h \
d811e0
+	xlat/uring_cqring_flags.h xlat/uring_enter_flags.h \
d811e0
+	xlat/uring_op_flags.h xlat/uring_ops.h \
d811e0
+	xlat/uring_register_opcodes.h xlat/uring_setup_features.h \
d811e0
+	xlat/uring_setup_flags.h xlat/usagewho.h xlat/v4l2_buf_flags.h \
d811e0
 	xlat/v4l2_buf_flags_masks.h xlat/v4l2_buf_flags_ts_src.h \
d811e0
 	xlat/v4l2_buf_flags_ts_type.h xlat/v4l2_buf_types.h \
d811e0
 	xlat/v4l2_capture_modes.h xlat/v4l2_colorspaces.h \
d811e0
@@ -9974,6 +9974,8 @@
d811e0
 	$(AM_V_GEN)$(top_srcdir)/xlat/gen.sh $< $@
d811e0
 $(top_srcdir)/xlat/unshare_flags.h: $(top_srcdir)/xlat/unshare_flags.in $(top_srcdir)/xlat/gen.sh
d811e0
 	$(AM_V_GEN)$(top_srcdir)/xlat/gen.sh $< $@
d811e0
+$(top_srcdir)/xlat/uring_cqring_flags.h: $(top_srcdir)/xlat/uring_cqring_flags.in $(top_srcdir)/xlat/gen.sh
d811e0
+	$(AM_V_GEN)$(top_srcdir)/xlat/gen.sh $< $@
d811e0
 $(top_srcdir)/xlat/uring_enter_flags.h: $(top_srcdir)/xlat/uring_enter_flags.in $(top_srcdir)/xlat/gen.sh
d811e0
 	$(AM_V_GEN)$(top_srcdir)/xlat/gen.sh $< $@
d811e0
 $(top_srcdir)/xlat/uring_op_flags.h: $(top_srcdir)/xlat/uring_op_flags.in $(top_srcdir)/xlat/gen.sh
d811e0
Index: strace-5.7/configure
d811e0
===================================================================
d811e0
--- strace-5.7.orig/configure	2020-11-09 04:39:07.205892892 +0100
d811e0
+++ strace-5.7/configure	2020-11-09 05:07:10.675485410 +0100
d811e0
@@ -12580,7 +12580,17 @@
d811e0
 #define HAVE_LINUX_IO_URING_H 1
d811e0
 _ACEOF
d811e0
 
d811e0
-	ac_fn_c_check_member "$LINENO" "struct io_uring_params" "features" "ac_cv_member_struct_io_uring_params_features" "#include <linux/io_uring.h>
d811e0
+	ac_fn_c_check_member "$LINENO" "struct io_cqring_offsets" "flags" "ac_cv_member_struct_io_cqring_offsets_flags" "#include <linux/io_uring.h>
d811e0
+"
d811e0
+if test "x$ac_cv_member_struct_io_cqring_offsets_flags" = xyes; then :
d811e0
+
d811e0
+cat >>confdefs.h <<_ACEOF
d811e0
+#define HAVE_STRUCT_IO_CQRING_OFFSETS_FLAGS 1
d811e0
+_ACEOF
d811e0
+
d811e0
+
d811e0
+fi
d811e0
+ac_fn_c_check_member "$LINENO" "struct io_uring_params" "features" "ac_cv_member_struct_io_uring_params_features" "#include <linux/io_uring.h>
d811e0
 "
d811e0
 if test "x$ac_cv_member_struct_io_uring_params_features" = xyes; then :
d811e0
 
d811e0
Index: strace-5.7/tests-m32/io_uring_setup.c
d811e0
===================================================================
d811e0
--- strace-5.7.orig/tests-m32/io_uring_setup.c	2020-11-09 04:39:07.206892883 +0100
d811e0
+++ strace-5.7/tests-m32/io_uring_setup.c	2020-11-09 04:39:14.951826507 +0100
d811e0
@@ -27,6 +27,7 @@
d811e0
 # include "xlat.h"
d811e0
 
d811e0
 # include "xlat/uring_setup_features.h"
d811e0
+# include "xlat/uring_cqring_flags.h"
d811e0
 
d811e0
 # ifdef HAVE_STRUCT_IO_URING_PARAMS_FEATURES
d811e0
 #  ifdef HAVE_STRUCT_IO_URING_PARAMS_WQ_FD
d811e0
@@ -144,20 +145,40 @@
d811e0
 						params->sq_off.resv2);
d811e0
 
d811e0
 			printf("}, cq_off={head=%u, tail=%u, ring_mask=%u"
d811e0
-			       ", ring_entries=%u, overflow=%u, cqes=%u",
d811e0
+			       ", ring_entries=%u, overflow=%u, cqes=%u, flags=",
d811e0
 			       params->cq_off.head,
d811e0
 			       params->cq_off.tail,
d811e0
 			       params->cq_off.ring_mask,
d811e0
 			       params->cq_off.ring_entries,
d811e0
 			       params->cq_off.overflow,
d811e0
 			       params->cq_off.cqes);
d811e0
-			if (params->cq_off.resv[0] || params->cq_off.resv[1]) {
d811e0
-				printf(", resv=[%#llx, %#llx]",
d811e0
+#ifdef HAVE_STRUCT_IO_CQRING_OFFSETS_FLAGS
d811e0
+			printflags(uring_cqring_flags,
d811e0
+			       params->cq_off.flags,
d811e0
+			       "IORING_CQ_???");
d811e0
+			if (params->cq_off.resv1)
d811e0
+				printf(", resv1=%#x", params->cq_off.resv1);
d811e0
+			if (params->cq_off.resv2)
d811e0
+				printf(", resv2=%#llx",
d811e0
 				       (unsigned long long)
d811e0
-						params->cq_off.resv[0],
d811e0
+						params->cq_off.resv2);
d811e0
+#else
d811e0
+			union {
d811e0
+				struct {
d811e0
+					uint32_t flags;
d811e0
+					uint32_t resv1;
d811e0
+				} s;
d811e0
+				uint64_t v;
d811e0
+			} u = { .v = params->cq_off.resv[0] };
d811e0
+			printflags(uring_cqring_flags, u.s.flags,
d811e0
+				   "IORING_CQ_???");
d811e0
+			if (u.s.resv1)
d811e0
+				printf(", resv1=%#x", u.s.resv1);
d811e0
+			if (params->cq_off.resv[1])
d811e0
+				printf(", resv2=%#llx",
d811e0
 				       (unsigned long long)
d811e0
 						params->cq_off.resv[1]);
d811e0
-			}
d811e0
+#endif
d811e0
 
d811e0
 			printf("}}) = %ld<anon_inode:[io_uring]>\n", rc);
d811e0
 		}
d811e0
Index: strace-5.7/tests-mx32/io_uring_setup.c
d811e0
===================================================================
d811e0
--- strace-5.7.orig/tests-mx32/io_uring_setup.c	2020-11-09 04:39:07.206892883 +0100
d811e0
+++ strace-5.7/tests-mx32/io_uring_setup.c	2020-11-09 04:39:14.951826507 +0100
d811e0
@@ -27,6 +27,7 @@
d811e0
 # include "xlat.h"
d811e0
 
d811e0
 # include "xlat/uring_setup_features.h"
d811e0
+# include "xlat/uring_cqring_flags.h"
d811e0
 
d811e0
 # ifdef HAVE_STRUCT_IO_URING_PARAMS_FEATURES
d811e0
 #  ifdef HAVE_STRUCT_IO_URING_PARAMS_WQ_FD
d811e0
@@ -144,20 +145,40 @@
d811e0
 						params->sq_off.resv2);
d811e0
 
d811e0
 			printf("}, cq_off={head=%u, tail=%u, ring_mask=%u"
d811e0
-			       ", ring_entries=%u, overflow=%u, cqes=%u",
d811e0
+			       ", ring_entries=%u, overflow=%u, cqes=%u, flags=",
d811e0
 			       params->cq_off.head,
d811e0
 			       params->cq_off.tail,
d811e0
 			       params->cq_off.ring_mask,
d811e0
 			       params->cq_off.ring_entries,
d811e0
 			       params->cq_off.overflow,
d811e0
 			       params->cq_off.cqes);
d811e0
-			if (params->cq_off.resv[0] || params->cq_off.resv[1]) {
d811e0
-				printf(", resv=[%#llx, %#llx]",
d811e0
+#ifdef HAVE_STRUCT_IO_CQRING_OFFSETS_FLAGS
d811e0
+			printflags(uring_cqring_flags,
d811e0
+			       params->cq_off.flags,
d811e0
+			       "IORING_CQ_???");
d811e0
+			if (params->cq_off.resv1)
d811e0
+				printf(", resv1=%#x", params->cq_off.resv1);
d811e0
+			if (params->cq_off.resv2)
d811e0
+				printf(", resv2=%#llx",
d811e0
 				       (unsigned long long)
d811e0
-						params->cq_off.resv[0],
d811e0
+						params->cq_off.resv2);
d811e0
+#else
d811e0
+			union {
d811e0
+				struct {
d811e0
+					uint32_t flags;
d811e0
+					uint32_t resv1;
d811e0
+				} s;
d811e0
+				uint64_t v;
d811e0
+			} u = { .v = params->cq_off.resv[0] };
d811e0
+			printflags(uring_cqring_flags, u.s.flags,
d811e0
+				   "IORING_CQ_???");
d811e0
+			if (u.s.resv1)
d811e0
+				printf(", resv1=%#x", u.s.resv1);
d811e0
+			if (params->cq_off.resv[1])
d811e0
+				printf(", resv2=%#llx",
d811e0
 				       (unsigned long long)
d811e0
 						params->cq_off.resv[1]);
d811e0
-			}
d811e0
+#endif
d811e0
 
d811e0
 			printf("}}) = %ld<anon_inode:[io_uring]>\n", rc);
d811e0
 		}
d811e0
Index: strace-5.7/xlat/uring_cqring_flags.h
d811e0
===================================================================
d811e0
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
d811e0
+++ strace-5.7/xlat/uring_cqring_flags.h	2020-11-09 05:07:27.046345327 +0100
d811e0
@@ -0,0 +1,48 @@
d811e0
+/* Generated by ./xlat/gen.sh from ./xlat/uring_cqring_flags.in; do not edit. */
d811e0
+
d811e0
+#include "gcc_compat.h"
d811e0
+#include "static_assert.h"
d811e0
+
d811e0
+#if defined(IORING_CQ_EVENTFD_DISABLED) || (defined(HAVE_DECL_IORING_CQ_EVENTFD_DISABLED) && HAVE_DECL_IORING_CQ_EVENTFD_DISABLED)
d811e0
+DIAG_PUSH_IGNORE_TAUTOLOGICAL_COMPARE
d811e0
+static_assert((IORING_CQ_EVENTFD_DISABLED) == (1U), "IORING_CQ_EVENTFD_DISABLED != 1U");
d811e0
+DIAG_POP_IGNORE_TAUTOLOGICAL_COMPARE
d811e0
+#else
d811e0
+# define IORING_CQ_EVENTFD_DISABLED 1U
d811e0
+#endif
d811e0
+
d811e0
+#ifndef XLAT_MACROS_ONLY
d811e0
+
d811e0
+# ifdef IN_MPERS
d811e0
+
d811e0
+#  error static const struct xlat uring_cqring_flags in mpers mode
d811e0
+
d811e0
+# else
d811e0
+
d811e0
+static const struct xlat_data uring_cqring_flags_xdata[] = {
d811e0
+ XLAT(IORING_CQ_EVENTFD_DISABLED),
d811e0
+ #define XLAT_VAL_0 ((unsigned) (IORING_CQ_EVENTFD_DISABLED))
d811e0
+ #define XLAT_STR_0 STRINGIFY(IORING_CQ_EVENTFD_DISABLED)
d811e0
+};
d811e0
+static
d811e0
+const struct xlat uring_cqring_flags[1] = { {
d811e0
+ .data = uring_cqring_flags_xdata,
d811e0
+ .size = ARRAY_SIZE(uring_cqring_flags_xdata),
d811e0
+ .type = XT_NORMAL,
d811e0
+ .flags_mask = 0
d811e0
+#  ifdef XLAT_VAL_0
d811e0
+  | XLAT_VAL_0
d811e0
+#  endif
d811e0
+  ,
d811e0
+ .flags_strsz = 0
d811e0
+#  ifdef XLAT_STR_0
d811e0
+  + sizeof(XLAT_STR_0)
d811e0
+#  endif
d811e0
+  ,
d811e0
+} };
d811e0
+
d811e0
+#  undef XLAT_STR_0
d811e0
+#  undef XLAT_VAL_0
d811e0
+# endif /* !IN_MPERS */
d811e0
+
d811e0
+#endif /* !XLAT_MACROS_ONLY */