Blame SOURCES/0037-kvm-avoid-bogus-vcpu_info-assignment-in-vcpu_registe.patch
|
 |
4d44fe |
From 9446038e9face3313373ca5f7539476789fd4660 Mon Sep 17 00:00:00 2001
|
|
|
4d44fe |
From: Eugene Syromyatnikov <evgsyr@gmail.com>
|
|
|
4d44fe |
Date: Tue, 18 Dec 2018 05:37:30 +0100
|
|
|
4d44fe |
Subject: [PATCH] kvm: avoid bogus vcpu_info assignment in vcpu_register
|
|
|
4d44fe |
|
|
|
4d44fe |
Also reformat code a bit to make nesting a bit clearer.
|
|
|
4d44fe |
|
|
|
4d44fe |
Reported by Clang.
|
|
|
4d44fe |
|
|
|
4d44fe |
* kvm.c (vcpu_register): Do not assign vcpu_alloc result to vcpu_info
|
|
|
4d44fe |
as this value is not used afterwards in the function.
|
|
|
4d44fe |
---
|
|
|
4d44fe |
kvm.c | 7 +++----
|
|
|
4d44fe |
1 file changed, 3 insertions(+), 4 deletions(-)
|
|
|
4d44fe |
|
|
|
4d44fe |
diff --git a/kvm.c b/kvm.c
|
|
|
4d44fe |
index 984a75e..8bdf1cc 100644
|
|
|
4d44fe |
--- a/kvm.c
|
|
|
4d44fe |
+++ b/kvm.c
|
|
|
4d44fe |
@@ -76,10 +76,9 @@ vcpu_register(struct tcb *const tcp, int fd, int cpuid)
|
|
|
4d44fe |
|
|
|
4d44fe |
struct vcpu_info *vcpu_info = vcpu_find(tcp, fd);
|
|
|
4d44fe |
|
|
|
4d44fe |
- if (!vcpu_info)
|
|
|
4d44fe |
- vcpu_info = vcpu_alloc(tcp, fd, cpuid);
|
|
|
4d44fe |
- else if (vcpu_info->cpuid != cpuid)
|
|
|
4d44fe |
- {
|
|
|
4d44fe |
+ if (!vcpu_info) {
|
|
|
4d44fe |
+ vcpu_alloc(tcp, fd, cpuid);
|
|
|
4d44fe |
+ } else if (vcpu_info->cpuid != cpuid) {
|
|
|
4d44fe |
vcpu_info->cpuid = cpuid;
|
|
|
4d44fe |
vcpu_info->resolved = false;
|
|
|
4d44fe |
}
|
|
|
4d44fe |
--
|
|
|
4d44fe |
2.1.4
|
|
|
4d44fe |
|