|
 |
4d44fe |
From ee037ea1bbe3e9134eab3586bbd54613f39a1693 Mon Sep 17 00:00:00 2001
|
|
|
4d44fe |
From: "Dmitry V. Levin" <ldv@altlinux.org>
|
|
|
4d44fe |
Date: Sun, 23 Dec 2018 22:12:36 +0000
|
|
|
4d44fe |
Subject: [PATCH 09/27] rtnl_link: fix off-by-one errors in indexed and sorted
|
|
|
4d44fe |
xlat lookups
|
|
|
4d44fe |
|
|
|
4d44fe |
* rtnl_link.c (decode_nla_tun_type, decode_ifla_xdp_attached,
|
|
|
4d44fe |
decode_ifla_inet_conf, decode_ifla_inet6_flags, decode_ifla_inet6_conf,
|
|
|
4d44fe |
decode_ifla_inet6_stats, decode_ifla_inet6_icmp6_stats,
|
|
|
4d44fe |
decode_ifla_inet6_agm): Decrement xlat size by one to account
|
|
|
4d44fe |
for XLAT_END as other users of indexed and sorted xlats do.
|
|
|
4d44fe |
|
|
|
4d44fe |
Fixes: v4.25~71 "rtnl_link: decode named constants for IFLA_XDP_ATTACHED attribute value"
|
|
|
4d44fe |
Fixes: v4.23~41 "rtnl_link: decode IFLA_AF_SPEC"
|
|
|
4d44fe |
Fixes: v4.23~37 "rtnl_link: implement IFLA_INFO_DATA for tun devices"
|
|
|
4d44fe |
|
|
|
4d44fe |
Conflicts:
|
|
|
4d44fe |
rtnl_link.c
|
|
|
4d44fe |
---
|
|
|
4d44fe |
rtnl_link.c | 16 +++++++++-------
|
|
|
4d44fe |
1 file changed, 9 insertions(+), 7 deletions(-)
|
|
|
4d44fe |
|
|
|
4d44fe |
diff --git a/rtnl_link.c b/rtnl_link.c
|
|
|
4d44fe |
index 1fbfd26..8e02bc7 100644
|
|
|
4d44fe |
--- a/rtnl_link.c
|
|
|
4d44fe |
+++ b/rtnl_link.c
|
|
|
4d44fe |
@@ -356,7 +356,7 @@ decode_nla_tun_type(struct tcb *const tcp,
|
|
|
4d44fe |
{
|
|
|
4d44fe |
const struct decode_nla_xlat_opts opts = {
|
|
|
4d44fe |
.xlat = tun_device_types,
|
|
|
4d44fe |
- .xlat_size = ARRAY_SIZE(tun_device_types),
|
|
|
4d44fe |
+ .xlat_size = ARRAY_SIZE(tun_device_types) - 1,
|
|
|
4d44fe |
.xt = XT_INDEXED,
|
|
|
4d44fe |
.dflt = "IFF_???",
|
|
|
4d44fe |
.size = 1,
|
|
|
4d44fe |
@@ -626,7 +626,8 @@ decode_ifla_inet_conf(struct tcb *const tcp,
|
|
|
4d44fe |
print_array_ex(tcp, addr, cnt, &elem, sizeof(elem),
|
|
|
4d44fe |
tfetch_mem, print_int32_array_member, NULL,
|
|
|
4d44fe |
PAF_PRINT_INDICES | PAF_INDEX_XLAT_VALUE_INDEXED
|
|
|
4d44fe |
- | XLAT_STYLE_FMT_D, ARRSZ_PAIR(inet_devconf_indices),
|
|
|
4d44fe |
+ | XLAT_STYLE_FMT_D,
|
|
|
4d44fe |
+ ARRSZ_PAIR(inet_devconf_indices) - 1,
|
|
|
4d44fe |
"IPV4_DEVCONF_???");
|
|
|
4d44fe |
|
|
|
4d44fe |
return true;
|
|
|
4d44fe |
@@ -643,7 +644,7 @@ decode_ifla_inet6_flags(struct tcb *const tcp,
|
|
|
4d44fe |
const void *const opaque_data)
|
|
|
4d44fe |
{
|
|
|
4d44fe |
const struct decode_nla_xlat_opts opts = {
|
|
|
4d44fe |
- ARRSZ_PAIR(inet6_if_flags), "IF_???",
|
|
|
4d44fe |
+ ARRSZ_PAIR(inet6_if_flags) - 1, "IF_???",
|
|
|
4d44fe |
.size = 4,
|
|
|
4d44fe |
};
|
|
|
4d44fe |
|
|
|
4d44fe |
@@ -665,7 +666,8 @@ decode_ifla_inet6_conf(struct tcb *const tcp,
|
|
|
4d44fe |
print_array_ex(tcp, addr, cnt, &elem, sizeof(elem),
|
|
|
4d44fe |
tfetch_mem, print_int32_array_member, NULL,
|
|
|
4d44fe |
PAF_PRINT_INDICES | PAF_INDEX_XLAT_VALUE_INDEXED
|
|
|
4d44fe |
- | XLAT_STYLE_FMT_D, ARRSZ_PAIR(inet6_devconf_indices),
|
|
|
4d44fe |
+ | XLAT_STYLE_FMT_D,
|
|
|
4d44fe |
+ ARRSZ_PAIR(inet6_devconf_indices) - 1,
|
|
|
4d44fe |
"DEVCONF_???");
|
|
|
4d44fe |
|
|
|
4d44fe |
return true;
|
|
|
4d44fe |
@@ -686,7 +688,7 @@ decode_ifla_inet6_stats(struct tcb *const tcp,
|
|
|
4d44fe |
print_array_ex(tcp, addr, cnt, &elem, sizeof(elem),
|
|
|
4d44fe |
tfetch_mem, print_uint64_array_member, NULL,
|
|
|
4d44fe |
PAF_PRINT_INDICES | PAF_INDEX_XLAT_VALUE_INDEXED
|
|
|
4d44fe |
- | XLAT_STYLE_FMT_U, ARRSZ_PAIR(snmp_ip_stats),
|
|
|
4d44fe |
+ | XLAT_STYLE_FMT_U, ARRSZ_PAIR(snmp_ip_stats) - 1,
|
|
|
4d44fe |
"IPSTATS_MIB_???");
|
|
|
4d44fe |
|
|
|
4d44fe |
return true;
|
|
|
4d44fe |
@@ -733,7 +735,7 @@ decode_ifla_inet6_icmp6_stats(struct tcb *const tcp,
|
|
|
4d44fe |
print_array_ex(tcp, addr, cnt, &elem, sizeof(elem),
|
|
|
4d44fe |
tfetch_mem, print_uint64_array_member, NULL,
|
|
|
4d44fe |
PAF_PRINT_INDICES | PAF_INDEX_XLAT_VALUE_INDEXED
|
|
|
4d44fe |
- | XLAT_STYLE_FMT_U, ARRSZ_PAIR(snmp_icmp6_stats),
|
|
|
4d44fe |
+ | XLAT_STYLE_FMT_U, ARRSZ_PAIR(snmp_icmp6_stats) - 1,
|
|
|
4d44fe |
"ICMP6_MIB_???");
|
|
|
4d44fe |
|
|
|
4d44fe |
return true;
|
|
|
4d44fe |
@@ -762,7 +764,7 @@ decode_ifla_inet6_agm(struct tcb *const tcp,
|
|
|
4d44fe |
const void *const opaque_data)
|
|
|
4d44fe |
{
|
|
|
4d44fe |
const struct decode_nla_xlat_opts opts = {
|
|
|
4d44fe |
- ARRSZ_PAIR(in6_addr_gen_mode), "IN6_ADDR_GEN_MODE_???",
|
|
|
4d44fe |
+ ARRSZ_PAIR(in6_addr_gen_mode) - 1, "IN6_ADDR_GEN_MODE_???",
|
|
|
4d44fe |
.xt = XT_INDEXED,
|
|
|
4d44fe |
.size = 1,
|
|
|
4d44fe |
};
|
|
|
4d44fe |
--
|
|
|
4d44fe |
2.1.4
|
|
|
4d44fe |
|