|
 |
4d44fe |
From c658eb981bfc302aafe5be6e4118a9c0a3f1735e Mon Sep 17 00:00:00 2001
|
|
|
4d44fe |
From: Zhibin Li <08826794brmt@gmail.com>
|
|
|
4d44fe |
Date: Wed, 1 Aug 2018 17:53:57 +0800
|
|
|
4d44fe |
Subject: [PATCH 02/27] evdev: fix decoding of EVIOCGBIT(0, ...)
|
|
|
4d44fe |
|
|
|
4d44fe |
There is a comment in drivers/input/evdev.c which says:
|
|
|
4d44fe |
/* EV_SYN==0 is EV_CNT, _not_ SYN_CNT, see EVIOCGBIT */
|
|
|
4d44fe |
|
|
|
4d44fe |
That is, EVIOCGBIT(0, ...) should return a bit mask with supported
|
|
|
4d44fe |
event types instead of SYN_* event codes.
|
|
|
4d44fe |
|
|
|
4d44fe |
* defs.h (evdev_ev): New prototype.
|
|
|
4d44fe |
* evdev.c: Include "xlat/evdev_ev.h" and remove "xlat/evdev_sync.h".
|
|
|
4d44fe |
(bit_ioctl) <case EV_SYN>: Replace EV_SYN with 0, use evdev_ev
|
|
|
4d44fe |
with XT_SORTED in decode_bitset invocation instead.
|
|
|
4d44fe |
* ioctl.c: Do not include "xlat/evdev_ev.h".
|
|
|
4d44fe |
(evdev_decode_number): Print nr == 0x20 as "0" instead of "EV_SYN".
|
|
|
4d44fe |
* tests/ioctl_evdev.c (main): Use 0 instead of EV_SYN in EVIOCGBIT
|
|
|
4d44fe |
output.
|
|
|
4d44fe |
* xlat/evdev_sync.in: Remove.
|
|
|
4d44fe |
|
|
|
4d44fe |
Additional changes:
|
|
|
4d44fe |
xlat/evdev_ev.h (auto-generated from xlat/evdev_ev.in)
|
|
|
4d44fe |
|
|
|
4d44fe |
Co-Authored-by: Dmitry V. Levin <ldv@altlinux.org>
|
|
|
4d44fe |
Fixes: v4.10~89 "Add decoding for evdev ioctls"
|
|
|
4d44fe |
---
|
|
|
4d44fe |
defs.h | 1 +
|
|
|
4d44fe |
evdev.c | 8 ++++----
|
|
|
4d44fe |
ioctl.c | 7 ++++---
|
|
|
4d44fe |
tests/ioctl_evdev.c | 2 +-
|
|
|
4d44fe |
xlat/evdev_sync.in | 5 -----
|
|
|
4d44fe |
5 files changed, 10 insertions(+), 13 deletions(-)
|
|
|
4d44fe |
delete mode 100644 xlat/evdev_sync.in
|
|
|
4d44fe |
|
|
|
4d44fe |
Index: strace-4.24/defs.h
|
|
|
4d44fe |
===================================================================
|
|
|
4d44fe |
--- strace-4.24.orig/defs.h 2019-03-11 12:34:15.719549018 +0100
|
|
|
4d44fe |
+++ strace-4.24/defs.h 2019-03-11 12:47:05.976567233 +0100
|
|
|
4d44fe |
@@ -330,6 +330,7 @@
|
|
|
4d44fe |
/** Number of elements in evdev_abs array without the terminating record. */
|
|
|
4d44fe |
extern const size_t evdev_abs_size;
|
|
|
4d44fe |
|
|
|
4d44fe |
+extern const struct xlat evdev_ev[];
|
|
|
4d44fe |
extern const struct xlat iffflags[];
|
|
|
4d44fe |
extern const struct xlat ip_type_of_services[];
|
|
|
4d44fe |
extern const struct xlat ipc_private[];
|
|
|
4d44fe |
Index: strace-4.24/evdev.c
|
|
|
4d44fe |
===================================================================
|
|
|
4d44fe |
--- strace-4.24.orig/evdev.c 2019-03-11 12:34:21.911484926 +0100
|
|
|
4d44fe |
+++ strace-4.24/evdev.c 2019-03-11 12:47:05.976567233 +0100
|
|
|
4d44fe |
@@ -30,6 +30,7 @@
|
|
|
4d44fe |
#include "defs.h"
|
|
|
4d44fe |
|
|
|
4d44fe |
#include "xlat/evdev_abs.h"
|
|
|
4d44fe |
+#include "xlat/evdev_ev.h"
|
|
|
4d44fe |
|
|
|
4d44fe |
#ifdef HAVE_LINUX_INPUT_H
|
|
|
4d44fe |
|
|
|
4d44fe |
@@ -47,7 +48,6 @@
|
|
|
4d44fe |
# include "xlat/evdev_relative_axes.h"
|
|
|
4d44fe |
# include "xlat/evdev_snd.h"
|
|
|
4d44fe |
# include "xlat/evdev_switch.h"
|
|
|
4d44fe |
-# include "xlat/evdev_sync.h"
|
|
|
4d44fe |
|
|
|
4d44fe |
# ifndef SYN_MAX
|
|
|
4d44fe |
# define SYN_MAX 0xf
|
|
|
4d44fe |
@@ -258,9 +258,9 @@
|
|
|
4d44fe |
const kernel_ulong_t arg)
|
|
|
4d44fe |
{
|
|
|
4d44fe |
switch (ev_nr) {
|
|
|
4d44fe |
- case EV_SYN:
|
|
|
4d44fe |
- return decode_bitset(tcp, arg, evdev_sync,
|
|
|
4d44fe |
- SYN_MAX, "SYN_???", XT_INDEXED);
|
|
|
4d44fe |
+ case 0:
|
|
|
4d44fe |
+ return decode_bitset(tcp, arg, evdev_ev,
|
|
|
4d44fe |
+ EV_MAX, "EV_???", XT_SORTED);
|
|
|
4d44fe |
case EV_KEY:
|
|
|
4d44fe |
return decode_bitset(tcp, arg, evdev_keycode,
|
|
|
4d44fe |
KEY_MAX, "KEY_???", XT_INDEXED);
|
|
|
4d44fe |
Index: strace-4.24/ioctl.c
|
|
|
4d44fe |
===================================================================
|
|
|
4d44fe |
--- strace-4.24.orig/ioctl.c 2019-03-11 12:34:15.719549018 +0100
|
|
|
4d44fe |
+++ strace-4.24/ioctl.c 2019-03-11 12:47:05.976567233 +0100
|
|
|
4d44fe |
@@ -33,8 +33,6 @@
|
|
|
4d44fe |
#include <linux/ioctl.h>
|
|
|
4d44fe |
#include "xlat/ioctl_dirs.h"
|
|
|
4d44fe |
|
|
|
4d44fe |
-#include "xlat/evdev_ev.h"
|
|
|
4d44fe |
-
|
|
|
4d44fe |
static int
|
|
|
4d44fe |
compare(const void *a, const void *b)
|
|
|
4d44fe |
{
|
|
|
4d44fe |
@@ -99,7 +97,10 @@
|
|
|
4d44fe |
|
|
|
4d44fe |
if (nr >= 0x20 && nr <= 0x20 + 0x1f) {
|
|
|
4d44fe |
tprints("EVIOCGBIT(");
|
|
|
4d44fe |
- printxval(evdev_ev, nr - 0x20, "EV_???");
|
|
|
4d44fe |
+ if (nr == 0x20)
|
|
|
4d44fe |
+ tprintf("0");
|
|
|
4d44fe |
+ else
|
|
|
4d44fe |
+ printxval(evdev_ev, nr - 0x20, "EV_???");
|
|
|
4d44fe |
tprintf(", %u)", _IOC_SIZE(code));
|
|
|
4d44fe |
return 1;
|
|
|
4d44fe |
} else if (nr >= 0x40 && nr <= 0x40 + 0x3f) {
|
|
|
4d44fe |
Index: strace-4.24/tests/ioctl_evdev.c
|
|
|
4d44fe |
===================================================================
|
|
|
4d44fe |
--- strace-4.24.orig/tests/ioctl_evdev.c 2019-03-11 12:34:15.719549018 +0100
|
|
|
4d44fe |
+++ strace-4.24/tests/ioctl_evdev.c 2019-03-11 12:47:05.977567222 +0100
|
|
|
4d44fe |
@@ -138,7 +138,7 @@
|
|
|
4d44fe |
TEST_NULL_ARG_EX(EVIOCGABS(0x3f), "EVIOCGABS(0x3f /* ABS_??? */)");
|
|
|
4d44fe |
TEST_NULL_ARG_EX(EVIOCSABS(0x3f), "EVIOCSABS(0x3f /* ABS_??? */)");
|
|
|
4d44fe |
|
|
|
4d44fe |
- TEST_NULL_ARG(EVIOCGBIT(EV_SYN, 0));
|
|
|
4d44fe |
+ TEST_NULL_ARG(EVIOCGBIT(0, 0));
|
|
|
4d44fe |
TEST_NULL_ARG(EVIOCGBIT(EV_KEY, 1));
|
|
|
4d44fe |
TEST_NULL_ARG(EVIOCGBIT(EV_REL, 2));
|
|
|
4d44fe |
TEST_NULL_ARG(EVIOCGBIT(EV_ABS, 3));
|
|
|
4d44fe |
Index: strace-4.24/xlat/evdev_sync.in
|
|
|
4d44fe |
===================================================================
|
|
|
4d44fe |
--- strace-4.24.orig/xlat/evdev_sync.in 2019-03-11 12:34:15.719549018 +0100
|
|
|
4d44fe |
+++ /dev/null 1970-01-01 00:00:00.000000000 +0000
|
|
|
4d44fe |
@@ -1,5 +0,0 @@
|
|
|
4d44fe |
-#value_indexed
|
|
|
4d44fe |
-SYN_REPORT 0
|
|
|
4d44fe |
-SYN_CONFIG 1
|
|
|
4d44fe |
-SYN_MT_REPORT 2
|
|
|
4d44fe |
-SYN_DROPPED 3
|
|
|
4d44fe |
Index: strace-4.24/xlat/evdev_ev.h
|
|
|
4d44fe |
===================================================================
|
|
|
4d44fe |
--- strace-4.24.orig/xlat/evdev_ev.h 2018-08-14 02:44:11.000000000 +0200
|
|
|
4d44fe |
+++ strace-4.24/xlat/evdev_ev.h 2019-03-11 12:48:32.390670458 +0100
|
|
|
4d44fe |
@@ -90,13 +90,8 @@
|
|
|
4d44fe |
|
|
|
4d44fe |
#ifndef XLAT_MACROS_ONLY
|
|
|
4d44fe |
|
|
|
4d44fe |
-# ifdef IN_MPERS
|
|
|
4d44fe |
+# ifndef IN_MPERS
|
|
|
4d44fe |
|
|
|
4d44fe |
-# error static const struct xlat evdev_ev in mpers mode
|
|
|
4d44fe |
-
|
|
|
4d44fe |
-# else
|
|
|
4d44fe |
-
|
|
|
4d44fe |
-static
|
|
|
4d44fe |
const struct xlat evdev_ev[] = {
|
|
|
4d44fe |
XLAT(EV_SYN),
|
|
|
4d44fe |
XLAT(EV_KEY),
|
|
|
4d44fe |
Index: strace-4.24/tests-m32/ioctl_evdev.c
|
|
|
4d44fe |
===================================================================
|
|
|
4d44fe |
--- strace-4.24.orig/tests-m32/ioctl_evdev.c 2018-06-14 13:00:00.000000000 +0200
|
|
|
4d44fe |
+++ strace-4.24/tests-m32/ioctl_evdev.c 2019-08-29 17:35:59.062591866 +0200
|
|
|
4d44fe |
@@ -138,7 +138,7 @@
|
|
|
4d44fe |
TEST_NULL_ARG_EX(EVIOCGABS(0x3f), "EVIOCGABS(0x3f /* ABS_??? */)");
|
|
|
4d44fe |
TEST_NULL_ARG_EX(EVIOCSABS(0x3f), "EVIOCSABS(0x3f /* ABS_??? */)");
|
|
|
4d44fe |
|
|
|
4d44fe |
- TEST_NULL_ARG(EVIOCGBIT(EV_SYN, 0));
|
|
|
4d44fe |
+ TEST_NULL_ARG(EVIOCGBIT(0, 0));
|
|
|
4d44fe |
TEST_NULL_ARG(EVIOCGBIT(EV_KEY, 1));
|
|
|
4d44fe |
TEST_NULL_ARG(EVIOCGBIT(EV_REL, 2));
|
|
|
4d44fe |
TEST_NULL_ARG(EVIOCGBIT(EV_ABS, 3));
|
|
|
4d44fe |
Index: strace-4.24/tests-mx32/ioctl_evdev.c
|
|
|
4d44fe |
===================================================================
|
|
|
4d44fe |
--- strace-4.24.orig/tests-mx32/ioctl_evdev.c 2018-06-14 13:00:00.000000000 +0200
|
|
|
4d44fe |
+++ strace-4.24/tests-mx32/ioctl_evdev.c 2019-08-29 17:36:01.222564829 +0200
|
|
|
4d44fe |
@@ -138,7 +138,7 @@
|
|
|
4d44fe |
TEST_NULL_ARG_EX(EVIOCGABS(0x3f), "EVIOCGABS(0x3f /* ABS_??? */)");
|
|
|
4d44fe |
TEST_NULL_ARG_EX(EVIOCSABS(0x3f), "EVIOCSABS(0x3f /* ABS_??? */)");
|
|
|
4d44fe |
|
|
|
4d44fe |
- TEST_NULL_ARG(EVIOCGBIT(EV_SYN, 0));
|
|
|
4d44fe |
+ TEST_NULL_ARG(EVIOCGBIT(0, 0));
|
|
|
4d44fe |
TEST_NULL_ARG(EVIOCGBIT(EV_KEY, 1));
|
|
|
4d44fe |
TEST_NULL_ARG(EVIOCGBIT(EV_REL, 2));
|
|
|
4d44fe |
TEST_NULL_ARG(EVIOCGBIT(EV_ABS, 3));
|