From 7f4a89ff4e7dc7c3ffac24ac87187dca1e9e7d1e Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Wed, 8 Nov 2017 14:09:36 +0100 Subject: [PATCH 33/35] SYSTEMD: Clean pid file in corner cases MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit SSSD can cleanup pid file in case of standard stopping of daemon. It's done in function monitor_cleanup. However monitor does not have a change to cleanup file in case of OOM or sending SIGKILL to monitor. Even though PIDFile is not necessary for services with Type notify we should let systemd to clean this file in unexpected situations. Resolves: https://pagure.io/SSSD/sssd/issue/3528 Reviewed-by: Fabiano Fidêncio (cherry picked from commit f4b808c83ecbaf36c7069440535d62990e32d55d) --- src/sysv/systemd/sssd.service.in | 1 + 1 file changed, 1 insertion(+) diff --git a/src/sysv/systemd/sssd.service.in b/src/sysv/systemd/sssd.service.in index cea848fac80303d6fae12dd84316a91dbc60072d..0c515d34caaa3ea397c4c7e95eef0188df170840 100644 --- a/src/sysv/systemd/sssd.service.in +++ b/src/sysv/systemd/sssd.service.in @@ -10,6 +10,7 @@ EnvironmentFile=-@environment_file@ ExecStart=@sbindir@/sssd -i ${DEBUG_LOGGER} Type=notify NotifyAccess=main +PIDFile=@localstatedir@/run/sssd.pid [Install] WantedBy=multi-user.target -- 2.13.6