From 400c06ebd99bfa447d0f88228320224291c862e0 Mon Sep 17 00:00:00 2001 From: Pavel Reichl Date: Fri, 25 Apr 2014 13:26:19 +0100 Subject: [PATCH 123/124] AD Provider: bug-fix uninitialized variable ad_subdomains_refresh() always set value to output parameter 'changes' if EOK is returned. Reviewed-by: Sumit Bose (cherry picked from commit cef2384a3a6fc1a1637c6a55e2bced93d28e8fca) --- src/providers/ad/ad_subdomains.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/providers/ad/ad_subdomains.c b/src/providers/ad/ad_subdomains.c index ee04cbbe048e55666db22c48cf22c4c0241a0e3c..ef3bb50e83fc8e39b91922d6fc9646dfe6da58a3 100644 --- a/src/providers/ad/ad_subdomains.c +++ b/src/providers/ad/ad_subdomains.c @@ -423,6 +423,7 @@ static errno_t ad_subdomains_refresh(struct ad_subdomains_ctx *ctx, if (count == h) { /* all domains were already accounted for and have been updated */ ret = EOK; + *changes = false; goto done; } @@ -682,7 +683,7 @@ static void ad_subdomains_get_root_domain_done(struct tevent_req *req) struct sysdb_attrs **reply = NULL; struct ad_subdomains_req_ctx *ctx; int dp_error = DP_ERR_FATAL; - bool has_changes; + bool has_changes = false; ctx = tevent_req_callback_data(req, struct ad_subdomains_req_ctx); -- 1.9.0