|
 |
ecf709 |
From c58aac42664dd1a04edb37b0874109a6a88d0da1 Mon Sep 17 00:00:00 2001
|
|
|
ecf709 |
From: Lukas Slebodnik <lslebodn@redhat.com>
|
|
|
ecf709 |
Date: Mon, 5 Jun 2017 09:43:46 +0200
|
|
|
ecf709 |
Subject: [PATCH 172/181] pam_sss: Fix leaking of memory in case of failures
|
|
|
ecf709 |
MIME-Version: 1.0
|
|
|
ecf709 |
Content-Type: text/plain; charset=UTF-8
|
|
|
ecf709 |
Content-Transfer-Encoding: 8bit
|
|
|
ecf709 |
|
|
|
ecf709 |
Found by coverity.
|
|
|
ecf709 |
|
|
|
ecf709 |
Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>
|
|
|
ecf709 |
(cherry picked from commit 818d01b4a0d332fff06db33c0c985b8c0f1417c7)
|
|
|
ecf709 |
---
|
|
|
ecf709 |
src/sss_client/pam_sss.c | 3 +++
|
|
|
ecf709 |
1 file changed, 3 insertions(+)
|
|
|
ecf709 |
|
|
|
ecf709 |
diff --git a/src/sss_client/pam_sss.c b/src/sss_client/pam_sss.c
|
|
|
ecf709 |
index 9732459e6fb7ce01c9445c423cf0a583ca36e036..303809b9ea05b5a8709c05ae230d5f289b57de31 100644
|
|
|
ecf709 |
--- a/src/sss_client/pam_sss.c
|
|
|
ecf709 |
+++ b/src/sss_client/pam_sss.c
|
|
|
ecf709 |
@@ -1517,10 +1517,12 @@ static int prompt_sc_pin(pam_handle_t *pamh, struct pam_items *pi)
|
|
|
ecf709 |
if (pi->user_name_hint) {
|
|
|
ecf709 |
ret = pam_get_item(pamh, PAM_CONV, (const void **)&conv;;
|
|
|
ecf709 |
if (ret != PAM_SUCCESS) {
|
|
|
ecf709 |
+ free(prompt);
|
|
|
ecf709 |
return ret;
|
|
|
ecf709 |
}
|
|
|
ecf709 |
if (conv == NULL || conv->conv == NULL) {
|
|
|
ecf709 |
logger(pamh, LOG_ERR, "No conversation function");
|
|
|
ecf709 |
+ free(prompt);
|
|
|
ecf709 |
return PAM_SYSTEM_ERR;
|
|
|
ecf709 |
}
|
|
|
ecf709 |
|
|
|
ecf709 |
@@ -1540,6 +1542,7 @@ static int prompt_sc_pin(pam_handle_t *pamh, struct pam_items *pi)
|
|
|
ecf709 |
mesg[1] = &((*mesg)[1]);
|
|
|
ecf709 |
|
|
|
ecf709 |
ret = conv->conv(2, mesg, &resp, conv->appdata_ptr);
|
|
|
ecf709 |
+ free(prompt);
|
|
|
ecf709 |
if (ret != PAM_SUCCESS) {
|
|
|
ecf709 |
D(("Conversation failure: %s.", pam_strerror(pamh, ret)));
|
|
|
ecf709 |
return ret;
|
|
|
ecf709 |
--
|
|
|
ecf709 |
2.9.4
|
|
|
ecf709 |
|