From 897216b87352e9f80181be6f1a036163c599ba46 Mon Sep 17 00:00:00 2001

From: =?UTF-8?q?Michal=20=C5=BDidek?= <mzidek@redhat.com>

Date: Fri, 26 May 2017 19:58:48 +0200

Subject: [PATCH 146/152] TESTS: Add unit tests for cfg validation

MIME-Version: 1.0

Content-Type: text/plain; charset=UTF-8

Content-Transfer-Encoding: 8bit

Add infrastructure for unit tests for validators.

Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>

---

 Makefile.am                          |  16 +++

 src/tests/cmocka/test_config_check.c | 268 +++++++++++++++++++++++++++++++++++

 2 files changed, 284 insertions(+)

 create mode 100644 src/tests/cmocka/test_config_check.c

diff --git a/Makefile.am b/Makefile.am

index a6279133b56dcd5bcbd1306ae8f2ce18d90c2c12..503c8cfd795b503f566431c08a56a56147180322 100644

--- a/Makefile.am

+++ b/Makefile.am

@@ -252,6 +252,7 @@ if HAVE_CMOCKA

         dp_opt_tests \

         responder-get-domains-tests \

         sbus-internal-tests \

+        config_check-tests \

         sss_sifp-tests \

         test_search_bases \

         test_ldap_auth \

@@ -2429,6 +2430,21 @@ sbus_internal_tests_LDADD = \

     libsss_debug.la \

     libsss_test_common.la

+config_check_tests_SOURCES = \

+    src/tests/cmocka/test_config_check.c \

+    $(NULL)

+config_check_tests_CFLAGS = \

+    $(AM_CFLAGS) \

+    $(NULL)

+config_check_tests_LDADD = \

+    $(CMOCKA_LIBS) \

+    $(POPT_LIBS) \

+    $(INI_CONFIG_LIBS) \

+    $(TALLOC_LIBS) \

+    $(SSSD_INTERNAL_LTLIBS) \

+    libsss_test_common.la \

+    $(NULL)

+

 test_find_uid_SOURCES = \

     src/tests/cmocka/test_find_uid.c \

     src/util/find_uid.c \

diff --git a/src/tests/cmocka/test_config_check.c b/src/tests/cmocka/test_config_check.c

new file mode 100644

index 0000000000000000000000000000000000000000..8fc0b01f3ef3fe03152efd979a3e96c21ba567cc

--- /dev/null

+++ b/src/tests/cmocka/test_config_check.c

@@ -0,0 +1,268 @@

+/*

+    Authors:

+        Michal Zidek <mzidek@redhat.com>

+

+    Copyright (C) 2017 Red Hat

+

+    Config file validators test

+

+    This program is free software; you can redistribute it and/or modify

+    it under the terms of the GNU General Public License as published by

+    the Free Software Foundation; either version 3 of the License, or

+    (at your option) any later version.

+

+    This program is distributed in the hope that it will be useful,

+    but WITHOUT ANY WARRANTY; without even the implied warranty of

+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the

+    GNU General Public License for more details.

+

+    You should have received a copy of the GNU General Public License

+    along with this program.  If not, see <http://www.gnu.org/licenses/>.

+*/

+

+#include <popt.h>

+#include <talloc.h>

+#include <ini_configobj.h>

+

+#include "util/sss_ini.h"

+#include "tests/cmocka/common_mock.h"

+

+#ifdef HAVE_LIBINI_CONFIG_V1_3

+

+#define RULES_PATH ABS_SRC_DIR"/src/config/cfg_rules.ini"

+

+struct sss_ini_initdata {

+    char **error_list;

+    struct ref_array *ra_success_list;

+    struct ref_array *ra_error_list;

+    struct ini_cfgobj *sssd_config;

+    struct value_obj *obj;

+    const struct stat *cstat;

+    struct ini_cfgfile *file;

+};

+

+void config_check_test_common(const char *cfg_string,

+                              size_t num_errors_expected,

+                              const char **errors_expected)

+{

+    struct sss_ini_initdata *init_data;

+    size_t num_errors;

+    char **strs;

+    int ret;

+    TALLOC_CTX *tmp_ctx;

+

+    tmp_ctx = talloc_new(NULL);

+    assert_non_null(tmp_ctx);

+

+    init_data = sss_ini_initdata_init(tmp_ctx);

+

+    ret = ini_config_file_from_mem(discard_const(cfg_string),

+                                   strlen(cfg_string),

+                                   &init_data->file);

+    assert_int_equal(ret, EOK);

+

+    ret = ini_config_create(&(init_data->sssd_config));

+    assert_int_equal(ret, EOK);

+

+    ret = ini_config_parse(init_data->file,

+                           INI_STOP_ON_ANY,

+                           INI_MV1S_OVERWRITE,

+                           INI_PARSE_NOWRAP,

+                           init_data->sssd_config);

+    assert_int_equal(ret, EOK);

+

+    ret = sss_ini_call_validators_strs(tmp_ctx, init_data,

+                                       RULES_PATH,

+                                       &strs, &num_errors);

+    assert_int_equal(ret, EOK);

+

+    /* Output from validators */

+    for (int i = 0; i < num_errors; i++) {

+        /* Keep this printf loop for faster debugging */

+        printf("%s\n", strs[i]);

+    }

+

+    for (int i = 0; i < num_errors && i <= num_errors_expected; i++) {

+        assert_string_equal(strs[i], errors_expected[i]);

+    }

+

+    /* Check if the number of errors is the same */

+    assert_int_equal(num_errors_expected, num_errors);

+

+    sss_ini_close_file(init_data);

+    sss_ini_config_destroy(init_data);

+    talloc_free(tmp_ctx);

+}

+

+void config_check_test_bad_section_name(void **state)

+{

+    char cfg_str[] = "[sssssssssssssd]";

+    const char *expected_errors[] = {

+        "[rule/allowed_sections]: Section [sssssssssssssd] is not allowed. "

+        "Check for typos.",

+    };

+

+    config_check_test_common(cfg_str, 1, expected_errors);

+}

+

+void config_check_test_bad_sssd_option_name(void **state)

+{

+    char cfg_str[] = "[sssd]\n"

+                     "debug_leTYPOvel = 10\n";

+    const char *expected_errors[] = {

+        "[rule/allowed_sssd_options]: Attribute 'debug_leTYPOvel' is not "

+        "allowed in section 'sssd'. Check for typos.",

+    };

+

+    config_check_test_common(cfg_str, 1, expected_errors);

+}

+

+void config_check_test_bad_pam_option_name(void **state)

+{

+    char cfg_str[] = "[pam]\n"

+                     "debug_leTYPOvel = 10\n";

+    const char *expected_errors[] = {

+        "[rule/allowed_pam_options]: Attribute 'debug_leTYPOvel' is not "

+        "allowed in section 'pam'. Check for typos.",

+    };

+

+    config_check_test_common(cfg_str, 1, expected_errors);

+}

+

+void config_check_test_bad_nss_option_name(void **state)

+{

+    char cfg_str[] = "[nss]\n"

+                     "debug_leTYPOvel = 10\n";

+    const char *expected_errors[] = {

+        "[rule/allowed_nss_options]: Attribute 'debug_leTYPOvel' is not "

+        "allowed in section 'nss'. Check for typos.",

+    };

+

+    config_check_test_common(cfg_str, 1, expected_errors);

+}

+

+void config_check_test_bad_pac_option_name(void **state)

+{

+    char cfg_str[] = "[pac]\n"

+                     "debug_leTYPOvel = 10\n";

+    const char *expected_errors[] = {

+        "[rule/allowed_pac_options]: Attribute 'debug_leTYPOvel' is not "

+        "allowed in section 'pac'. Check for typos.",

+    };

+

+    config_check_test_common(cfg_str, 1, expected_errors);

+}

+

+void config_check_test_bad_ifp_option_name(void **state)

+{

+    char cfg_str[] = "[ifp]\n"

+                     "debug_leTYPOvel = 10\n";

+    const char *expected_errors[] = {

+        "[rule/allowed_ifp_options]: Attribute 'debug_leTYPOvel' is not "

+        "allowed in section 'ifp'. Check for typos.",

+    };

+

+    config_check_test_common(cfg_str, 1, expected_errors);

+}

+

+void config_check_test_bad_domain_option_name(void **state)

+{

+    char cfg_str[] = "[domain/A.test\n"

+                     "debug_leTYPOvel = 10\n";

+    const char *expected_errors[] = {

+        "[rule/allowed_subdomain_options]: Attribute 'debug_leTYPOvel' is not "

+        "allowed in section 'domain/A.test'. Check for typos.",

+    };

+

+    config_check_test_common(cfg_str, 1, expected_errors);

+}

+

+void config_check_test_bad_appdomain_option_name(void **state)

+{

+    char cfg_str[] = "[application/myapp\n"

+                     "debug_leTYPOvel = 10\n";

+    const char *expected_errors[] = {

+        "[rule/allowed_subdomain_options]: Attribute 'debug_leTYPOvel' is not "

+        "allowed in section 'application/myapp'. Check for typos.",

+    };

+

+    config_check_test_common(cfg_str, 1, expected_errors);

+}

+

+void config_check_test_bad_subdom_option_name(void **state)

+{

+    char cfg_str[] = "[domain/A.test/B.A.test]\n"

+                     "debug_leTYPOvel = 10\n";

+    const char *expected_errors[] = {

+        "[rule/allowed_sssd_options]: Attribute 'debug_leTYPOvel' is not "

+        "allowed in section 'domain/A.test/B.A.test'. Check for typos.",

+    };

+

+    config_check_test_common(cfg_str, 1, expected_errors);

+}

+

+void config_check_test_good_sections(void **state)

+{

+    char cfg_str[] = "[sssd]\n"

+                     "[pam]\n"

+                     "[nss]\n"

+                     "[domain/testdom.test]\n"

+                     "[domain/testdom.test/testsubdom.testdom.test]\n"

+                     "[application/myapp]\n"

+                     "[secrets]\n"

+                     "[ifp]\n"

+                     "[pac]\n";

+    const char *expected_errors[] = { NULL };

+

+    config_check_test_common(cfg_str, 0, expected_errors);

+}

+

+int main(int argc, const char *argv[])

+{

+    poptContext pc;

+    int opt;

+    struct poptOption long_options[] = {

+        POPT_AUTOHELP

+        SSSD_DEBUG_OPTS

+        POPT_TABLEEND

+    };

+

+    const struct CMUnitTest tests[] = {

+        cmocka_unit_test(config_check_test_bad_section_name),

+        cmocka_unit_test(config_check_test_bad_sssd_option_name),

+        cmocka_unit_test(config_check_test_bad_pam_option_name),

+        cmocka_unit_test(config_check_test_bad_nss_option_name),

+        cmocka_unit_test(config_check_test_bad_pac_option_name),

+        cmocka_unit_test(config_check_test_bad_ifp_option_name),

+        cmocka_unit_test(config_check_test_good_sections),

+    };

+

+    /* Set debug level to invalid value so we can decide if -d 0 was used. */

+    debug_level = SSSDBG_INVALID;

+

+    pc = poptGetContext(argv[0], argc, argv, long_options, 0);

+    while ((opt = poptGetNextOpt(pc)) != -1) {

+        switch (opt) {

+        default:

+            fprintf(stderr, "\nInvalid option %s: %s\n\n",

+                    poptBadOption(pc, 0), poptStrerror(opt));

+            poptPrintUsage(pc, stderr, 0);

+            return 1;

+        }

+    }

+    poptFreeContext(pc);

+

+    DEBUG_CLI_INIT(debug_level);

+    tests_set_cwd();

+    return cmocka_run_group_tests(tests, NULL, NULL);

+}

+

+#else /* !HAVE_LIBINI_CONFIG_V1_3 */

+

+int main(int argc, const char *argv[])

+{

+    fprintf(stderr, "%s requires newer version of libini\n", argv[0]);

+    return 0;

+}

+

+#endif /* HAVE_LIBINI_CONFIG_V1_3 */

-- 

2.9.4