Blame SOURCES/0112-IPA-Improve-DEBUG-message-if-a-group-has-no-ipaNTSec.patch

bb7cd1
From 396849b6160594dbb6dedec5d1bd7fbc3af12cdd Mon Sep 17 00:00:00 2001
bb7cd1
From: Jakub Hrozek <jhrozek@redhat.com>
bb7cd1
Date: Fri, 21 Apr 2017 12:39:44 +0200
bb7cd1
Subject: [PATCH 112/118] IPA: Improve DEBUG message if a group has no
bb7cd1
 ipaNTSecurityIdentifier
bb7cd1
MIME-Version: 1.0
bb7cd1
Content-Type: text/plain; charset=UTF-8
bb7cd1
Content-Transfer-Encoding: 8bit
bb7cd1
bb7cd1
There was an issue in a production deployment where the admin selected a
bb7cd1
GID outside the IDM range for a group that contained a user from the
bb7cd1
trusted domain. This resulted in not adding a SID for the IPA group,
bb7cd1
which in turn meant the group couldn't be resolved on the client.
bb7cd1
bb7cd1
This patch just improves the DEBUG message so that it's clearer for the
bb7cd1
admins where the issue is.
bb7cd1
bb7cd1
Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>
bb7cd1
(cherry picked from commit ef019268d2d112ebff3577e551cd19478d73d93b)
bb7cd1
---
bb7cd1
 src/providers/ipa/ipa_s2n_exop.c | 5 ++++-
bb7cd1
 1 file changed, 4 insertions(+), 1 deletion(-)
bb7cd1
bb7cd1
diff --git a/src/providers/ipa/ipa_s2n_exop.c b/src/providers/ipa/ipa_s2n_exop.c
bb7cd1
index 2173db357700499a6140aa61841e443139981483..55ec904ca3188c7cf10ac41972e9ecf94ebf44bb 100644
bb7cd1
--- a/src/providers/ipa/ipa_s2n_exop.c
bb7cd1
+++ b/src/providers/ipa/ipa_s2n_exop.c
bb7cd1
@@ -1308,7 +1308,10 @@ static void ipa_s2n_get_list_next(struct tevent_req *subreq)
bb7cd1
     ret = sysdb_attrs_get_string(state->attrs->sysdb_attrs, SYSDB_SID_STR,
bb7cd1
                                  &sid_str);
bb7cd1
     if (ret != EOK) {
bb7cd1
-        DEBUG(SSSDBG_OP_FAILURE, "sysdb_attrs_get_string failed.\n");
bb7cd1
+        DEBUG(SSSDBG_CRIT_FAILURE,
bb7cd1
+              "Object [%s] has no SID, please check the "
bb7cd1
+              "ipaNTSecurityIdentifier attribute on the server-side",
bb7cd1
+              state->attrs->a.name);
bb7cd1
         goto fail;
bb7cd1
     }
bb7cd1
 
bb7cd1
-- 
bb7cd1
2.9.3
bb7cd1