Blame SOURCES/0112-AD-Continue-if-sssd-failes-to-check-extra-members.patch

2fc102
From 2ac5fed1ea4e9f56a18d0cc3b445855cdc6757c2 Mon Sep 17 00:00:00 2001
2fc102
From: Lukas Slebodnik <lslebodn@redhat.com>
2fc102
Date: Wed, 12 Mar 2014 17:38:22 +0100
2fc102
Subject: [PATCH 112/113] AD: Continue if sssd failes to check extra members
2fc102
2fc102
Reported by scan-build
2fc102
2fc102
    for (mi = 0; group_only[mi]; mi++) {
2fc102
                 ^~~~~~~~~~
2fc102
warning: Array access (from variable 'group_only') results in a null pointer
2fc102
dereference
2fc102
2fc102
It can happend if function ad_group_extra_members fails (ret != EOK)
2fc102
2fc102
Reviewed-by: Simo Sorce <simo@redhat.com>
2fc102
(cherry picked from commit bad65473c4c28ecbf2b6bd374a7ae2d634d57d8d)
2fc102
---
2fc102
 src/providers/ad/ad_id.c | 1 +
2fc102
 1 file changed, 1 insertion(+)
2fc102
2fc102
diff --git a/src/providers/ad/ad_id.c b/src/providers/ad/ad_id.c
2fc102
index a35823b4b77d42fc583a61653a175f0ee4d22ac4..01d18d7ae4bee82d8b75c7103c0f07635c6e08cc 100644
2fc102
--- a/src/providers/ad/ad_id.c
2fc102
+++ b/src/providers/ad/ad_id.c
2fc102
@@ -772,6 +772,7 @@ ad_enum_cross_dom_members(struct sdap_options *opts,
2fc102
         ret = ad_group_extra_members(tmp_ctx, msgs[i], dom, &group_only);
2fc102
         if (ret != EOK) {
2fc102
             DEBUG(SSSDBG_OP_FAILURE, ("Failed to check extra members\n"));
2fc102
+            continue;
2fc102
         } else if (group_only == NULL) {
2fc102
             DEBUG(SSSDBG_TRACE_INTERNAL, ("No extra members\n"));
2fc102
             continue;
2fc102
-- 
2fc102
1.8.5.3
2fc102