|
 |
ecf709 |
From 3ba9f82ac428f509df33e509a39eb783480f5d19 Mon Sep 17 00:00:00 2001
|
|
|
ecf709 |
From: Sumit Bose <sbose@redhat.com>
|
|
|
ecf709 |
Date: Thu, 16 Mar 2017 12:38:08 +0100
|
|
|
ecf709 |
Subject: [PATCH 55/60] ssh: handle binary keys correctly
|
|
|
ecf709 |
|
|
|
ecf709 |
Related to https://pagure.io/SSSD/sssd/issue/3332
|
|
|
ecf709 |
|
|
|
ecf709 |
Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>
|
|
|
ecf709 |
---
|
|
|
ecf709 |
src/responder/ssh/ssh_reply.c | 8 +++++++-
|
|
|
ecf709 |
1 file changed, 7 insertions(+), 1 deletion(-)
|
|
|
ecf709 |
|
|
|
ecf709 |
diff --git a/src/responder/ssh/ssh_reply.c b/src/responder/ssh/ssh_reply.c
|
|
|
ecf709 |
index 807f4ee079128b4a3f1719de890ffac6e0d5b2e0..7093e47253b5687bab387feed5299c2d0841d43c 100644
|
|
|
ecf709 |
--- a/src/responder/ssh/ssh_reply.c
|
|
|
ecf709 |
+++ b/src/responder/ssh/ssh_reply.c
|
|
|
ecf709 |
@@ -32,6 +32,11 @@
|
|
|
ecf709 |
#include "responder/common/cache_req/cache_req.h"
|
|
|
ecf709 |
#include "responder/ssh/ssh_private.h"
|
|
|
ecf709 |
|
|
|
ecf709 |
+/* Locally used flag for libldb's ldb_message_element structure to indicate
|
|
|
ecf709 |
+ * binary data. Since the related data is only used in memory it is safe. If
|
|
|
ecf709 |
+ * should be used with care if libldb's I/O operations are involved. */
|
|
|
ecf709 |
+#define SSS_EL_FLAG_BIN_DATA (1<<4)
|
|
|
ecf709 |
+
|
|
|
ecf709 |
static errno_t get_valid_certs_keys(TALLOC_CTX *mem_ctx,
|
|
|
ecf709 |
struct ssh_ctx *ssh_ctx,
|
|
|
ecf709 |
struct ldb_message_element *el_cert,
|
|
|
ecf709 |
@@ -148,7 +153,7 @@ static errno_t decode_and_add_base64_data(struct sss_packet *packet,
|
|
|
ecf709 |
}
|
|
|
ecf709 |
|
|
|
ecf709 |
for (d = 0; d < el->num_values; d++) {
|
|
|
ecf709 |
- if (skip_base64_decode) {
|
|
|
ecf709 |
+ if (skip_base64_decode || (el->flags & SSS_EL_FLAG_BIN_DATA)) {
|
|
|
ecf709 |
key = el->values[d].data;
|
|
|
ecf709 |
key_len = el->values[d].length;
|
|
|
ecf709 |
} else {
|
|
|
ecf709 |
@@ -233,6 +238,7 @@ ssh_get_output_keys(TALLOC_CTX *mem_ctx,
|
|
|
ecf709 |
}
|
|
|
ecf709 |
|
|
|
ecf709 |
if (elements[i] != NULL) {
|
|
|
ecf709 |
+ elements[i]->flags |= SSS_EL_FLAG_BIN_DATA;
|
|
|
ecf709 |
num_keys += elements[i]->num_values;
|
|
|
ecf709 |
i++;
|
|
|
ecf709 |
}
|
|
|
ecf709 |
--
|
|
|
ecf709 |
2.9.3
|
|
|
ecf709 |
|