Blame SOURCES/0032-SECRETS-Log-message-for-failures-with-removing-file.patch

b2d430
From 38b3bd9bde495d44283de2b837ab0239140edb3d Mon Sep 17 00:00:00 2001
b2d430
From: Lukas Slebodnik <lslebodn@redhat.com>
b2d430
Date: Fri, 22 Jul 2016 09:53:40 +0200
b2d430
Subject: [PATCH 32/44] SECRETS: Log message for failures with removing file
b2d430
MIME-Version: 1.0
b2d430
Content-Type: text/plain; charset=UTF-8
b2d430
Content-Transfer-Encoding: 8bit
b2d430
b2d430
Type: Unchecked return value
b2d430
Reported by coverity
b2d430
b2d430
Reviewed-by: Petr Čech <pcech@redhat.com>
b2d430
---
b2d430
 src/responder/secrets/local.c | 8 +++++++-
b2d430
 1 file changed, 7 insertions(+), 1 deletion(-)
b2d430
b2d430
diff --git a/src/responder/secrets/local.c b/src/responder/secrets/local.c
b2d430
index 620134ea6b45629114ba795d0e232f414f6e5009..2a85ac06945322265fbd1012c9697728c37b77a0 100644
b2d430
--- a/src/responder/secrets/local.c
b2d430
+++ b/src/responder/secrets/local.c
b2d430
@@ -624,7 +624,13 @@ int generate_master_key(const char *filename, size_t size)
b2d430
     rsize = sss_atomic_io_s(fd, buf, size, false);
b2d430
     close(fd);
b2d430
     if (rsize != size) {
b2d430
-        unlink(filename);
b2d430
+        ret = unlink(filename);
b2d430
+        /* non-fatal failure */
b2d430
+        if (ret != EOK) {
b2d430
+            DEBUG(SSSDBG_MINOR_FAILURE,
b2d430
+                  "Failed to remove file: %s - %d [%s]!\n",
b2d430
+                  filename, ret, sss_strerror(ret));
b2d430
+        }
b2d430
         return EFAULT;
b2d430
     }
b2d430
 
b2d430
-- 
b2d430
2.4.11
b2d430