|
 |
bac598 |
From 3f0ba4c2dcf9126b0f94bca4a056b516759d25c1 Mon Sep 17 00:00:00 2001
|
|
|
bac598 |
From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrezina@redhat.com>
|
|
|
bac598 |
Date: Fri, 6 Mar 2020 12:49:04 +0100
|
|
|
bac598 |
Subject: [PATCH 13/18] cache_req: allow cache_req to return ERR_OFFLINE if all
|
|
|
bac598 |
dp request failed
|
|
|
bac598 |
|
|
|
bac598 |
Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
|
|
|
bac598 |
---
|
|
|
bac598 |
src/responder/common/cache_req/cache_req.c | 13 +++++++++++++
|
|
|
bac598 |
src/responder/common/cache_req/cache_req.h | 4 ++++
|
|
|
bac598 |
src/responder/common/cache_req/cache_req_data.c | 12 ++++++++++++
|
|
|
bac598 |
src/responder/common/cache_req/cache_req_private.h | 3 +++
|
|
|
bac598 |
4 files changed, 32 insertions(+)
|
|
|
bac598 |
|
|
|
bac598 |
diff --git a/src/responder/common/cache_req/cache_req.c b/src/responder/common/cache_req/cache_req.c
|
|
|
bac598 |
index afb0e7cda..0c8538414 100644
|
|
|
bac598 |
--- a/src/responder/common/cache_req/cache_req.c
|
|
|
bac598 |
+++ b/src/responder/common/cache_req/cache_req.c
|
|
|
bac598 |
@@ -974,6 +974,13 @@ static void cache_req_search_domains_done(struct tevent_req *subreq)
|
|
|
bac598 |
case ERR_ID_OUTSIDE_RANGE:
|
|
|
bac598 |
case ENOENT:
|
|
|
bac598 |
if (state->check_next == false) {
|
|
|
bac598 |
+ if (state->cr->data->propogate_offline_status && !state->dp_success) {
|
|
|
bac598 |
+ /* Not found and data provider request failed so we were
|
|
|
bac598 |
+ * unable to fetch the data. */
|
|
|
bac598 |
+ ret = ERR_OFFLINE;
|
|
|
bac598 |
+ goto done;
|
|
|
bac598 |
+ }
|
|
|
bac598 |
+
|
|
|
bac598 |
/* Not found. */
|
|
|
bac598 |
ret = ENOENT;
|
|
|
bac598 |
goto done;
|
|
|
bac598 |
@@ -1002,6 +1009,12 @@ done:
|
|
|
bac598 |
case EAGAIN:
|
|
|
bac598 |
break;
|
|
|
bac598 |
default:
|
|
|
bac598 |
+ if (ret == ENOENT && state->cr->data->propogate_offline_status
|
|
|
bac598 |
+ && !state->dp_success) {
|
|
|
bac598 |
+ /* Not found and data provider request failed so we were
|
|
|
bac598 |
+ * unable to fetch the data. */
|
|
|
bac598 |
+ ret = ERR_OFFLINE;
|
|
|
bac598 |
+ }
|
|
|
bac598 |
tevent_req_error(req, ret);
|
|
|
bac598 |
break;
|
|
|
bac598 |
}
|
|
|
bac598 |
diff --git a/src/responder/common/cache_req/cache_req.h b/src/responder/common/cache_req/cache_req.h
|
|
|
bac598 |
index 72d4abe5e..d36cb2d3b 100644
|
|
|
bac598 |
--- a/src/responder/common/cache_req/cache_req.h
|
|
|
bac598 |
+++ b/src/responder/common/cache_req/cache_req.h
|
|
|
bac598 |
@@ -171,6 +171,10 @@ void
|
|
|
bac598 |
cache_req_data_set_requested_domains(struct cache_req_data *data,
|
|
|
bac598 |
char **requested_domains);
|
|
|
bac598 |
|
|
|
bac598 |
+void
|
|
|
bac598 |
+cache_req_data_set_propogate_offline_status(struct cache_req_data *data,
|
|
|
bac598 |
+ bool propogate_offline_status);
|
|
|
bac598 |
+
|
|
|
bac598 |
enum cache_req_type
|
|
|
bac598 |
cache_req_data_get_type(struct cache_req_data *data);
|
|
|
bac598 |
|
|
|
bac598 |
diff --git a/src/responder/common/cache_req/cache_req_data.c b/src/responder/common/cache_req/cache_req_data.c
|
|
|
bac598 |
index 14c4ad14f..fe9f3db29 100644
|
|
|
bac598 |
--- a/src/responder/common/cache_req/cache_req_data.c
|
|
|
bac598 |
+++ b/src/responder/common/cache_req/cache_req_data.c
|
|
|
bac598 |
@@ -455,6 +455,18 @@ cache_req_data_set_requested_domains(struct cache_req_data *data,
|
|
|
bac598 |
data->requested_domains = requested_domains;
|
|
|
bac598 |
}
|
|
|
bac598 |
|
|
|
bac598 |
+void
|
|
|
bac598 |
+cache_req_data_set_propogate_offline_status(struct cache_req_data *data,
|
|
|
bac598 |
+ bool propogate_offline_status)
|
|
|
bac598 |
+{
|
|
|
bac598 |
+ if (data == NULL) {
|
|
|
bac598 |
+ DEBUG(SSSDBG_CRIT_FAILURE, "cache_req_data should never be NULL\n");
|
|
|
bac598 |
+ return;
|
|
|
bac598 |
+ }
|
|
|
bac598 |
+
|
|
|
bac598 |
+ data->propogate_offline_status = propogate_offline_status;
|
|
|
bac598 |
+}
|
|
|
bac598 |
+
|
|
|
bac598 |
enum cache_req_type
|
|
|
bac598 |
cache_req_data_get_type(struct cache_req_data *data)
|
|
|
bac598 |
{
|
|
|
bac598 |
diff --git a/src/responder/common/cache_req/cache_req_private.h b/src/responder/common/cache_req/cache_req_private.h
|
|
|
bac598 |
index bfca688b9..2d52e7600 100644
|
|
|
bac598 |
--- a/src/responder/common/cache_req/cache_req_private.h
|
|
|
bac598 |
+++ b/src/responder/common/cache_req/cache_req_private.h
|
|
|
bac598 |
@@ -103,6 +103,9 @@ struct cache_req_data {
|
|
|
bac598 |
|
|
|
bac598 |
/* if set, only search in the listed domains */
|
|
|
bac598 |
char **requested_domains;
|
|
|
bac598 |
+
|
|
|
bac598 |
+ /* if set, ERR_OFFLINE is returned if data provider is offline */
|
|
|
bac598 |
+ bool propogate_offline_status;
|
|
|
bac598 |
};
|
|
|
bac598 |
|
|
|
bac598 |
struct tevent_req *
|
|
|
bac598 |
--
|
|
|
bac598 |
2.21.3
|
|
|
bac598 |
|