|
 |
c29843 |
From d386e94ef49d95d7305a3e6578e41a2cf61dfc5c Mon Sep 17 00:00:00 2001
|
|
|
c29843 |
From: Alexey Tikhonov <atikhono@redhat.com>
|
|
|
c29843 |
Date: Tue, 16 Aug 2022 21:51:03 +0200
|
|
|
c29843 |
Subject: [PATCH 6/6] CLIENT:MC: pointer to the context mutex shouldn't be
|
|
|
c29843 |
touched
|
|
|
c29843 |
MIME-Version: 1.0
|
|
|
c29843 |
Content-Type: text/plain; charset=UTF-8
|
|
|
c29843 |
Content-Transfer-Encoding: 8bit
|
|
|
c29843 |
|
|
|
c29843 |
Even brief window inside `sss_nss_mc_destroy_ctx()` when `mutex == NULL`
|
|
|
c29843 |
was creating a possibility for a race.
|
|
|
c29843 |
|
|
|
c29843 |
Reviewed-by: Sumit Bose <sbose@redhat.com>
|
|
|
c29843 |
Reviewed-by: Tomáš Halman <thalman@redhat.com>
|
|
|
c29843 |
(cherry picked from commit 4ac93d9c5df59cdb7f397b4467f1c1c4822ff757)
|
|
|
c29843 |
---
|
|
|
c29843 |
src/sss_client/nss_mc.h | 4 +++-
|
|
|
c29843 |
src/sss_client/nss_mc_common.c | 20 ++++++++++----------
|
|
|
c29843 |
2 files changed, 13 insertions(+), 11 deletions(-)
|
|
|
c29843 |
|
|
|
c29843 |
diff --git a/src/sss_client/nss_mc.h b/src/sss_client/nss_mc.h
|
|
|
c29843 |
index 0f88521e9..9ab2736fa 100644
|
|
|
c29843 |
--- a/src/sss_client/nss_mc.h
|
|
|
c29843 |
+++ b/src/sss_client/nss_mc.h
|
|
|
c29843 |
@@ -44,7 +44,9 @@ enum sss_mc_state {
|
|
|
c29843 |
RECYCLED,
|
|
|
c29843 |
};
|
|
|
c29843 |
|
|
|
c29843 |
-/* common stuff */
|
|
|
c29843 |
+/* In the case this structure is extended, don't forget to update
|
|
|
c29843 |
+ * `SSS_CLI_MC_CTX_INITIALIZER` and `sss_nss_mc_destroy_ctx()`.
|
|
|
c29843 |
+ */
|
|
|
c29843 |
struct sss_cli_mc_ctx {
|
|
|
c29843 |
enum sss_mc_state initialized;
|
|
|
c29843 |
#if HAVE_PTHREAD
|
|
|
c29843 |
diff --git a/src/sss_client/nss_mc_common.c b/src/sss_client/nss_mc_common.c
|
|
|
c29843 |
index f38a4a85a..3128861bf 100644
|
|
|
c29843 |
--- a/src/sss_client/nss_mc_common.c
|
|
|
c29843 |
+++ b/src/sss_client/nss_mc_common.c
|
|
|
c29843 |
@@ -130,25 +130,25 @@ errno_t sss_nss_check_header(struct sss_cli_mc_ctx *ctx)
|
|
|
c29843 |
|
|
|
c29843 |
static void sss_nss_mc_destroy_ctx(struct sss_cli_mc_ctx *ctx)
|
|
|
c29843 |
{
|
|
|
c29843 |
- uint32_t active_threads = ctx->active_threads;
|
|
|
c29843 |
-#if HAVE_PTHREAD
|
|
|
c29843 |
- pthread_mutex_t *mutex = ctx->mutex;
|
|
|
c29843 |
-#endif
|
|
|
c29843 |
|
|
|
c29843 |
if ((ctx->mmap_base != NULL) && (ctx->mmap_size != 0)) {
|
|
|
c29843 |
munmap(ctx->mmap_base, ctx->mmap_size);
|
|
|
c29843 |
}
|
|
|
c29843 |
+ ctx->mmap_base = NULL;
|
|
|
c29843 |
+ ctx->mmap_size = 0;
|
|
|
c29843 |
+
|
|
|
c29843 |
if (ctx->fd != -1) {
|
|
|
c29843 |
close(ctx->fd);
|
|
|
c29843 |
}
|
|
|
c29843 |
- memset(ctx, 0, sizeof(struct sss_cli_mc_ctx));
|
|
|
c29843 |
ctx->fd = -1;
|
|
|
c29843 |
|
|
|
c29843 |
- /* restore count of active threads */
|
|
|
c29843 |
- ctx->active_threads = active_threads;
|
|
|
c29843 |
-#if HAVE_PTHREAD
|
|
|
c29843 |
- ctx->mutex = mutex;
|
|
|
c29843 |
-#endif
|
|
|
c29843 |
+ ctx->seed = 0;
|
|
|
c29843 |
+ ctx->data_table = NULL;
|
|
|
c29843 |
+ ctx->dt_size = 0;
|
|
|
c29843 |
+ ctx->hash_table = NULL;
|
|
|
c29843 |
+ ctx->ht_size = 0;
|
|
|
c29843 |
+ ctx->initialized = UNINITIALIZED;
|
|
|
c29843 |
+ /* `mutex` and `active_threads` should be left intact */
|
|
|
c29843 |
}
|
|
|
c29843 |
|
|
|
c29843 |
static errno_t sss_nss_mc_init_ctx(const char *name,
|
|
|
c29843 |
--
|
|
|
c29843 |
2.37.1
|
|
|
c29843 |
|